DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: yang_y_yi@163.com
Cc: dev@dpdk.org, jiayu.hu@intel.com, yangyi01@inspur.com,
	yang_y_yi@163.com, olivier.matz@6wind.com
Subject: Re: [dpdk-dev] [PATCH 2/3] mbuf: change free_cb interface to adapt to GSO case
Date: Thu, 30 Jul 2020 12:16:34 +0200
Message-ID: <10959143.08NVAeP5qT@thomas> (raw)
In-Reply-To: <20200730095610.93384-3-yang_y_yi@163.com>

30/07/2020 11:56, yang_y_yi@163.com:
> --- a/lib/librte_mbuf/rte_mbuf.h
> +++ b/lib/librte_mbuf/rte_mbuf.h
> @@ -1193,7 +1193,7 @@ static inline void rte_pktmbuf_attach(struct rte_mbuf *mi, struct rte_mbuf *m)
>  	RTE_ASSERT(m->shinfo != NULL);
>  
>  	if (rte_mbuf_ext_refcnt_update(m->shinfo, -1) == 0)
> -		m->shinfo->free_cb(m->buf_addr, m->shinfo->fcb_opaque);
> +		m->shinfo->free_cb(m, m->shinfo->fcb_opaque);
>  }
>  
>  /**
> diff --git a/lib/librte_mbuf/rte_mbuf_core.h b/lib/librte_mbuf/rte_mbuf_core.h
> index 8cd7137..d194429 100644
> --- a/lib/librte_mbuf/rte_mbuf_core.h
> +++ b/lib/librte_mbuf/rte_mbuf_core.h
> @@ -671,7 +671,7 @@ struct rte_mbuf {
>  /**
>   * Function typedef of callback to free externally attached buffer.
>   */
> -typedef void (*rte_mbuf_extbuf_free_callback_t)(void *addr, void *opaque);
> +typedef void (*rte_mbuf_extbuf_free_callback_t)(struct rte_mbuf *, void *);

I think a deprecation notice is required in 20.08
in order to apply such change in 20.11.

Please use --cc-cmd devtools/get-maintainer.sh when sending a patch.



  reply	other threads:[~2020-07-30 10:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-30  9:56 [dpdk-dev] [PATCH 0/3] Fix external mbuf free issue in " yang_y_yi
2020-07-30  9:56 ` [dpdk-dev] [PATCH 1/3] gso: fix refcnt update issue for external mbuf yang_y_yi
2020-07-30  9:56 ` [dpdk-dev] [PATCH 2/3] mbuf: change free_cb interface to adapt to GSO case yang_y_yi
2020-07-30 10:16   ` Thomas Monjalon [this message]
     [not found]     ` <f16b530ed9234b988241d5c4b4329d1b@inspur.com>
2020-07-30 10:42       ` [dpdk-dev] 答复: " Thomas Monjalon
2020-07-30 10:44         ` yang_y_yi
2020-07-30 12:18         ` yang_y_yi
2020-07-30  9:56 ` [dpdk-dev] [PATCH 3/3] vhost: use new free_cb interface to fix mbuf free issue yang_y_yi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10959143.08NVAeP5qT@thomas \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=jiayu.hu@intel.com \
    --cc=olivier.matz@6wind.com \
    --cc=yang_y_yi@163.com \
    --cc=yangyi01@inspur.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git