From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F314A04DD; Wed, 28 Oct 2020 15:16:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A3BE6CB04; Wed, 28 Oct 2020 15:16:40 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id E70402C01 for ; Wed, 28 Oct 2020 15:16:39 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 7F2145C0049; Wed, 28 Oct 2020 10:16:38 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 28 Oct 2020 10:16:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= /2h/9ZxGxjq1MbCADxcHMakP9dnpheZYHqSWub3DmYY=; b=unzGQkeVppDBm11m Z34FL0nyF9cgSHr4bcEalkUyszTAUcMwd4XZPYa0m8jziIgQaSM3uc2I87Piy8k8 C2+GMjlByD3nmu/stkFfjgZP0F3PVS9gXUHsAbr2S5jx5hievOvi03vfk822xNg4 bqRr07sjkkSz9h6CFqQrwPNJuNP1DQHm8qu8rUluReOVgoBnVltA2dVC1M9VJtm+ zINwS/44eOzS4fw/w6lwF3Q9rzFVp5573TfxW01wajVtFKHi8+X5W2S9eCXl0ZcF rSo4DfKNSoEWe7qaRAHFPFeH6uUORXSoh8gv8Mf5W35VYBh67paCVszj0LLEqAnl hi1eZg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=/2h/9ZxGxjq1MbCADxcHMakP9dnpheZYHqSWub3Dm YY=; b=d+iNtVryd/YAnHg7u867VqgOnz7RjHNDtcUg14669nmqx4fmaDX1M+xfx Ns2LBI8WTzsF+a36ap0Dd+YmzvPNzZKK7kGx/Meq+s/inL00gpVP917LA2Tcvg/k KnRUc6xPtaG1T4Zqaiy3DpNrTBLn8vG4BExlWzWvNT7SZkwBTmfC3PTYxUydWJBq 4zPBoGlDS2aj8l9xuACswhK7ZG4dr1xXPDOKGt6l++ks205RPxzA7de8VcDs/9OJ 05DO5R3agzqiz0g5W/1JpoP6KD2dzh+JsmQBCMh0dMAYgsP8v+ifvw6lgwbfddm9 W4FqI3Q+5HX9CThCe318Z8FsMKnHg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrledugdeiudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeffvdffjeeuteelfeeileduudeugfetjeelveefkeejfeeigeehteff vdekfeegudenucffohhmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvd dtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhr ohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B5592328005A; Wed, 28 Oct 2020 10:16:36 -0400 (EDT) From: Thomas Monjalon To: David Hunt Cc: Hajkowski , "Burakov, Anatoly" , bruce.richardson@intel.com, dev@dpdk.org, david.marchand@redhat.com, ferruh.yigit@intel.com, andrew.rybchenko@oktetlabs.ru, john.mcnamara@intel.com, ajit.khaparde@broadcom.com Date: Wed, 28 Oct 2020 15:16:34 +0100 Message-ID: <10986713.m8aQ7pRqik@thomas> In-Reply-To: <7d202199-5edd-0278-c3f7-3dc34bbeb5e0@intel.com> References: <20190318115647.14784-1-marcinx.hajkowski@intel.com> <3176678.oQ72JnNS2j@thomas> <7d202199-5edd-0278-c3f7-3dc34bbeb5e0@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2 1/4] power: fix non thread-safe power env modification X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 28/10/2020 14:53, David Hunt: > On 25/10/2020 6:22 PM, Thomas Monjalon wrote: > > 29/03/2019 16:09, Burakov, Anatoly: > >> On 29-Mar-19 2:14 PM, Thomas Monjalon wrote: > >>> 18/03/2019 12:56, Hajkowski: > >>>> From: Marcin Hajkowski > >>>> --- a/doc/guides/rel_notes/release_19_05.rst > >>>> +++ b/doc/guides/rel_notes/release_19_05.rst > >>>> @@ -120,6 +120,8 @@ API Changes > >>>> + * power: ``rte_power_set_env`` and ``rte_power_unset_env`` functions > >>>> + have been modified to be thread safe. > >>> The deprecation notice was recently sent, > >>> so I guess this patch is for DPDK 19.08. > >> Yes, this is changing API so the target was 19.08. However, first patch > >> is a fix and can be applied to 19.05 as well. The API documentation > >> stated that the function was not thread safe, but the code itself was > >> thread safe (it wasn't because it was buggy, but the intention of being > >> thread safe was there), so this could be considered fixing docs to match > >> the intended behavior of the code. > >> > >>> Review from the maintainer (David) may help. > >>> Thanks > > What is the follow-up here? > > We still have an old deprecation notice: > > http://git.dpdk.org/dpdk/commit/?id=3477b7a2cc > > > > I wonder how such things can be forgotten. > > I feel some help is needed in prioritization, > > so let's consider this deprecation as the priority #1 > > gating any other change in the power library. > > > Hi Thomas, > > #1 is now done, I've pushed a patch removing the deprication notice to > the mailing list, as the change it describes had previously been applied. > Patch here: http://patches.dpdk.org/patch/82327/ > > > > Priority #2: cleaning up API which are secretly exported > > for example convenience. It is an old design issue never fixed: > > http://inbox.dpdk.org/dev/6046120.mQ0ExDuKPD@thomas/ > > > Regarding the virtio channel API, Bruce and I had a look at this, and I > think I need to do some more research into it. I'd prefer not to make > that API public, as it was intended to be mainly for the > vm_power_manager app and the companion guest_cli. > > So I'll look into this, and look at the best way to proceed with > cleaning this up so that these apps can be build using meson/ninja as > part of DPDK, as well as using 'make' extrernal to DPDK. > > I hope to push up an RFC next week so we can get agreement on the best > path forward on this item. > > > > > > Priority #3: request feedbacks from other maintainers > > to add a generic API in ethdev to get a hook for power management. > > > > Would it be possible to look at #2 and #3 in parallel? I'm not sure I'd > have #2 done fully in time for this release, and, if not, I will make > sure it's done for 21.02. Yes I'm looking at #3 in parallel but the ethdev API is really not clear enough.