From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F029BA0C43; Wed, 14 Jul 2021 14:23:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DF8B74132A; Wed, 14 Jul 2021 14:23:24 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 6136D4069F; Wed, 14 Jul 2021 14:23:22 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10044"; a="210313337" X-IronPort-AV: E=Sophos;i="5.84,239,1620716400"; d="scan'208";a="210313337" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2021 05:23:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,239,1620716400"; d="scan'208";a="413272510" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga003.jf.intel.com with ESMTP; 14 Jul 2021 05:23:20 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Wed, 14 Jul 2021 05:23:19 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Wed, 14 Jul 2021 05:23:19 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.170) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Wed, 14 Jul 2021 05:23:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i9WqNFEoa8rnx6mf8QR8MBG8XwkchGNuyyNAOhy6rwTuZ7GSSqAcA/1rEjPrvHq8LpvQBP4kpj/yrNciDgbr9wEHJLgGdARFII74QFHaW1UVsWIsuvZ1pV/bcJoYyjNeMNiBYlu3rTLmFOQkJZI5RRgj8kTfIZaT+93Td91MmysXgkvMP/fSzRAAjre8dIGz2JIDiFJRQrzR8hpsc2ZaQGUT8+5gBpe/+YkUx1UYdTJG07075fXwbkwJT/tRheLktjsoA45dQVryBGJsi1UGJcACj9MIYzdoLdMr60UOzkpzZ6e0PkSno1btwS2W1RiAGkPIkPdBk8gQ+NsZp6Oh3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+9DHDCN1wkoctRDs2NwZWbVpEZyk77fHQ+gLu7W+6pY=; b=blAsjA0U/HRoN3zsX448BfoTUGhZCG+IYQz9LxseSfMVK+ePL/XmSSuu2Ggg6QgFEAszLfWRn6DZRsxCyy0JgQYicuyaVNXElNukDR08pHop6UIa/n63vqSUBM5RmVRVD5yNX4lvp/DKO8scZsgXAvgP3GjxNaeOQerlpEfkLnKvGsHcvWGG4WbTqToFiv1m7MQStE9gM6sGiAoxphcjbjSLNtvXPXwmL5JRxAAxCbKnuytM34kMe6brUuSIUnNLFplpU8OD5Yl1EdRAOCulJMlcMZ2JY3Wstvh9ufhSSBnWtvssp4wGTF7hOkQ0vznrLmFwICsvJCLYryZUFyGNKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+9DHDCN1wkoctRDs2NwZWbVpEZyk77fHQ+gLu7W+6pY=; b=X4e/3bYPBn63a3s7iXXxtiSvMbofhnqSVhNNGkcrbdHYSvWvTXBiBRFr5yrNLpc307QcY1f5qRQFe79PIa3TjRA2VMLuRqxcc01s6GAH/udYe0LwJdAWj2X8Q22yVwbdejQmHOiP6tybNGGcd436ZZZ4D4cCKdWv+kW3jcnZ8WY= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5047.namprd11.prod.outlook.com (2603:10b6:510:3c::18) by PH0PR11MB5160.namprd11.prod.outlook.com (2603:10b6:510:3e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.25; Wed, 14 Jul 2021 12:23:16 +0000 Received: from PH0PR11MB5047.namprd11.prod.outlook.com ([fe80::80d7:1f43:844f:e10c]) by PH0PR11MB5047.namprd11.prod.outlook.com ([fe80::80d7:1f43:844f:e10c%8]) with mapi id 15.20.4308.027; Wed, 14 Jul 2021 12:23:16 +0000 To: Richael Zhuang , CC: , References: <20210714084407.51979-2-richael.zhuang@arm.com> <20210714104405.23917-1-richael.zhuang@arm.com> <20210714104405.23917-2-richael.zhuang@arm.com> From: David Hunt Message-ID: <10a8b0c7-af1d-2dfa-6c8d-d4764966a035@intel.com> Date: Wed, 14 Jul 2021 13:23:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.11.0 In-Reply-To: <20210714104405.23917-2-richael.zhuang@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: PR3P191CA0052.EURP191.PROD.OUTLOOK.COM (2603:10a6:102:55::27) To PH0PR11MB5047.namprd11.prod.outlook.com (2603:10b6:510:3c::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [10.4.11.161] (95.45.22.52) by PR3P191CA0052.EURP191.PROD.OUTLOOK.COM (2603:10a6:102:55::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.20 via Frontend Transport; Wed, 14 Jul 2021 12:23:14 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6a67c379-0a2f-43a2-4356-08d946c227fc X-MS-TrafficTypeDiagnostic: PH0PR11MB5160: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4502; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Em3FVvqehdLxKEWWwK2qeCeCpA6Lk8ZLpK6A4KpW46JqhHoGO0itF4gqC/GBiCLavUNsEs6jYDuymlGm8UpgaJ2xhDiTpKiq0evdCFUQZtry+R52GhUITVXluqoQN2ku+z7vssDu1fAaqS4U+yGYWLxNR2GJnec+S2IbIhPxd52ZwVqOi11KcJ2pGVppZPDiNuKdCWhAVgozw6WiRSZ7bsHEeprY7pZb9ae3YbU7dQiijaeJE6l2qiw/ij6GIZlwGoUvmZ2si3iaOqiInWpsRSDC0Y/FG6sNRZPHNeL7JZTWeRFK83adWPVn36hZLO5WCLj8byAnlpYZF5QaQ074XkqedqFiK1v+vVw/TjU2DNLg+j8Emr/7IxycC6wOTT2fb6iq0+sjAl/jj4a+4X182iLwqz+DfLzA6W82CJ5DPYjFEnkISyYsSwKfFbW7xF6ZCf94C5qFE2g+FJPWt+6azIRlri/HZRFzXrhCWV7kCS0078AfAbRTcRKvHf4YrV0oGj20sprfZIglfHKxLTk5oJ1NdMFvtfu0CIlUx4VUCFzMqVzBLyexfw/rFdZwmy2A7sQaqTyP7XvKZpnBYgHJ3gn2eQZZkVcbWHOknTts6Wmt/4pxiw11SsccAcnth7akrOzG8mXHXUGs87FQ/xz2nsBVQI/yCzwrSReFnx4rofTXdoNEb8MiIfMxt9uU5fDkgeD3bF9uH89kmJiI0JZ9Vr61l/AfcipZmAqBsLVYpfI= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5047.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(366004)(346002)(39860400002)(376002)(2616005)(956004)(66556008)(66476007)(66946007)(86362001)(6666004)(4326008)(38100700002)(316002)(478600001)(53546011)(36756003)(186003)(83380400001)(6486002)(8676002)(2906002)(16576012)(31686004)(8936002)(26005)(31696002)(44832011)(5660300002)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eTEzZXBZMzY5RDJHczJOVlhRSkFESnB2QTF3WGh2RXFuQXJ4YXpINWZOMnQ2?= =?utf-8?B?NDNsNnp2Y3VpT0x0Y1lQb0pjaWRML3FqaC9CSDE5ZUV3RHhjaldnNm9lZTRV?= =?utf-8?B?SnN1UDdaTTZNeWozT3hzQVZRYzRmbEcxejZpQmVFWVJOaEg4S2d1TGxaK1lW?= =?utf-8?B?RUg5T3ZFRUFqblAwVHQrK2tFQy9MS0JYZ0VrTUNaMGJ1ZGEvdWZoZkxkdmpy?= =?utf-8?B?R1hScjlHOVdxRTR2RHhyY2J0d1p6M3lxY2tTWGQ4WGtVcXRIRVB5QmNXTFV6?= =?utf-8?B?WllMZVJ3d1VIaFZBbUpmeVdrc2d1UUN0YytmTU40emxPRDBEZ1phcW1RMGRl?= =?utf-8?B?c1pPOEJONzc5ZzFMOEowWXEzMm1SVW5HbDBzcjRiMUtXeGFIYmhkOW9PSExW?= =?utf-8?B?UldEVXdxcVlxQUJ1bEx6bm9iWXFyVG9uWVQ1WkF6OU9jenc2NEJzWE1wcDhP?= =?utf-8?B?M2dpdVFVUWZSUkpxN1Ntc09vK2tzTHB0cUlRSy9sS1lIZVFHa1AwdXdJY1hs?= =?utf-8?B?bis1OUtJSFFmOUJnWmNDM01rQjlub0ZaOG4waVRjK3NXeEkzTjJaYktjMURa?= =?utf-8?B?UU1qOTBqYXZDNzVmRXR3alJXanhZbDFuSmFraEd4S3A2c0JvWmh1bG5IRkVK?= =?utf-8?B?VFJUTVFCSm1QRUt0ZFJvKzViOWU4ZU8xbmEvK0RMYkJPN3p2bzFCNjc3SFhm?= =?utf-8?B?L0UvclBVRmFvbXhqc3IyOXByOEhhQVlzZFJENmY1T2l3Qk1PMWV3ZmdMKzVk?= =?utf-8?B?S2dQZzhXS3dWM0NER2puL01kL1NHUVMzYjhtOGMrKzQzQUhDM1V2YlhRNWF6?= =?utf-8?B?citseWxqRmdSdllzSFZXdjBqb2kzancxQjFONE5TS1U0TDY0TU10TFpZYnJo?= =?utf-8?B?c24vUnF3M0tBSnpSZTlSRXJ2U1NRRSs1Y2pJd2JHbFpCMnIvK0R4S1pzWjE2?= =?utf-8?B?bVZyRWJEaERKZkpDZjFqSW0yLzZ1aysxQXdJN2dwWEJyUm1CamwvcEhBRGwv?= =?utf-8?B?UHY1QlhIME5hMTd3NUNaQzhzOURza0NiQzNxaWt0VXJjbDFYZU80aTlUU1Av?= =?utf-8?B?Q09QMjhCWTJLOFVkZVNhUG9UZEhkazNXZnhEVnZjeWI3NTFhV3l0M0V4UTlS?= =?utf-8?B?NEpTUjcxczNhbHV4QW9jTXRtU2VVeUpRNXpDanVaSFBXaXhzTFhjQndLMXc0?= =?utf-8?B?RHYvQ2czRmJ5R0d4K1VHRlllT05nMUNucklDUk5SdVdHQ0ZFMnVnemlJVWhP?= =?utf-8?B?Y2hqUVZXTzlndjBPRVp0Q2hNVVZ2VW5JL2kwZm1GQWxIWDB6MUozZkFNNkFu?= =?utf-8?B?LzJvWkUxeW9idCtPUGJJRE5uZ2xYaG5pVEFCQ0FycnBoR3pCRm16TVc3VnM1?= =?utf-8?B?Y2xHV0t4UHlHMC81RHFRSTJTVzh5V2RPVkxHVnpWaTBYdHBxaUFpWDh2SFR3?= =?utf-8?B?TjUxWFlFSk9idy9IcTFSOVpyQWcxeXIzYVRYU3VzSHZKYnpmZWszL2VKd2NP?= =?utf-8?B?YXlxMmtFQTI4ZmJzVGV5TEtuZ2c5QU9qMUswTURtb2JkQTJrWlpoMEJOYnpr?= =?utf-8?B?bEZOSUMrenRKcEtjaS8yZSswZThvRzF2dHY2disvM28zV2RQNWIydk45bzVk?= =?utf-8?B?amRPckJKMTBxV25yQk40dXlrVGFqanA2WDd4VGFZR1IrRlc4UGRKUkxySGpt?= =?utf-8?B?b2lhRFRablZ6R0E5TXFnRlZUYVNvZGNYZTE2RlBMZnBsb1FuVjFCZmgyTDFn?= =?utf-8?Q?8m1fanbHqh22Ag6pFnJau7c7Hnq84uWUa/nv3rl?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6a67c379-0a2f-43a2-4356-08d946c227fc X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5047.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2021 12:23:15.9871 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tGo+cRlVlnq/pGlqOIpVjoy0Dic5jZCUCbZPjgLFZgEs6aJq+50yW5QZ2EHWXqq9bhN+Nxk+6XFfsNSmN5Y3cQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5160 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 1/1] test/power: fix CPU frequency check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Richael, On 14/7/2021 11:44 AM, Richael Zhuang wrote: > For acpi_cpufreq and cppc_cpufreq, both cpuinfo_cur_freq and > scaling_cur_freq exist. For pstate, only scaling_cur_freq exists. > And value in scaling_cur_freq and cpuinfo_cur_freq may not be the > same. For acpi_cpufreq and cppc_cpufreq, we should check > cpuinfo_cur_freq but not scaling_cur_freq. So here change the > check sequence to make sure it works for all cpufreq drivers. > Besides, add rounding for pstate driver. > > Fixes: ff6dfb8e492f ("test/power: fix CPU frequency check") > Cc: david.hunt@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Richael Zhuang > --- > app/test/test_power_cpufreq.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/app/test/test_power_cpufreq.c b/app/test/test_power_cpufreq.c > index b8fc53925c..1a9549527e 100644 > --- a/app/test/test_power_cpufreq.c > +++ b/app/test/test_power_cpufreq.c > @@ -62,13 +62,13 @@ check_cur_freq(unsigned int lcore_id, uint32_t idx, bool turbo) > int i; > > if (snprintf(fullpath, sizeof(fullpath), > - TEST_POWER_SYSFILE_SCALING_FREQ, lcore_id) < 0) { > + TEST_POWER_SYSFILE_CPUINFO_FREQ, lcore_id) < 0) { > return 0; > } > f = fopen(fullpath, "r"); > if (f == NULL) { > if (snprintf(fullpath, sizeof(fullpath), > - TEST_POWER_SYSFILE_CPUINFO_FREQ, lcore_id) < 0) { > + TEST_POWER_SYSFILE_SCALING_FREQ, lcore_id) < 0) { > return 0; > } > f = fopen(fullpath, "r"); > @@ -85,7 +85,7 @@ check_cur_freq(unsigned int lcore_id, uint32_t idx, bool turbo) > freq_conv = cur_freq; > > env = rte_power_get_env(); > - if (env == PM_ENV_CPPC_CPUFREQ) { > + if (env == PM_ENV_CPPC_CPUFREQ || env == PM_ENV_PSTATE_CPUFREQ) { > /* convert the frequency to nearest 100000 value > * Ex: if cur_freq=1396789 then freq_conv=1400000 > * Ex: if cur_freq=800030 then freq_conv=800000 Looks good now. I ran the power_cpufreq_autotest test on both the acpi-cpufreq and pstate drivers, and both passed. Acked-by: David Hunt