From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f180.google.com (mail-wr0-f180.google.com [209.85.128.180]) by dpdk.org (Postfix) with ESMTP id C07117CD7 for ; Tue, 11 Jul 2017 01:20:09 +0200 (CEST) Received: by mail-wr0-f180.google.com with SMTP id c11so159280935wrc.3 for ; Mon, 10 Jul 2017 16:20:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=vRhMLKVJFCQ+ljagOXSItDuYDVVfb7MCriCxsZr9q84=; b=rYGJ2XXp75WLx2c8uLmbKI5qA5hNIqdcurlabjzbCCAuFVzNkVYpRh1L2fDbHOGweW IIOFGDlegLVYlJ1nZG1MiiFFmuPUHVESIOY501uM5LhbbMAbebnmGCUBGIy9GUwk/wre wDQINWjAJvkhyc1e0N/UBBcqV/Z4d14tefGVTfbK3JNGl4pwjiUfZ0ZAPh8lAAoLIUTK 8UYJqYf5O7WrlfPTo1T4QZu+jO/y57EgBDZCXwjzwqr5R94c2cuGRfPbSgZWFkcur+E6 YA/S4rmd88HMzbymQoDX8fKdNAQ5KTOIxbS1iPjX5dzbN5+yCmukldnaBnkpLXNNnODx efPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=vRhMLKVJFCQ+ljagOXSItDuYDVVfb7MCriCxsZr9q84=; b=qx3wOeO7vaSeKHtt+s5Ao8DObazpNR7flBRFwPsh/bhiB5Gafe1T5EB5bg1pJ8GGhb EwSBRtGnCkNtmq2I3u/itgapW3GZeQwfvYeP9iGtEiNorYEdjmKJlvOBeCygfy/vDmdX PxQHnhvbYCzuD185VUGSjE9RWZbqAXgOFlRIsFIJhol/piHAKe6JttXQrOmSY76TBFb6 mcXs3sEWZfGpgsaiMcXJkwK5dXULJOhPTOpnDLHsvnvovEnV42tvZ/3m0088KY6cIP+8 dk7yAJU9XrozRzadVTNNK2MVqEbvUDkE3Wkco/Fe1+7E5QIOX9W5wfvJGsCNsz8p+lzi ZY9g== X-Gm-Message-State: AIVw113THMkfB0mjhF9L+welt6BvouUQ8jmruNt2Bs7xq16AP2MwYQmD O/fZW5v7OQ/aKamiprs= X-Received: by 10.223.136.135 with SMTP id f7mr8259686wrf.148.1499728809046; Mon, 10 Jul 2017 16:20:09 -0700 (PDT) Received: from bidouze.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id k137sm11805038wmd.22.2017.07.10.16.20.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 10 Jul 2017 16:20:08 -0700 (PDT) From: Gaetan Rivet To: dev@dpdk.org Cc: Gaetan Rivet Date: Tue, 11 Jul 2017 01:19:43 +0200 Message-Id: <10a9b05ba5ff4f52d76a9d0670d7acb4bae7b8c7.1499728587.git.gaetan.rivet@6wind.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: References: In-Reply-To: References: Subject: [dpdk-dev] [PATCH v8 02/11] ethdev: count devices consistently X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Jul 2017 23:20:10 -0000 Make the rte_eth_dev_count() return the number of available devices even after some are detached by the hotplug API or put in a deferred state. Signed-off-by: Gaetan Rivet --- lib/librte_ether/rte_ethdev.c | 16 +++++++++------- lib/librte_ether/rte_ethdev.h | 13 ++++++------- 2 files changed, 15 insertions(+), 14 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index 69896e9..8f41a68 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -72,7 +72,6 @@ static const char *MZ_RTE_ETH_DEV_DATA = "rte_eth_dev_data"; struct rte_eth_dev rte_eth_devices[RTE_MAX_ETHPORTS]; static struct rte_eth_dev_data *rte_eth_dev_data; static uint8_t eth_dev_last_created_port; -static uint8_t nb_ports; /* spinlock for eth device callbacks */ static rte_spinlock_t rte_eth_dev_cb_lock = RTE_SPINLOCK_INITIALIZER; @@ -210,7 +209,6 @@ eth_dev_get(uint8_t port_id) TAILQ_INIT(&(eth_dev->link_intr_cbs)); eth_dev_last_created_port = port_id; - nb_ports++; return eth_dev; } @@ -283,7 +281,6 @@ rte_eth_dev_release_port(struct rte_eth_dev *eth_dev) return -EINVAL; eth_dev->state = RTE_ETH_DEV_UNUSED; - nb_ports--; return 0; } @@ -308,7 +305,15 @@ rte_eth_dev_socket_id(uint8_t port_id) uint8_t rte_eth_dev_count(void) { - return nb_ports; + uint8_t p; + uint8_t count; + + count = 0; + + RTE_ETH_FOREACH_DEV(p) + count++; + + return count; } int @@ -341,9 +346,6 @@ rte_eth_dev_get_port_by_name(const char *name, uint8_t *port_id) return -EINVAL; } - if (!nb_ports) - return -ENODEV; - RTE_ETH_FOREACH_DEV(i) { if (!rte_eth_devices[i].device) continue; diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index 2adef76..a744ba7 100644 --- a/lib/librte_ether/rte_ethdev.h +++ b/lib/librte_ether/rte_ethdev.h @@ -1742,13 +1742,12 @@ uint8_t rte_eth_find_next(uint8_t port_id); /** * Get the total number of Ethernet devices that have been successfully - * initialized by the [matching] Ethernet driver during the PCI probing phase. - * All devices whose port identifier is in the range - * [0, rte_eth_dev_count() - 1] can be operated on by network applications - * immediately after invoking rte_eal_init(). - * If the application unplugs a port using hotplug function, The enabled port - * numbers may be noncontiguous. In the case, the applications need to manage - * enabled port by using the ``RTE_ETH_FOREACH_DEV()`` macro. + * initialized by the matching Ethernet driver during the PCI probing phase + * and that are available for applications to use. These devices must be + * accessed by using the ``RTE_ETH_FOREACH_DEV()`` macro to deal with + * non-contiguous ranges of devices. + * These non-contiguous ranges can be created by calls to hotplug functions or + * by some PMDs. * * @return * - The total number of usable Ethernet devices. -- 2.1.4