From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD589459FD; Sun, 22 Sep 2024 17:24:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3255B40274; Sun, 22 Sep 2024 17:24:05 +0200 (CEST) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2070.outbound.protection.outlook.com [40.107.102.70]) by mails.dpdk.org (Postfix) with ESMTP id DE1C14025F for ; Sun, 22 Sep 2024 17:24:03 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=m/r17ZLnv4O28OWtSVRzTpb9tr5bf/fqJ843b9CSpFwDAat++ADnN3jIXZfgTp2ANeoaTTk/Dsuscpt4hU4ksv9jOCxfEA00tHBU/PJWMTKtD2eLWeXVow2ly8NcG8EkAJSDTsliZVcnG3OXikcNm32VxoAMuU0VfRL++nwV8K8LjUJUVh/aS8D1/yjYUlImWokteiEd42IpkcuGRyMCnV5KlUUhp2JpyIzg5ts9PQ4OxiHZPtR/AyQUFtvuef/nzZ8GyjsMK7EGCYKbughxY6jZoAo++urXIMz96ajwPRuwpNsVnz9Kssdi57e5dr3Au5vBpM0/+svs+1bfMTJGgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=biz87M+yMm+UBN4eQNSj8j9xJttJO9PzYROdW+ucDSY=; b=Iu3qr7K+Ex8k8E5dEWy/OYJcXZ0LxKVWbTX5W9jpGeZ+FYMuBCb/TVwEs0Y/t20C/ycI/7xu+L5VJ9A0qpRlt3Lb853bRzUKWLZZLYjbaMpuKe5Rr9/k3nGAcd99/uaf4k2u2TdGVSjePvRmz9kVAzPly7vy+DV/QXbGQo4Pq5HMDknkaIWLsgtZYhu/LY+7oD4gxeDRfeoXkmKaiWhL9MRIb0cw4kNspeD5qX48A1HSTlY6gUb+ZXLqYH7nBS9AzEBgiy9SQnfM9+CVJRvoWZKmc49oFw4SUmwpS/TV3EAqxdA3eCnfXRshFW1ZVQFC8JnD3OA4cRodLSzbfZwA3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=biz87M+yMm+UBN4eQNSj8j9xJttJO9PzYROdW+ucDSY=; b=Hl/DOsGrRoInV8I71fnR4I39vSd6WAD78o38q7qjhiyeObAa/U0NB+5Nu2jF8GqzVdD2+v1kZFy2DUP58WR3aIYqn1DEWE5l/ERpvlKoiyN7O/CJciJmOmbnTK+EN0LnfxgF6Vt1lvSUdXwYkyMdMjq1EBDf1o76JEZU7lAu0dQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) by MW4PR12MB6804.namprd12.prod.outlook.com (2603:10b6:303:20d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7982.25; Sun, 22 Sep 2024 15:24:00 +0000 Received: from SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055]) by SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055%4]) with mapi id 15.20.7982.022; Sun, 22 Sep 2024 15:24:00 +0000 Message-ID: <10e4b4ef-093d-4733-a7ee-8b497de0271e@amd.com> Date: Sun, 22 Sep 2024 16:23:54 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 14/18] net/dpaa: add Tx rate limiting DPAA PMD API From: Ferruh Yigit To: Hemant Agrawal , "dev@dpdk.org" Cc: "ferruh.yigit@intel.com" , Vinod Pullabhatla , Rohit Raj References: <20240801105313.630280-1-hemant.agrawal@nxp.com> <20240823073240.3708320-1-hemant.agrawal@nxp.com> <20240823073240.3708320-15-hemant.agrawal@nxp.com> Content-Language: en-US Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0072.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:60::36) To SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB8830:EE_|MW4PR12MB6804:EE_ X-MS-Office365-Filtering-Correlation-Id: c35cdb61-0796-4d44-5585-08dcdb1a954d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?SVdtTnFxWkVPYjFJK2VJVW54U08ydlRZTjJ0QnE2ME9DSEZkbjNUempNY1FT?= =?utf-8?B?T3dlT3lOVVAzeEQvd3Y5OFhJQkExQW1iQ3JyU3dTaGNGQi9SdnU0OVFCVlFZ?= =?utf-8?B?aDVHbEJSZ2xPL3JhZmlKb0VrT0tZZDRLRitYNnpqYUI2eFdqdmdZMnNGcE9M?= =?utf-8?B?cFFzK1Y4UmJqV0cwcHpLQnVNUHF1VUFUUEJ5UGZKVnd4V0loK0lrdnRuQTJR?= =?utf-8?B?T2tXUGwzVFk0ZFNabHF2UzZ4c1QvNVVRc1phVDRPa25XMVFBN0drZGd5OS9j?= =?utf-8?B?VC94OFhmandob1pRY3NjakdtcWpPQzhqTWxBWkpSbU8rcW9DVm9zNlV2dEl2?= =?utf-8?B?TVJVREVOL3VhS3k2cXM1RHpWTTR3eCtSZ2lDa1pNYXBvUlJPczJ1aSs2cTFP?= =?utf-8?B?dkZuaDlnem9JWVpvR095VkFHZzJCcDU1NkE5eWdsdDZtVFlYYnRObGtwd29F?= =?utf-8?B?c3hYWUtabythWHFyNWhKc1hIQ1JXWGVmM3FrdkFORUJ2djZJYXVrb25QS0JI?= =?utf-8?B?dFZOOUwzM2pKQVR1MEswTGx3d2dCUGN2cTJRcnN5bk9oYjJUUUc0ZFoxZnY0?= =?utf-8?B?WWhRdGZGak9IWmppWHFqSThzbWhjcVU1dmRndTI2ZW8yZXpBdDhjYk0rVHdT?= =?utf-8?B?K0llaCszdGdoV05QeDErRVVBRnBjdW9pZFY5U21ocm9OTjBOdE9iY0FVUHds?= =?utf-8?B?aXRKb1J2MWRsclJldXpjY3BVa090VXJaSzN3VXVHa1B1TWZtM3g3WmVqanNj?= =?utf-8?B?eWRLaEdHMytJSURaWXQ0ZFdka3o3b0IzNmYzSWxncitFeHRBMUM3T2ZzQ0d4?= =?utf-8?B?d3dBaitqM3B2enJ2U0Z4eHJETjJ5Vy9tT2FvemJBajRqRmpUTnhxb2s4OUR1?= =?utf-8?B?dlhleE03aHRQUWNibWQrMFRjbTYvSStFb1lSdFVEaElaV2xCS2lNTUQ4dS9T?= =?utf-8?B?RmhMeTExZndHcVBrb0l4SmpUQ0RGKzJZa2VIbFJaaGJJT2lMT0ZYN3ZPSlZM?= =?utf-8?B?LzY5Mml6WDZuL2JHaHZkQnNONkl3Y2NaVmo4VTFaaS9qTitxaThYUWlpdFR6?= =?utf-8?B?dzlQYk8vSGxLYVQ2VHg4Y2R5Smg0SnA3LytrZkNmM2JDT2xCbi9rQW5OQTZN?= =?utf-8?B?eUtSTEtackxvdzJZVVprRkdwUlhlUVhIRkZHWTRXV1FHN0ZQWmpRYWJzYWdE?= =?utf-8?B?SmxzL0ZFTjFWcHBqM00rSkc3ZkJwWHpSeUx3WUkxNWlDV0owK1VKcUg3eXJB?= =?utf-8?B?VTNBb3dzMWU0UTY4QmkzbnNXYnJZb0Z6TVBuRnhlNkpFQXhSUXE0NjFrbHFt?= =?utf-8?B?Q3hhaHZ2TVYyZ09mTk5XZmNwbjhEbTVUSjUrL3BQWVRMdis4dWdwM1l6b0tp?= =?utf-8?B?Z05hU2o2U0hhcEtHSjcveFp2Q2hEOUVNUVluV0pUbnlacWcweWwyczZnL0pV?= =?utf-8?B?a0hkRFZDekhzVkdUbDR3SXBnTEc4V0tqZWMyRWlNd0I0RjR1aTVpMlF6UHo3?= =?utf-8?B?TzQ4THBBQXRHNlFqandEQWE3NWZqeG5KMXFNV2MwZzQzRWhUbm83ODBTNG40?= =?utf-8?B?QVAwYlNpNWpYcWhsNkplL01aVVV4N3FBSkxKQ2gyd1ZtaStEUFUvR1N3Ky9L?= =?utf-8?B?MVh2cXg1Nng4Mk9zenRMbGZuTkRwL29QWGVGeUY4RVN2N0dBTXBWS3lEQkVW?= =?utf-8?B?SUZVZ3JLYllmbSszS1o4UlVVaUQyNUVzSUsrNnBGSjRKQU8vNDc2dE5RPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR12MB8830.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TlFMenh2Nm5DeklTdjM0WHZWVUk1TDIxOHJHVWkydXhuNUQrT2htbjRvRnA3?= =?utf-8?B?RlB5ZlVWZTNXdjBXTGtyVUNWRkN4bmVXWW9hd1YyMTBoVGUzN3RJQ012ejNt?= =?utf-8?B?bmxVN01iTlpkSHdKMUVMTGRxM1BuQmNPV0NRVUVxbldhVWdmT05oWTV3RHM4?= =?utf-8?B?aHFybWtZS0JlMWVMUFBxUkJwTm1EWG93U28xdGRHSjJGLzllaE9NYjQwajlN?= =?utf-8?B?TnRYNmIyK25wSWJZcy81VEZRSDFseGtteG1JSGl5OEpqK1Q3TWJkYmlMd1Ni?= =?utf-8?B?cGk5QTlIOStwaGZxRUpCVzNTNkJXOE1DQUN3ZFVSQUt6QTVnY2l2a2dDNjBN?= =?utf-8?B?c1lET3J3L3VtVEx6MmFlbmFLTzJsZlhVRVc0Z0V0TFNPdUVJWUZSZWV3NXNx?= =?utf-8?B?KzNlRC9kVG5ENnBxdkdZR2ZZNHNkZ2dQaXJVZmVKT3ljMk5IVmpvc1JRYUtB?= =?utf-8?B?MHZ3UFRwaWliME1vZDM4YVZWQmNtN2hGamJFMjR2bU1sV3BWUTU4disxTjRp?= =?utf-8?B?VDF6VS9hY1hjRmNGdVkvYzBGMkg1TnAydjJBUDFXSDVMMkQ4RWFaM2Z0WEFm?= =?utf-8?B?K2NTb0YzdEs0WUxFVGg4aXlsNVovdHM0RmFaS2xtZXM1SUN4QVl2SnBWSEZF?= =?utf-8?B?M0IwOHp1QWV2YWdYV3UrelhjZnpTcGpQQTZ0Wk83QnA4TUx3YWJabyt1UDZH?= =?utf-8?B?bmMwVGE0NVpXZkE2UllTMGI1YXdQRUJPWURJeXhsY0VRejNrZUQ1bVQ5ckN0?= =?utf-8?B?MCttY2pPSVZ3dGxaWFIvMzNHeWhldnNqaTA2czJNb2x4bit4VWpWak1IeUh5?= =?utf-8?B?UC9sQjVKcEVoVGl6ZEpab0srdmVRRU1HZHlsVnp0R1F1dTN1ZytSRFZuWGdK?= =?utf-8?B?NHhnbHA2NHlBZ1RlWTNibTlTVS9RbS9xSDFQZUR4eFQvdzZmQWpPcFBEVzhN?= =?utf-8?B?OXpWamE1K2dkL095WklvQjYzeitQaStmOUYwZzdpVFNCRE1MaFZ6VjZEOGds?= =?utf-8?B?NE9vTTkxM2NpVnR0OFl6Y3d6aElEbUcxaS83Yzh5K0sxcHNwVklQSXFCMkxt?= =?utf-8?B?a2w4TWJYbTh2alkraHNNTjhHWk9KdkNPdXRzeFZESjhpUFJWZFZpWTh6blhM?= =?utf-8?B?cmlQZ1dJNEE1YklTR2xZWHArZ0NCN3JtRy9iN3ZFUGtHV1ppRjlONmNtYnFl?= =?utf-8?B?V1pMU2ZIc1pHeDNHREM0clhvZm54V1drUkk0cFdmN2Vlei9Tb3d3Nk1UZ0xq?= =?utf-8?B?M2IvOU9ma2ZVL0JEck81aEZIUWJLTlJKQUpxWTdLVHVCWEROa1F0VUNSaU1h?= =?utf-8?B?elBHeUpqZFhCajRuVXVhTjF4aC9FZFpEVVFLNHNvNEdrRU1YMCt4VUJnQ3NS?= =?utf-8?B?ZTBWZUpBYkRyUmlOVEdZdkhrSlJkUW9HTFdvTVhLclpVU1dFaDc2Unp2a0Zs?= =?utf-8?B?VGJUU1FyaWZ3T0lRbXdVVzFJVHpnUUtvK3RJQjFlSUFpU2V5dmN6Wmx0OHFa?= =?utf-8?B?NEpiS3EyS2JXclBWQnh3TU5hNVMzSTRsTmZQU0Q2eTBWMjBMdzMxOXIzbENQ?= =?utf-8?B?dHVKVWw2KzdyaEhqeCs2UmlORnNJYTVOTHNueDE2UGVlY0xkT0puNVZ6ZGR1?= =?utf-8?B?UXk2OTR6REw4YTJHYmFZS0Q4bG9lSzJPQ1RtVU40d1VtTjk0djNWcHQ3cmRZ?= =?utf-8?B?TjZXclVLZGMrOHBJRld5aDQ2Mm5MNkFmeGRmZVh4S1I3WXRJZDlzRE5HTjla?= =?utf-8?B?VXVGVU9BQXZxeDBmL3hrd0RKSjFLWDB0UldIUTFPZWJSNE11Uzd0OXhSdDkw?= =?utf-8?B?akZqWDJKaEczajdUK1RyMGU2bzVrbVBZYXJ1T2FoN0NIYzlCc2Fnc0pSbUFE?= =?utf-8?B?K0Y5bis1M2dweDlzMzVwVXNOdGlLdklKUE1pRlF2KzluQjMyYjFHS3drTktI?= =?utf-8?B?ZHdZUGlOc0xKcFJ5QnZ1TkR6cmYzQzBJZkNnOU9GUkFzV2ladlM3ZUc3TVBF?= =?utf-8?B?V1JRcWp0V1I1cU5KWEpLbXpLTHRBWG5BWUMvejdPMk9HSE5zRkZjMGxpMHVy?= =?utf-8?B?SVZwNllFU3BUYkwxK0kzNWJQTU9xY1Y0T1p3bElja3I2YzF5RXZWTHRTeWxF?= =?utf-8?Q?UbCj/SiXkFoKd+QRmx/GRAcfy?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: c35cdb61-0796-4d44-5585-08dcdb1a954d X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8830.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2024 15:24:00.2396 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YU8bHlOzbC4d62ZBkz4tXqePRi7O3otik4Q6wMaehuyBiHAfAyqTQNr52nxj99WU X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6804 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/22/2024 2:27 PM, Ferruh Yigit wrote: > On 9/22/2024 5:40 AM, Hemant Agrawal wrote: >> HI Ferruh, >> >>> -----Original Message----- >>> From: Ferruh Yigit >>> Sent: Sunday, September 22, 2024 8:44 AM >>> To: Hemant Agrawal ; dev@dpdk.org >>> Cc: ferruh.yigit@intel.com; Vinod Pullabhatla ; >>> Rohit Raj >>> Subject: Re: [PATCH v2 14/18] net/dpaa: add Tx rate limiting DPAA PMD API >>> Importance: High >>> >>> On 8/23/2024 8:32 AM, Hemant Agrawal wrote: >>>> diff --git a/drivers/net/dpaa/version.map >>>> b/drivers/net/dpaa/version.map index 3fdb63caf3..24a28ce649 100644 >>>> --- a/drivers/net/dpaa/version.map >>>> +++ b/drivers/net/dpaa/version.map >>>> @@ -6,6 +6,13 @@ DPDK_25 { >>>> local: *; >>>> }; >>>> >>>> +EXPERIMENTAL { >>>> + global: >>>> + >>>> + # added in 24.11 >>>> + rte_pmd_dpaa_port_set_rate_limit; >>>> +}; >>>> + >>>> INTERNAL { >>>> global: >>>> >>> >>> PMD specific API needs to be justified, can't we use TM framework for this, >>> does TM needs to be improved for this support? >>> >>> What do you think to send the rest of the set without this patch, so they can >>> progress, and this one can be discussed separately (assuming there is no >>> dependency). >> >> [Hemant] I think, I replied to your earlier concerns. >> >> We are yet to implement TM framework for DPAA1. But that involves more of egress QoS. >> >> This one is additional capability to limit the ingress port. Kind of policing in Rx side. >> >> However, if you still disagree. Please apply the series without this patch. >> > > Let's detect what is missing in ethdev layer for it, and what is the > required effort to cover it in ethdev, first. Based on findings, we can > continue with PMD API as last resort. > > I will continue with patch series without this path. > Hi Hemant, I removed the commit 14/18 from set, but it impacts other patches, I can fix the build but can't verify the functionality, probably better if you send a new version without patch 14/18. Btw, while resolving conflict I recognized that patch 15/18 renames 'fman_offline_internal' -> 'fman_offline', and next patch (16/18), renames it back to 'fman_offline_internal', this creates lots of noise in both patches, can this be prevented, I will comment on the patch?