From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 26A30A0559; Mon, 16 Mar 2020 13:12:14 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0369F1C025; Mon, 16 Mar 2020 13:12:14 +0100 (CET) Received: from smtp-fw-33001.amazon.com (smtp-fw-33001.amazon.com [207.171.190.10]) by dpdk.org (Postfix) with ESMTP id 5264C1C06D for ; Mon, 16 Mar 2020 10:34:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1584351293; x=1615887293; h=from:to:cc:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version:subject; bh=uT2bkFXhel5uEk7ZT1yA6B9v1xWq3Kv6V3nLnE5nDzY=; b=kXbpW5keuMubHSN7JADts8FCTo6eNtho6NijAn5CDMJhHKKJlcOQ/NPQ Poh9ONRcswSLGka0ng3yD5cGsAAKzW2QsGEyOhG+0rvHi/bV4+sMIyl74 vJo389NocZajW9DQlvKgjTombKRELCJmQNx/zOgtnom20TIkK+DYUG7MY A=; IronPort-SDR: WRU1qOmDoszEUZN9XFu47y7mHiC762QdDCIeHj2ufbZyJaiTwq2LpLtk/yRL0xWfbd7/zd/S5u AVm96x2ldoFA== X-IronPort-AV: E=Sophos;i="5.70,559,1574121600"; d="scan'208";a="32772699" Thread-Topic: [PATCH RFC v1 0/7] relax barriers for ENA PMD and small fixes Received: from sea32-co-svc-lb4-vlan3.sea.corp.amazon.com (HELO email-inbound-relay-1a-821c648d.us-east-1.amazon.com) ([10.47.23.38]) by smtp-border-fw-out-33001.sea14.amazon.com with ESMTP; 16 Mar 2020 09:34:49 +0000 Received: from EX13MTAUEA002.ant.amazon.com (iad55-ws-svc-p15-lb9-vlan3.iad.amazon.com [10.40.159.166]) by email-inbound-relay-1a-821c648d.us-east-1.amazon.com (Postfix) with ESMTPS id 85CFBA24AA; Mon, 16 Mar 2020 09:34:45 +0000 (UTC) Received: from EX13D06EUA001.ant.amazon.com (10.43.165.229) by EX13MTAUEA002.ant.amazon.com (10.43.61.77) with Microsoft SMTP Server (TLS) id 15.0.1236.3; Mon, 16 Mar 2020 09:34:44 +0000 Received: from EX13D12EUA003.ant.amazon.com (10.43.165.147) by EX13D06EUA001.ant.amazon.com (10.43.165.229) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 16 Mar 2020 09:34:43 +0000 Received: from EX13D12EUA003.ant.amazon.com ([10.43.165.147]) by EX13D12EUA003.ant.amazon.com ([10.43.165.147]) with mapi id 15.00.1497.006; Mon, 16 Mar 2020 09:34:43 +0000 From: "Chauskin, Igor" To: Gavin Hu , "dev@dpdk.org" CC: "nd@arm.com" , "david.marchand@redhat.com" , "thomas@monjalon.net" , "mk@semihalf.com" , "Tzalik, Guy" , "Schmeilin, Evgeny" , "mw@semihalf.com" , "Honnappa.Nagarahalli@arm.com" , "ruifeng.wang@arm.com" , "phil.yang@arm.com" , "joyce.kong@arm.com" , "Bshara, Saeed" , "Matushevsky, Alexander" Thread-Index: AQHV+RiToWy1oK5ESECh29vmifa1zahK9zqQ Date: Mon, 16 Mar 2020 09:34:43 +0000 Message-ID: <10e90cbc7bbe4d84979dabcb0fbe0c41@EX13D12EUA003.ant.amazon.com> References: <20200313091835.58039-1-gavin.hu@arm.com> In-Reply-To: <20200313091835.58039-1-gavin.hu@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.43.165.122] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailman-Approved-At: Mon, 16 Mar 2020 13:12:11 +0100 Subject: Re: [dpdk-dev] [PATCH RFC v1 0/7] relax barriers for ENA PMD and small fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Gavin, Thank you for the contribution. Please do not merge these changes (patches 0..7) till we (the ENA team) pro= perly review and ack/nack. These changes can potentially provide performance improvement, yet we need = to ensure they are applicable for all possible scenarios. Specifically, the= behavior on x86 platforms is likely to be different. What testing have you done for these patches? Was x86 tested? Thanks, Igor -----Original Message----- From: Gavin Hu =20 Sent: Friday, March 13, 2020 11:18 AM To: dev@dpdk.org Cc: nd@arm.com; david.marchand@redhat.com; thomas@monjalon.net; mk@semihalf= .com; Tzalik, Guy ; Schmeilin, Evgeny ; Chauskin, Igor ; mw@semihalf.com; Honnappa.Nagaraha= lli@arm.com; ruifeng.wang@arm.com; phil.yang@arm.com; joyce.kong@arm.com Subject: [EXTERNAL][PATCH RFC v1 0/7] relax barriers for ENA PMD and small = fixes CAUTION: This email originated from outside of the organization. Do not cli= ck links or open attachments unless you can confirm the sender and know the= content is safe. To ensure the stores to the host memory are observed by NIC HW before a doo= r bell ring to the NIC HW and the HW starts actions, for example, doing DMA= , a barrier is required on weak memory ordering platforms, like aarch64. However, unnecessarily too strong barriers like 'dsb' on aarch64 will dampe= n performance. In a typical doorbell use case, as NIC and CPU are in the outer sharable do= main, a lighter weight 'dmb osh' barrier is sufficient. The patch set relaxes the barriers in similar places and include one more p= atch for statistics logging with relaxed ordering and the other patch remov= ing duplicate memset. Note this set is submitted for RFC as we don't have physical ENA NICs in th= e lab and the patch set was not verified nor benchmarked. Gavin Hu (7): net/ena: remove duplicate barrier net/ena: relax the barrier for doorbell ring net/ena: relax the rmb for DMA net/ena: relax barrier for completion queue update net/ena: relax the barrier for bounce buffer net/ena: use c11 atomic for statistics net/ena: remove duplicate memset drivers/net/ena/base/ena_eth_com.c | 2 +- drivers/net/ena/base/ena_eth_com.h | 6 ++-- drivers/net/ena/base/ena_plat_dpdk.h | 2 +- drivers/net/ena/ena_ethdev.c | 46 +++++++++++++++++----------- drivers/net/ena/ena_ethdev.h | 8 ++--- 5 files changed, 38 insertions(+), 26 deletions(-) -- 2.17.1