From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 38D32A052A;
	Wed, 27 Jan 2021 13:50:26 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id D8628140D60;
	Wed, 27 Jan 2021 13:50:25 +0100 (CET)
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by mails.dpdk.org (Postfix) with ESMTP id 6D964140D43;
 Wed, 27 Jan 2021 13:50:23 +0100 (CET)
IronPort-SDR: Z7YNLKCSWc92LIWZqCTq9/+DF/+YYhjHNZev2FIdjHm/zn1UP5s9x2BDw1HUzhPn8kv84voLI9
 QhBCrf6w6s6g==
X-IronPort-AV: E=McAfee;i="6000,8403,9876"; a="241590633"
X-IronPort-AV: E=Sophos;i="5.79,379,1602572400"; d="scan'208";a="241590633"
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 27 Jan 2021 04:50:21 -0800
IronPort-SDR: KNZYHEvmMeBf5/pRANJ/JacOmptE2H4m0wicPBb/vCPl9aPdTzXMHojKlvWTR/nGTuIz8/F9h7
 OlQhA3Iz8O0w==
X-IronPort-AV: E=Sophos;i="5.79,379,1602572400"; d="scan'208";a="430089833"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.208.215])
 ([10.213.208.215])
 by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 27 Jan 2021 04:50:19 -0800
To: Jiawei Wang <jiaweiw@nvidia.com>, viacheslavo@nvidia.com,
 matan@nvidia.com, orika@nvidia.com, thomas@monjalon.net
Cc: dev@dpdk.org, rasland@nvidia.com, stable@dpdk.org,
 Kevin Traynor <ktraynor@redhat.com>, Luca Boccassi <bluca@debian.org>
References: <1611665613-123388-1-git-send-email-jiaweiw@nvidia.com>
 <1611665613-123388-3-git-send-email-jiaweiw@nvidia.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <11002ac2-1a6c-4be8-76ea-acdb25785e8a@intel.com>
Date: Wed, 27 Jan 2021 12:50:16 +0000
MIME-Version: 1.0
In-Reply-To: <1611665613-123388-3-git-send-email-jiaweiw@nvidia.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] net/mlx5: use global
 default miss for E-Switch sampling
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 1/26/2021 12:53 PM, Jiawei Wang wrote:
> In E-Switch steering domain there was dedicated default miss action
> created for every sampling flow.
> The patch replaces this one with the global default miss action.
> 

Hi Jiawei,

The impact of the patch is not clear, what was the problem using action per 
flow? What will change when global action is used? Is this fixing some problem 
or is it optimization by preventing per flow action?

> Cc: stable@dpdk.org
> 

Since this looks like optimization, I am removing the stable tag for now.

If it is a fix, please reply with a fixes line, I can update it in next-net.

> Signed-off-by: Jiawei Wang <jiaweiw@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>