From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43])
 by dpdk.org (Postfix) with ESMTP id 362097E7A
 for <dev@dpdk.org>; Tue, 21 Oct 2014 10:21:38 +0200 (CEST)
Received: by mail-wg0-f43.google.com with SMTP id m15so723605wgh.26
 for <dev@dpdk.org>; Tue, 21 Oct 2014 01:29:53 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=4kQY14DO89WtjTK3GSxU+jJpbroeYVJcSc1kZflFctk=;
 b=feJikl8C8j/WLV5HObXUFOciYwtYvziY79uz2kzRhWPwO8sL60cMdStg7uivzdoq7a
 mC0aBekM7DAtWm68wtZLzYIEKr8BQFlDtSzKXX2S2QrQGfImpyG72m6P6KQVf0H3/a7G
 QrmFf5BO7aJnSxe0Cj5eWxfEcl8rEoG4RIRrQnGc7tOqIiZMappdFUZcahQw3CXUSEYi
 /vbt3wepOtiynz1YGAEk4a/U8GxFM8M1W350J1hdlTb6H1tTD6ptRI9WRraa78K/bbvY
 uO3L+6m6z0srWdAszURpPxbYFgO+cBEACsg0dqX4ffKwEQuYg5XERgPqVSPr3rqxv+TV
 x2Bg==
X-Gm-Message-State: ALoCoQkzyFRTbBqqaS5Er8aG5xYgTXInZwF7O8ZZVNuYYLxog/E5nYvrF/Bpt0sIKFnnneOVAjx6
X-Received: by 10.194.3.2 with SMTP id 2mr40046460wjy.89.1413880193204;
 Tue, 21 Oct 2014 01:29:53 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id ce1sm14594469wjc.2.2014.10.21.01.29.51
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 21 Oct 2014 01:29:52 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Marc Sune <marc.sune@bisdn.de>
Date: Tue, 21 Oct 2014 10:29:36 +0200
Message-ID: <11046523.OQamTbecJT@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.1 (Linux/3.16.4-1-ARCH; KDE/4.14.1; x86_64; ; )
In-Reply-To: <1413586289-6694-1-git-send-email-marc.sune@bisdn.de>
References: <1413586289-6694-1-git-send-email-marc.sune@bisdn.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4] KNI: use a memzone pool for KNI
	alloc/release
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Oct 2014 08:21:38 -0000

Hi Marc,

2014-10-18 00:51, Marc Sune:
> This patch implements the KNI memzone pool in order to prevent
> memzone exhaustion when allocating/deallocating KNI interfaces.
> 
> It adds a new API call, rte_kni_init(max_kni_ifaces) that shall
> be called before any call to rte_kni_alloc() if KNI is used.
> 
> v2: Moved KNI fd opening to rte_kni_init(). Revised style.
> v3: Adapted kni examples/tests to rte_kni_init().
> v4: Improved example integration. Fixed kni_memzone_pool_alloc/release() bug.
> 
> Signed-off-by: Marc Sune <marc.sune@bisdn.de>

Thanks for the good work with Helin.
Before applying this patch, I'd like another version explaining in the
commit log why this change is needed.
And please use to checkpatch.pl to check and remove whitespace errors.

Thanks
-- 
Thomas