From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 14E762B96 for ; Wed, 7 Dec 2016 11:40:30 +0100 (CET) Received: by mail-wm0-f49.google.com with SMTP id c184so33661286wmd.0 for ; Wed, 07 Dec 2016 02:40:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=vDmMuff+Cw0ihwt76/7AO1URe5V+4/UCaqMcnjFlPy0=; b=nYRKECXS5lEalpaLnOxashJtRSQHGSI9gsFM4bM3uQ8hkGDsM1/ui3jUqb86bfUYIT ip+wAo9Eb/Izt13P/GaAaGyWuGx4BavEL/jfyXF290zyGwOYRaF7MxhMmtHEDt13hkhM +LS77nbRY9T51pYr62kGucf25ADtY72Vi9Gy1w4CfVyx3ijpjV00lJeifBpL9cdtS38+ EgPaU2CC84wfdJqAYg1LuVze0m9TQ1uI11qXqZ9/qhgXlbTesq0Gclt5NCUCUVJOkrzY XWPsYXPFS0g3SFahi+jPV2ZReEXO/fXVtpJUQZ9SyD5hUdd1MevE/PtITv/WrmB2my4h zh5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=vDmMuff+Cw0ihwt76/7AO1URe5V+4/UCaqMcnjFlPy0=; b=f19soKx2VIVRJzKC+MhRpnMD/FLcg75HfeqI4aWuwovs9KsAyJviXCJPeUeAK3rZQZ CJEj+HLzQKSLsfhjWr177iKTILly07yQhGn2OwgjFJqsfdK7vBLdy/QV8301mdQRkuo+ DNYumk/iA+Jx0UYMUmHWs17k21i4sMdtauho0kQebTOcMEPY73AjwtzwtotG2nl6dt+9 F0m47/isJHHi9ZjOM0d4lFcguSS7//UPI/QzvEeDb1cqHyABXbScoa1TA2bpO5Y7Bfn4 JyLgO3pK0cFzFFoGekyYI+JBQMringSZkSZM2oZhcjthl4JS0SSDpzS18mDQBIiUApuA U0Bg== X-Gm-Message-State: AKaTC02sNqBI0vDGqy2mPjRNMQgEA/ryxvZdWtIMlMoPPAVCxCvEvAhsqpjT/ztey4k9J4b6 X-Received: by 10.28.195.9 with SMTP id t9mr1838341wmf.92.1481107229773; Wed, 07 Dec 2016 02:40:29 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id ct7sm30724492wjc.2.2016.12.07.02.40.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Dec 2016 02:40:29 -0800 (PST) From: Thomas Monjalon To: Shreyansh Jain Cc: Hemant Agrawal , dev@dpdk.org, bruce.richardson@intel.com, david.marchand@6wind.com Date: Wed, 07 Dec 2016 11:40:28 +0100 Message-ID: <11053786.o6LJ0UWG8a@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <6b58f8fa-4df0-684e-f1d3-4dc4dba4f0dd@nxp.com> References: <1480875447-23680-1-git-send-email-hemant.agrawal@nxp.com> <1480875447-23680-11-git-send-email-hemant.agrawal@nxp.com> <6b58f8fa-4df0-684e-f1d3-4dc4dba4f0dd@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 10/32] net/dpaa2: introducing dpaa2 bus driver for fsl-mc bus X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Dec 2016 10:40:30 -0000 2016-12-07 15:43, Shreyansh Jain: > IMO, the way Bus is kept is debatable. > - should it be in EAL (lib/librte_eal/linuxapp/eal_pci.c like Bus > patches) [1]? > - Should it a 'handler/driver' parallel to device drivers? > > I personally prefer a clean layer for buses with: > > - RTE_SDK/drivers/net/dpaa2/ > - RTE_SDK/drivers/bus > - RTE_SDK/drivers/bus/dpaa2/ > - RTE_SDK/drivers/bus/dpaa2/dpaa2_bus.c etc. I agree, it is a good idea. > For PCI, which is generic (or for other similar generic buses, like > platform), we can keep the implementation within lib/librte_eal/linuxapp/*. I would be in favor of moving PCI and vdev code from EAL to drivers/bus/. We can keep the API in EAL and implement the buses as drivers. Other opinions?