From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 599A0A10 for ; Wed, 15 Mar 2017 18:18:50 +0100 (CET) Received: by mail-wm0-f49.google.com with SMTP id t189so28545212wmt.1 for ; Wed, 15 Mar 2017 10:18:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=9vMYqp7dfL8JoJHq1kAJOBYXaO+a9NcL1sH7COuoAQw=; b=TyoQuN17y3avRFuThyygKJ0WoXYAkQOo+nWQ27/yPMbeSsjk9/OvL5LrMY4Jbf98z3 1Z3CzLNRorVmil1P7/qtP4dr+EE8/MqbpfzDNDGaYiBV8amedJi0/+Mfg3/hcPCkuRoP C3oc8kOlJ5IyQo60wwaf9A4pdlrUDhXE7Tv4OcLo2OwzHtt7pgzN3DYeVoi0M0kHSKMj 2U3kdQeFtZU4gq3RK2bsteIKhPNBhh5kQQgfOwJNV9XUpBkPns2wOTVa1l6ON1UHCxqw iCn6SqiODWg737mI3DgqbGKQOV6+086N/Oev7EW/pjhRF3SDlMTeXMlLFWtJtTPGx9kE uoRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=9vMYqp7dfL8JoJHq1kAJOBYXaO+a9NcL1sH7COuoAQw=; b=gALFzGI0zBd9Uv5rrB1vp/IUIUMI4X5jx5UophxaKVnNg0o1Yvsw0+xsYxd+Z4XFAB j0HwYYoNxV1u2ju0wG1A8Qw6APLetSYen0Ux1fsXpXxKR5FYxN1D5fbohwdO63aslpfA ApFP2/7Wt9mR9eHggPKXKm0miafPnzg2hrPqJPL8wHNRnZ82VIeWFlvUo2aZ5iQ4WEbj 2Dh0QPIleb6qRSyb8trXe1VjjlilfYs9zbZEu/AB3sWrb1H/NjvBMS9rb1WPTqzcNsKR wP1zQBJh/Mt+9ZbEyQidpsBRQQfLAPHvy4XJ4KL2QfcsP70dk/H6xIAwvfDCFClLDE9c Ckww== X-Gm-Message-State: AFeK/H3T3y9rHZCZDOaAux8fJM+XnBPmZTKrSIPi1QjHFvHJG+1bz6/hfxLB4UuKVDcrDlkd X-Received: by 10.28.29.88 with SMTP id d85mr5231524wmd.56.1489598330054; Wed, 15 Mar 2017 10:18:50 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id 35sm2712735wrn.29.2017.03.15.10.18.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Mar 2017 10:18:49 -0700 (PDT) From: Thomas Monjalon To: David Hunt Cc: dev@dpdk.org, bruce.richardson@intel.com, nelio.laranjeiro@6wind.com Date: Wed, 15 Mar 2017 18:18:48 +0100 Message-ID: <11064293.gTtyHWn9o3@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1489558767-56329-3-git-send-email-david.hunt@intel.com> References: <1488791433-186137-2-git-send-email-david.hunt@intel.com> <1489558767-56329-1-git-send-email-david.hunt@intel.com> <1489558767-56329-3-git-send-email-david.hunt@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v10 02/18] lib: create private header file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Mar 2017 17:18:50 -0000 2017-03-15 06:19, David Hunt: > +/** > + * Number of packets to deal with in bursts. Needs to be 8 so as to > + * fit in one cache line. > + */ > +#define RTE_DIST_BURST_SIZE (sizeof(rte_xmm_t) / sizeof(uint16_t)) error: 'rte_xmm_t' undeclared here (arm compilation) Can it be fixed by including rte_vect.h? Ideally I would prefer we stop using XMM types in a generic code. XMM are x86-only registers. It has been translated for other arches but we should use a more generic name. What was the intention here? SSE-optimized code or 128-bit size? Please check lib/librte_eal/common/include/generic/rte_vect.h for a generic type.