From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 18ED22B99 for ; Tue, 2 Apr 2019 01:22:10 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 61F7721FE1; Mon, 1 Apr 2019 19:22:09 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 01 Apr 2019 19:22:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=cIBpU8BPBKzHqrJKZm7X1zitLbG6dAVhugC0HNF5zV0=; b=Zac/UQ7lICoj E0dybUnzWShJGXJ2sMN8Ua57MYfsap42pSP1Zv0KZ76JtUeDa87knpUeWOPH+Q29 R3axgoSiiX8g1NV+1O3ysOjxDoDJCJVunfTSkldbnqAYNjT7Ap5qoXvHUwI/Vdrh ZmjjXz+sfB2629zbtycW3qJc0KRcygU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=cIBpU8BPBKzHqrJKZm7X1zitLbG6dAVhugC0HNF5z V0=; b=voNYsHnd2ZViF6goxt/jzSFRCAA7gvw5bJ7zInxI8I5qaJvKPtEiMp2LT ydA5dhsh/P/bsLGI4KkxvEg+s8/8JqrLyQFHPyFBg1s6KeLQ5ScFtm5v/2kRZUeZ C3DFPfVlcTCwD9ht/m5dVqDIjQrfT4g37nn8iwmSsgH44LR9nh8833oFJOZPKJ0+ MNW0S6pkGlPmGxcq+cbQZ+NlpuUWOVVKRsLv/Phy0Ftk4UB9n4N17EC8e6lX58ND 1bqz/DVhv+qFsExGcWj7wyF4DZLn5zSe5ei67AekQ5+3wuq4IBAiDgCE4TtDZE5j XEPybXWJ7oGvocmGo1R+QdSK0RUVg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrleehgddvtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinheplhhlvhhmrdhorhhgpdhmihgtrhhoshhofhhtrdgtohhmnecukfhppeejjedr udefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghsse hmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id AFEFC10390; Mon, 1 Apr 2019 19:22:07 -0400 (EDT) From: Thomas Monjalon To: Anand Rawat Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com, jeffrey.b.shaw@intel.com, bruce.richardson@intel.com, harini.ramakrishnan@microsoft.com Date: Tue, 02 Apr 2019 01:22:06 +0200 Message-ID: <111013680.KhI2ai8QQM@xps> In-Reply-To: <20190328232451.16988-8-anand.rawat@intel.com> References: <20190306041634.12976-1-anand.rawat@intel.com> <20190328232451.16988-1-anand.rawat@intel.com> <20190328232451.16988-8-anand.rawat@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v7 7/8] doc: add documentation for windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Apr 2019 23:22:10 -0000 29/03/2019 00:24, Anand Rawat: > Added documentation to build helloworld example > on windows using meson and clang. Updated the > maintainers list to include windows maintainers. [...] > --- a/MAINTAINERS > +++ b/MAINTAINERS > +Windows support > +M: Harini Ramakrishnan > +M: Omar Cardona > +M: Anand Rawat > +M: Ranjit Menon > +F: lib/librte_eal/windows/ This change should be in the first patch (when introducing eal/windows). In this doc patch, you should add F: doc/guides/windows_gsg/ [...] > +The DPDK and its applications require the Clang-LLVM* C compiler and MSVC* linker. > +The Meson* Build system is used to prepare the sources for compilation with the Ninja backend. > + > +\*Other names and brands may be claimed as the property of others. This sentence looks weird. What does it mean? [...] > +Download and install the clang compiler from `LLVM* website `_. Why is there an asterisk after LLVM? [...] > +Download and install the Build Tools for Visual Studio to link and build the files on windows, from `Microsoft* website `_. > +When installing build tools, select the "Visual C++ build tools" option and ensure the Windows SDK is selected. Please try to limit the line length. We are supposed to not exceed 80-chars if possible. The best is to wrap lines logically (as in code) after a comma or a point, etc. [...] > + cd C:\Users\me\dpdk\build > + helloworld.exe > + hello from core 1 > + hello from core 3 > + hello from core 0 > + hello from core 2 That's definitely a good goal for release 19.05! > +Limitations > +=========== > + > +DPDK for Windows is currently a work in progress. Not all DPDK source files > +compile. Support is being added in pieces so as to limit the overall scope > +of any individual patch series. The goal is to be able to run any DPDK > +application natively on Windows. Yes From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 02E21A0679 for ; Tue, 2 Apr 2019 01:22:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 30D0037A8; Tue, 2 Apr 2019 01:22:12 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 18ED22B99 for ; Tue, 2 Apr 2019 01:22:10 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 61F7721FE1; Mon, 1 Apr 2019 19:22:09 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 01 Apr 2019 19:22:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=cIBpU8BPBKzHqrJKZm7X1zitLbG6dAVhugC0HNF5zV0=; b=Zac/UQ7lICoj E0dybUnzWShJGXJ2sMN8Ua57MYfsap42pSP1Zv0KZ76JtUeDa87knpUeWOPH+Q29 R3axgoSiiX8g1NV+1O3ysOjxDoDJCJVunfTSkldbnqAYNjT7Ap5qoXvHUwI/Vdrh ZmjjXz+sfB2629zbtycW3qJc0KRcygU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=cIBpU8BPBKzHqrJKZm7X1zitLbG6dAVhugC0HNF5z V0=; b=voNYsHnd2ZViF6goxt/jzSFRCAA7gvw5bJ7zInxI8I5qaJvKPtEiMp2LT ydA5dhsh/P/bsLGI4KkxvEg+s8/8JqrLyQFHPyFBg1s6KeLQ5ScFtm5v/2kRZUeZ C3DFPfVlcTCwD9ht/m5dVqDIjQrfT4g37nn8iwmSsgH44LR9nh8833oFJOZPKJ0+ MNW0S6pkGlPmGxcq+cbQZ+NlpuUWOVVKRsLv/Phy0Ftk4UB9n4N17EC8e6lX58ND 1bqz/DVhv+qFsExGcWj7wyF4DZLn5zSe5ei67AekQ5+3wuq4IBAiDgCE4TtDZE5j XEPybXWJ7oGvocmGo1R+QdSK0RUVg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrleehgddvtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinheplhhlvhhmrdhorhhgpdhmihgtrhhoshhofhhtrdgtohhmnecukfhppeejjedr udefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghsse hmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id AFEFC10390; Mon, 1 Apr 2019 19:22:07 -0400 (EDT) From: Thomas Monjalon To: Anand Rawat Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com, jeffrey.b.shaw@intel.com, bruce.richardson@intel.com, harini.ramakrishnan@microsoft.com Date: Tue, 02 Apr 2019 01:22:06 +0200 Message-ID: <111013680.KhI2ai8QQM@xps> In-Reply-To: <20190328232451.16988-8-anand.rawat@intel.com> References: <20190306041634.12976-1-anand.rawat@intel.com> <20190328232451.16988-1-anand.rawat@intel.com> <20190328232451.16988-8-anand.rawat@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v7 7/8] doc: add documentation for windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190401232206.JC4vnjLrRmBjhT9kkU_fjv2WaH7gjDl025qqljRI_2k@z> 29/03/2019 00:24, Anand Rawat: > Added documentation to build helloworld example > on windows using meson and clang. Updated the > maintainers list to include windows maintainers. [...] > --- a/MAINTAINERS > +++ b/MAINTAINERS > +Windows support > +M: Harini Ramakrishnan > +M: Omar Cardona > +M: Anand Rawat > +M: Ranjit Menon > +F: lib/librte_eal/windows/ This change should be in the first patch (when introducing eal/windows). In this doc patch, you should add F: doc/guides/windows_gsg/ [...] > +The DPDK and its applications require the Clang-LLVM* C compiler and MSVC* linker. > +The Meson* Build system is used to prepare the sources for compilation with the Ninja backend. > + > +\*Other names and brands may be claimed as the property of others. This sentence looks weird. What does it mean? [...] > +Download and install the clang compiler from `LLVM* website `_. Why is there an asterisk after LLVM? [...] > +Download and install the Build Tools for Visual Studio to link and build the files on windows, from `Microsoft* website `_. > +When installing build tools, select the "Visual C++ build tools" option and ensure the Windows SDK is selected. Please try to limit the line length. We are supposed to not exceed 80-chars if possible. The best is to wrap lines logically (as in code) after a comma or a point, etc. [...] > + cd C:\Users\me\dpdk\build > + helloworld.exe > + hello from core 1 > + hello from core 3 > + hello from core 0 > + hello from core 2 That's definitely a good goal for release 19.05! > +Limitations > +=========== > + > +DPDK for Windows is currently a work in progress. Not all DPDK source files > +compile. Support is being added in pieces so as to limit the overall scope > +of any individual patch series. The goal is to be able to run any DPDK > +application natively on Windows. Yes