From: Thomas Monjalon <thomas@monjalon.net>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: dev@dpdk.org, Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] mempool: remove deprecated functions
Date: Fri, 27 Jul 2018 16:38:56 +0200 [thread overview]
Message-ID: <11107367.P76Ua8LdDk@xps> (raw)
In-Reply-To: <217aa1df-7b7e-bad0-2db5-928349b018cc@solarflare.com>
27/07/2018 15:45, Andrew Rybchenko:
> On 27.07.2018 00:34, Thomas Monjalon wrote:
> > 11/07/2018 12:59, Andrew Rybchenko:
> >> Functions rte_mempool_populate_phys(), rte_mempool_virt2phy() and
> >> rte_mempool_populate_phys_tab() are just wrappers for corresponding
> >> IOVA functions and were deprecated in v17.11.
> >>
> >> Functions rte_mempool_xmem_create(), rte_mempool_xmem_size(),
> >> rte_mempool_xmem_usage() and rte_mempool_populate_iova_tab() were
> >> deprecated in v18.05 and removal was announced earlier in v18.02.
> >>
> >> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> >> ---
> >> lib/librte_mempool/Makefile | 3 -
> >> lib/librte_mempool/meson.build | 4 -
> >> lib/librte_mempool/rte_mempool.c | 181 +--------------------
> >> lib/librte_mempool/rte_mempool.h | 179 --------------------
> >> lib/librte_mempool/rte_mempool_version.map | 6 -
> >> 5 files changed, 1 insertion(+), 372 deletions(-)
> > Please update the release notes, deprecation notice, and bump ABI version.
>
> Will do. Deprecation notice which schedules removal of xmem functions
> was removed on previous release when these function are deprecated.
> Is it a problem? Should removal of already deprecated function pass
> deprecation (removal) announcement procedure once again?
No, it's OK.
We should have left the notice about removal but it's too late :)
prev parent reply other threads:[~2018-07-27 14:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 10:59 Andrew Rybchenko
2018-07-11 10:59 ` [dpdk-dev] [PATCH 2/2] mempool: fold memory size calculation helper Andrew Rybchenko
2018-07-26 21:34 ` [dpdk-dev] [PATCH 1/2] mempool: remove deprecated functions Thomas Monjalon
2018-07-27 13:45 ` Andrew Rybchenko
2018-07-27 14:38 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11107367.P76Ua8LdDk@xps \
--to=thomas@monjalon.net \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).