From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id A0FB45592 for ; Fri, 27 Jul 2018 16:39:01 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 37D5821FC3; Fri, 27 Jul 2018 10:39:01 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 27 Jul 2018 10:39:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=/qBtVe6p9dXN7PQ7XhptO6tjV3 Mo4732pAajDlWoF5Y=; b=i80nvpQLbBzts6snVkUkucO+S/uhB8dZQunpE1Wywk Ur/2vCe4mRvy8DF7/WKnyrn2PgZI9MdmIqigOIXKimx1Hjf1kz8lUrVAVPt2hi1q seWEjQIAEK4GImrtSF5JYISBedzkYwgv0APwg3PxMdgZt+RTf+sa2s8DGXQUO6/i I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=/qBtVe 6p9dXN7PQ7XhptO6tjV3Mo4732pAajDlWoF5Y=; b=cv8m7+DtyuUxWJbTunlLcO x1OM3Mq1S72YNh/TAy4lsD6S34i9dwOYnXwT2+/4pZAF3p+QG4xiO7kogZLCVzfK K+M8eD6TrukFfDKadNSzzR/ZxuMrHmuq+q0atevXU4qymI1/QcvofsD0O9uGgijg /xM96J5x68cMBMudd0xVdeDBYJmWm79jpVmQWYm21FAJDJQBr3Xu+zeEplysgYbo suVbQykTaqCB7/Y1DhPxrQkGV4eNF28C2iJp0jH0X3zfOLrsG4BWCR4WllufEmMf 3G2j7c1KdxjnG7iSX3AxaSzgrxMCFVzcAK1KgZjWN9Mhr2Mj5ZjhQjo77l06nVbQ == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 663841025C; Fri, 27 Jul 2018 10:39:00 -0400 (EDT) From: Thomas Monjalon To: Andrew Rybchenko Cc: dev@dpdk.org, Olivier Matz Date: Fri, 27 Jul 2018 16:38:56 +0200 Message-ID: <11107367.P76Ua8LdDk@xps> In-Reply-To: <217aa1df-7b7e-bad0-2db5-928349b018cc@solarflare.com> References: <1531306750-9844-1-git-send-email-arybchenko@solarflare.com> <5677276.1WdofzzUsl@xps> <217aa1df-7b7e-bad0-2db5-928349b018cc@solarflare.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/2] mempool: remove deprecated functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jul 2018 14:39:02 -0000 27/07/2018 15:45, Andrew Rybchenko: > On 27.07.2018 00:34, Thomas Monjalon wrote: > > 11/07/2018 12:59, Andrew Rybchenko: > >> Functions rte_mempool_populate_phys(), rte_mempool_virt2phy() and > >> rte_mempool_populate_phys_tab() are just wrappers for corresponding > >> IOVA functions and were deprecated in v17.11. > >> > >> Functions rte_mempool_xmem_create(), rte_mempool_xmem_size(), > >> rte_mempool_xmem_usage() and rte_mempool_populate_iova_tab() were > >> deprecated in v18.05 and removal was announced earlier in v18.02. > >> > >> Signed-off-by: Andrew Rybchenko > >> --- > >> lib/librte_mempool/Makefile | 3 - > >> lib/librte_mempool/meson.build | 4 - > >> lib/librte_mempool/rte_mempool.c | 181 +-------------------- > >> lib/librte_mempool/rte_mempool.h | 179 -------------------- > >> lib/librte_mempool/rte_mempool_version.map | 6 - > >> 5 files changed, 1 insertion(+), 372 deletions(-) > > Please update the release notes, deprecation notice, and bump ABI version. > > Will do. Deprecation notice which schedules removal of xmem functions > was removed on previous release when these function are deprecated. > Is it a problem? Should removal of already deprecated function pass > deprecation (removal) announcement procedure once again? No, it's OK. We should have left the notice about removal but it's too late :)