DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: "Xia, Chenbo" <chenbo.xia@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"olivier.matz@6wind.com" <olivier.matz@6wind.com>,
	"amorenoz@redhat.com" <amorenoz@redhat.com>,
	"david.marchand@redhat.com" <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH 33/40] net/virtio: improve Virtio-user errors handling
Date: Fri, 15 Jan 2021 12:09:09 +0100
Message-ID: <111273ff-71a8-0aab-98b0-9d83d419222d@redhat.com> (raw)
In-Reply-To: <MN2PR11MB4063881EFD8C6A52861F95C69CAF0@MN2PR11MB4063.namprd11.prod.outlook.com>



On 1/7/21 3:26 AM, Xia, Chenbo wrote:
> Hi Maxime,
> 
>> -----Original Message-----
>> From: Maxime Coquelin <maxime.coquelin@redhat.com>
>> Sent: Monday, December 21, 2020 5:14 AM
>> To: dev@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>; olivier.matz@6wind.com;
>> amorenoz@redhat.com; david.marchand@redhat.com
>> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
>> Subject: [PATCH 33/40] net/virtio: improve Virtio-user errors handling
>>
>> This patch adds error logs and propagate errors reported
> 
> s/propagate/propagates

Fixed.

>> by the backend. It also adds the device path in error logs
>> to make it easier to distinguish which device is facing the
>> issue.
>>
>> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>> ---
>>  .../net/virtio/virtio_user/virtio_user_dev.c  | 155 ++++++++++++------
>>  1 file changed, 104 insertions(+), 51 deletions(-)
>>
>> diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c
>> b/drivers/net/virtio/virtio_user/virtio_user_dev.c
>> index e1f016aa8c..b92b7f7aae 100644
>> --- a/drivers/net/virtio/virtio_user/virtio_user_dev.c
>> +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c
>> @@ -37,10 +37,15 @@ virtio_user_create_queue(struct virtio_user_dev *dev,
>> uint32_t queue_sel)
>>  	 * pair.
>>  	 */
>>  	struct vhost_vring_file file;
>> +	int ret;
>>
>>  	file.index = queue_sel;
>>  	file.fd = dev->callfds[queue_sel];
>> -	dev->ops->set_vring_call(dev, &file);
>> +	ret = dev->ops->set_vring_call(dev, &file);
>> +	if (ret < 0) {
>> +		PMD_INIT_LOG(ERR, "(%s) Failed to create queue %u\n", dev->path,
>> queue_sel);
>> +		return -1;
>> +	}
>>
>>  	return 0;
>>  }
>> @@ -48,6 +53,7 @@ virtio_user_create_queue(struct virtio_user_dev *dev,
>> uint32_t queue_sel)
>>  static int
>>  virtio_user_kick_queue(struct virtio_user_dev *dev, uint32_t queue_sel)
>>  {
>> +	int ret;
>>  	struct vhost_vring_file file;
>>  	struct vhost_vring_state state;
>>  	struct vring *vring = &dev->vrings[queue_sel];
>> @@ -73,15 +79,21 @@ virtio_user_kick_queue(struct virtio_user_dev *dev,
>> uint32_t queue_sel)
>>
>>  	state.index = queue_sel;
>>  	state.num = vring->num;
>> -	dev->ops->set_vring_num(dev, &state);
>> +	ret = dev->ops->set_vring_num(dev, &state);
>> +	if (ret < 0)
>> +		goto err;
>>
>>  	state.index = queue_sel;
>>  	state.num = 0; /* no reservation */
>>  	if (dev->features & (1ULL << VIRTIO_F_RING_PACKED))
>>  		state.num |= (1 << 15);
>> -	dev->ops->set_vring_base(dev, &state);
>> +	ret = dev->ops->set_vring_base(dev, &state);
>> +	if (ret < 0)
>> +		goto err;
>>
>> -	dev->ops->set_vring_addr(dev, &addr);
>> +	ret = dev->ops->set_vring_addr(dev, &addr);
>> +	if (ret < 0)
>> +		goto err;
>>
>>  	/* Of all per virtqueue MSGs, make sure VHOST_USER_SET_VRING_KICK comes
>>  	 * lastly because vhost depends on this msg to judge if
>> @@ -89,9 +101,15 @@ virtio_user_kick_queue(struct virtio_user_dev *dev,
>> uint32_t queue_sel)
>>  	 */
>>  	file.index = queue_sel;
>>  	file.fd = dev->kickfds[queue_sel];
>> -	dev->ops->set_vring_kick(dev, &file);
>> +	ret = dev->ops->set_vring_kick(dev, &file);
>> +	if (ret < 0)
>> +		goto err;
>>
>>  	return 0;
>> +err:
>> +	PMD_INIT_LOG(ERR, "(%s) Failed to kick queue %u\n", dev->path,
>> queue_sel);
>> +
>> +	return -1;
>>  }
>>
>>  static int
>> @@ -103,14 +121,14 @@ virtio_user_queue_setup(struct virtio_user_dev *dev,
>>  	for (i = 0; i < dev->max_queue_pairs; ++i) {
>>  		queue_sel = 2 * i + VTNET_SQ_RQ_QUEUE_IDX;
>>  		if (fn(dev, queue_sel) < 0) {
>> -			PMD_DRV_LOG(INFO, "setup rx vq fails: %u", i);
>> +			PMD_DRV_LOG(ERR, "(%s) setup rx vq fails: %u", dev->path, i);
> 
> Maybe 'setup rx vq %u fails' is better?
> 
>>  			return -1;
>>  		}
>>  	}
>>  	for (i = 0; i < dev->max_queue_pairs; ++i) {
>>  		queue_sel = 2 * i + VTNET_SQ_TQ_QUEUE_IDX;
>>  		if (fn(dev, queue_sel) < 0) {
>> -			PMD_DRV_LOG(INFO, "setup tx vq fails: %u", i);
>> +			PMD_DRV_LOG(INFO, "(%s) setup tx vq fails: %u", dev->path,
>> i);
> 
> Maybe 'setup tx vq %u fails' is better?

Fixes both to "setup tx vq %u failed".

>>  			return -1;
>>  		}
>>  	}
>> @@ -144,7 +162,7 @@ virtio_user_dev_set_features(struct virtio_user_dev *dev)
>>  	ret = dev->ops->set_features(dev, features);
>>  	if (ret < 0)
>>  		goto error;
>> -	PMD_DRV_LOG(INFO, "set features: %" PRIx64, features);
>> +	PMD_DRV_LOG(INFO, "(%s) set features: %" PRIx64, dev->path, features);
> 
> Add '0x' before '%" PRIx64'?
> 
>>  error:
>>  	pthread_mutex_unlock(&dev->mutex);
>>
>> @@ -172,9 +190,10 @@ virtio_user_start_device(struct virtio_user_dev *dev)
>>  	rte_mcfg_mem_read_lock();
>>  	pthread_mutex_lock(&dev->mutex);
>>
>> +	/* Vhost-user client not connected yet, will start later */
>>  	if (dev->backend_type == VIRTIO_USER_BACKEND_VHOST_USER &&
>>  			dev->vhostfd < 0)
>> -		goto error;
>> +		goto out;
>>
>>  	/* Step 2: share memory regions */
>>  	ret = dev->ops->set_memory_table(dev);
>> @@ -182,15 +201,19 @@ virtio_user_start_device(struct virtio_user_dev *dev)
>>  		goto error;
>>
>>  	/* Step 3: kick queues */
>> -	if (virtio_user_queue_setup(dev, virtio_user_kick_queue) < 0)
>> +	ret = virtio_user_queue_setup(dev, virtio_user_kick_queue);
>> +	if (ret < 0)
>>  		goto error;
>>
>>  	/* Step 4: enable queues
>>  	 * we enable the 1st queue pair by default.
>>  	 */
>> -	dev->ops->enable_qp(dev, 0, 1);
>> +	ret = dev->ops->enable_qp(dev, 0, 1);
>> +	if (ret < 0)
>> +		goto error;
>>
>>  	dev->started = true;
>> +out:
>>  	pthread_mutex_unlock(&dev->mutex);
>>  	rte_mcfg_mem_read_unlock();
>>
>> @@ -198,6 +221,9 @@ virtio_user_start_device(struct virtio_user_dev *dev)
>>  error:
>>  	pthread_mutex_unlock(&dev->mutex);
>>  	rte_mcfg_mem_read_unlock();
>> +
>> +	PMD_INIT_LOG(ERR, "(%s) Failed to start device\n", dev->path);
>> +
>>  	/* TODO: free resource here or caller to check */
>>  	return -1;
>>  }
>> @@ -206,31 +232,40 @@ int virtio_user_stop_device(struct virtio_user_dev *dev)
>>  {
>>  	struct vhost_vring_state state;
>>  	uint32_t i;
>> -	int error = 0;
>> +	int ret;
>>
>>  	pthread_mutex_lock(&dev->mutex);
>>  	if (!dev->started)
>>  		goto out;
>>
>> -	for (i = 0; i < dev->max_queue_pairs; ++i)
>> -		dev->ops->enable_qp(dev, i, 0);
>> +	for (i = 0; i < dev->max_queue_pairs; ++i) {
>> +		ret = dev->ops->enable_qp(dev, i, 0);
>> +		if (ret < 0)
>> +			goto err;
>> +	}
>>
>>  	/* Stop the backend. */
>>  	for (i = 0; i < dev->max_queue_pairs * 2; ++i) {
>>  		state.index = i;
>> -		if (dev->ops->get_vring_base(dev, &state) < 0) {
>> -			PMD_DRV_LOG(ERR, "get_vring_base failed, index=%u",
>> -				    i);
>> -			error = -1;
>> -			goto out;
>> +		ret = dev->ops->get_vring_base(dev, &state);
>> +		if (ret < 0) {
>> +			PMD_DRV_LOG(ERR, "(%s) get_vring_base failed, index=%u",
>> dev->path, i);
>> +			goto err;
>>  		}
>>  	}
>>
>>  	dev->started = false;
>> +
>>  out:
>>  	pthread_mutex_unlock(&dev->mutex);
>>
>> -	return error;
>> +	return 0;
>> +err:
>> +	pthread_mutex_unlock(&dev->mutex);
>> +
>> +	PMD_INIT_LOG(ERR, "(%s) Failed to stop device\n", dev->path);
>> +
>> +	return -1;
>>  }
>>
>>  static inline void
>> @@ -270,12 +305,12 @@ virtio_user_dev_init_notify(struct virtio_user_dev *dev)
>>  		 */
>>  		callfd = eventfd(0, EFD_CLOEXEC | EFD_NONBLOCK);
>>  		if (callfd < 0) {
>> -			PMD_DRV_LOG(ERR, "callfd error, %s", strerror(errno));
>> +			PMD_DRV_LOG(ERR, "(%s) callfd error, %s", dev->path,
>> strerror(errno));
>>  			break;
>>  		}
>>  		kickfd = eventfd(0, EFD_CLOEXEC | EFD_NONBLOCK);
>>  		if (kickfd < 0) {
>> -			PMD_DRV_LOG(ERR, "kickfd error, %s", strerror(errno));
>> +			PMD_DRV_LOG(ERR, "(%s) kickfd error, %s", dev->path,
>> strerror(errno));
>>  			break;
>>  		}
>>  		dev->callfds[i] = callfd;
>> @@ -303,7 +338,7 @@ virtio_user_fill_intr_handle(struct virtio_user_dev *dev)
>>  	if (!eth_dev->intr_handle) {
>>  		eth_dev->intr_handle = malloc(sizeof(*eth_dev->intr_handle));
>>  		if (!eth_dev->intr_handle) {
>> -			PMD_DRV_LOG(ERR, "fail to allocate intr_handle");
>> +			PMD_DRV_LOG(ERR, "(%s) fail to allocate intr_handle", dev-
>>> path);
> 
> s/fail/failed ?

Indeed.

Thanks,
Maxime
> Thanks,
> Chenbo
> 
>>  			return -1;
>>  		}
>>  		memset(eth_dev->intr_handle, 0, sizeof(*eth_dev->intr_handle));
>> @@ -334,6 +369,7 @@ virtio_user_mem_event_cb(enum rte_mem_event type
>> __rte_unused,
>>  	struct virtio_user_dev *dev = arg;
>>  	struct rte_memseg_list *msl;
>>  	uint16_t i;
>> +	int ret = 0;
>>
>>  	/* ignore externally allocated memory */
>>  	msl = rte_mem_virt2memseg_list(addr);
>> @@ -346,18 +382,29 @@ virtio_user_mem_event_cb(enum rte_mem_event type
>> __rte_unused,
>>  		goto exit;
>>
>>  	/* Step 1: pause the active queues */
>> -	for (i = 0; i < dev->queue_pairs; i++)
>> -		dev->ops->enable_qp(dev, i, 0);
>> +	for (i = 0; i < dev->queue_pairs; i++) {
>> +		ret = dev->ops->enable_qp(dev, i, 0);
>> +		if (ret < 0)
>> +			goto exit;
>> +	}
>>
>>  	/* Step 2: update memory regions */
>> -	dev->ops->set_memory_table(dev);
>> +	ret = dev->ops->set_memory_table(dev);
>> +	if (ret < 0)
>> +		goto exit;
>>
>>  	/* Step 3: resume the active queues */
>> -	for (i = 0; i < dev->queue_pairs; i++)
>> -		dev->ops->enable_qp(dev, i, 1);
>> +	for (i = 0; i < dev->queue_pairs; i++) {
>> +		ret = dev->ops->enable_qp(dev, i, 1);
>> +		if (ret < 0)
>> +			goto exit;
>> +	}
>>
>>  exit:
>>  	pthread_mutex_unlock(&dev->mutex);
>> +
>> +	if (ret < 0)
>> +		PMD_DRV_LOG(ERR, "(%s) Failed to update memory table\n", dev-
>>> path);
>>  }
>>
>>  static int
>> @@ -387,7 +434,7 @@ virtio_user_dev_setup(struct virtio_user_dev *dev)
>>  			dev->tapfds = malloc(dev->max_queue_pairs *
>>  					     sizeof(int));
>>  			if (!dev->vhostfds || !dev->tapfds) {
>> -				PMD_INIT_LOG(ERR, "Failed to malloc");
>> +				PMD_INIT_LOG(ERR, "(%s) Failed to allocate FDs", dev-
>>> path);
>>  				return -1;
>>  			}
>>
>> @@ -399,19 +446,25 @@ virtio_user_dev_setup(struct virtio_user_dev *dev)
>>  				VIRTIO_USER_BACKEND_VHOST_VDPA) {
>>  			dev->ops = &virtio_ops_vdpa;
>>  		} else {
>> -			PMD_DRV_LOG(ERR, "Unknown backend type");
>> +			PMD_DRV_LOG(ERR, "(%s) Unknown backend type", dev->path);
>>  			return -1;
>>  		}
>>  	}
>>
>> -	if (dev->ops->setup(dev) < 0)
>> +	if (dev->ops->setup(dev) < 0) {
>> +		PMD_INIT_LOG(ERR, "(%s) Failed to setup backend\n", dev->path);
>>  		return -1;
>> +	}
>>
>> -	if (virtio_user_dev_init_notify(dev) < 0)
>> +	if (virtio_user_dev_init_notify(dev) < 0) {
>> +		PMD_INIT_LOG(ERR, "(%s) Failed to init notifiers\n", dev->path);
>>  		return -1;
>> +	}
>>
>> -	if (virtio_user_fill_intr_handle(dev) < 0)
>> +	if (virtio_user_fill_intr_handle(dev) < 0) {
>> +		PMD_INIT_LOG(ERR, "(%s) Failed to init interrupt handler\n", dev-
>>> path);
>>  		return -1;
>> +	}
>>
>>  	return 0;
>>  }
>> @@ -472,7 +525,7 @@ virtio_user_dev_init(struct virtio_user_dev *dev, char
>> *path, int queues,
>>  	}
>>
>>  	if (virtio_user_dev_setup(dev) < 0) {
>> -		PMD_INIT_LOG(ERR, "backend set up fails");
>> +		PMD_INIT_LOG(ERR, "(%s) backend set up fails", dev->path);
>>  		return -1;
>>  	}
>>
>> @@ -482,26 +535,29 @@ virtio_user_dev_init(struct virtio_user_dev *dev, char
>> *path, int queues,
>>
>>  	if (!dev->is_server) {
>>  		if (dev->ops->set_owner(dev) < 0) {
>> -			PMD_INIT_LOG(ERR, "set_owner fails: %s",
>> -				     strerror(errno));
>> +			PMD_INIT_LOG(ERR, "(%s) Failed to set backend owner", dev-
>>> path);
>>  			return -1;
>>  		}
>>
>>  		if (dev->ops->get_features(dev, &dev->device_features) < 0) {
>> -			PMD_INIT_LOG(ERR, "get_features failed: %s",
>> -				     strerror(errno));
>> +			PMD_INIT_LOG(ERR, "(%s) Failed to get backend features",
>> dev->path);
>>  			return -1;
>>  		}
>>
>> -
>>  		if (dev->device_features & (1ULL <<
>> VHOST_USER_F_PROTOCOL_FEATURES)) {
>> -			if (dev->ops->get_protocol_features(dev, &protocol_features))
>> +			if (dev->ops->get_protocol_features(dev, &protocol_features))
>> {
>> +				PMD_INIT_LOG(ERR, "(%s) Failed to get backend protocol
>> features",
>> +						dev->path);
>>  				return -1;
>> +			}
>>
>>  			dev->protocol_features &= protocol_features;
>>
>> -			if (dev->ops->set_protocol_features(dev, dev-
>>> protocol_features))
>> +			if (dev->ops->set_protocol_features(dev, dev-
>>> protocol_features)) {
>> +				PMD_INIT_LOG(ERR, "(%s) Failed to set backend protocol
>> features",
>> +						dev->path);
>>  				return -1;
>> +			}
>>
>>  			if (!(dev->protocol_features & (1ULL <<
>> VHOST_USER_PROTOCOL_F_MQ)))
>>  				dev->unsupported_features |= (1ull << VIRTIO_NET_F_MQ);
>> @@ -568,8 +624,8 @@ virtio_user_dev_init(struct virtio_user_dev *dev, char
>> *path, int queues,
>>  	if (rte_mem_event_callback_register(VIRTIO_USER_MEM_EVENT_CLB_NAME,
>>  				virtio_user_mem_event_cb, dev)) {
>>  		if (rte_errno != ENOTSUP) {
>> -			PMD_INIT_LOG(ERR, "Failed to register mem event"
>> -					" callback\n");
>> +			PMD_INIT_LOG(ERR, "(%s) Failed to register mem event
>> callback\n",
>> +					dev->path);
>>  			return -1;
>>  		}
>>  	}
>> @@ -622,8 +678,8 @@ virtio_user_handle_mq(struct virtio_user_dev *dev,
>> uint16_t q_pairs)
>>  	uint8_t ret = 0;
>>
>>  	if (q_pairs > dev->max_queue_pairs) {
>> -		PMD_INIT_LOG(ERR, "multi-q config %u, but only %u supported",
>> -			     q_pairs, dev->max_queue_pairs);
>> +		PMD_INIT_LOG(ERR, "(%s) multi-q config %u, but only %u supported",
>> +			     dev->path, q_pairs, dev->max_queue_pairs);
>>  		return -1;
>>  	}
>>
>> @@ -809,10 +865,8 @@ virtio_user_dev_set_status(struct virtio_user_dev *dev,
>> uint8_t status)
>>  	pthread_mutex_lock(&dev->mutex);
>>  	dev->status = status;
>>  	ret = dev->ops->set_status(dev, status);
>> -	if (ret && ret != -ENOTSUP) {
>> -		PMD_INIT_LOG(ERR, "Virtio-user set status failed (%d): %s", ret,
>> -			     strerror(errno));
>> -	}
>> +	if (ret && ret != -ENOTSUP)
>> +		PMD_INIT_LOG(ERR, "(%s) Failed to set backend status\n", dev-
>>> path);
>>
>>  	pthread_mutex_unlock(&dev->mutex);
>>  	return ret;
>> @@ -846,8 +900,7 @@ virtio_user_dev_update_status(struct virtio_user_dev *dev)
>>  			!!(dev->status & VIRTIO_CONFIG_STATUS_DEV_NEED_RESET),
>>  			!!(dev->status & VIRTIO_CONFIG_STATUS_FAILED));
>>  	} else if (ret != -ENOTSUP) {
>> -		PMD_INIT_LOG(ERR, "Virtio-user get status failed (%d): %s", ret,
>> -			     strerror(errno));
>> +		PMD_INIT_LOG(ERR, "(%s) Failed to get backend status\n", dev-
>>> path);
>>  	}
>>
>>  	pthread_mutex_unlock(&dev->mutex);
>> --
>> 2.29.2
> 


  reply	other threads:[~2021-01-15 11:09 UTC|newest]

Thread overview: 149+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-20 21:13 [dpdk-dev] [PATCH 00/40] net/virtio: Virtio PMD rework Maxime Coquelin
2020-12-20 21:13 ` [dpdk-dev] [PATCH 01/40] bus/vdev: add helper to get vdev from eth dev Maxime Coquelin
2020-12-30  3:02   ` Xia, Chenbo
2021-01-05 21:15   ` David Marchand
2020-12-20 21:13 ` [dpdk-dev] [PATCH 02/40] net/virtio: Introduce Virtio bus type Maxime Coquelin
2020-12-30  3:02   ` Xia, Chenbo
2021-01-05 21:15   ` David Marchand
2021-01-14  9:24     ` Maxime Coquelin
2021-01-14 10:54       ` Maxime Coquelin
2021-01-14 11:55         ` David Marchand
2020-12-20 21:13 ` [dpdk-dev] [PATCH 03/40] net/virtio: refactor virtio-user device Maxime Coquelin
2020-12-30  3:02   ` Xia, Chenbo
2021-01-05 21:16   ` David Marchand
2021-01-14  9:26     ` Maxime Coquelin
2020-12-20 21:13 ` [dpdk-dev] [PATCH 04/40] net/virtio: introduce PCI device metadata Maxime Coquelin
2020-12-30  3:02   ` Xia, Chenbo
2021-01-05 21:16   ` David Marchand
2021-01-14 11:05     ` Maxime Coquelin
2021-01-14 14:40       ` David Marchand
2021-01-14 14:44         ` Maxime Coquelin
2020-12-20 21:13 ` [dpdk-dev] [PATCH 05/40] net/virtio: move PCI device init in dedicated file Maxime Coquelin
2020-12-30  3:02   ` Xia, Chenbo
2021-01-05 21:19   ` David Marchand
2021-01-14 16:04     ` Maxime Coquelin
2021-01-14 16:14       ` David Marchand
2020-12-20 21:13 ` [dpdk-dev] [PATCH 06/40] net/virtio: move PCI specific dev init to PCI ethdev init Maxime Coquelin
2020-12-30  3:05   ` Xia, Chenbo
2021-01-06  8:58   ` David Marchand
2020-12-20 21:13 ` [dpdk-dev] [PATCH 07/40] net/virtio: move MSIX detection to PCI ethdev Maxime Coquelin
2020-12-30  3:05   ` Xia, Chenbo
2021-01-06  8:22   ` David Marchand
2021-01-14 17:19     ` Maxime Coquelin
2020-12-20 21:13 ` [dpdk-dev] [PATCH 08/40] net/virtio: force IOVA as VA mode for Virtio-user Maxime Coquelin
2020-12-30  3:06   ` Xia, Chenbo
2021-01-06  9:06   ` David Marchand
2021-01-06  9:11     ` Thomas Monjalon
2021-01-06  9:22       ` Maxime Coquelin
2021-01-06 16:37       ` Kinsella, Ray
2021-01-06  9:14     ` Maxime Coquelin
2020-12-20 21:13 ` [dpdk-dev] [PATCH 09/40] net/virtio: store PCI type in Virtio device metadata Maxime Coquelin
2020-12-30  3:07   ` Xia, Chenbo
2021-01-06  9:14   ` David Marchand
2020-12-20 21:13 ` [dpdk-dev] [PATCH 10/40] net/virtio: add callback for device closing Maxime Coquelin
2020-12-30  3:07   ` Xia, Chenbo
2021-01-06  9:33   ` David Marchand
2020-12-20 21:13 ` [dpdk-dev] [PATCH 11/40] net/virtio: validate features at bus level Maxime Coquelin
2020-12-30  3:08   ` Xia, Chenbo
2021-01-06  9:33   ` David Marchand
2021-01-15  9:20     ` Maxime Coquelin
2020-12-20 21:13 ` [dpdk-dev] [PATCH 12/40] net/virtio: remove bus type enum Maxime Coquelin
2020-12-30  3:08   ` Xia, Chenbo
2021-01-06  9:33   ` David Marchand
2020-12-20 21:13 ` [dpdk-dev] [PATCH 13/40] net/virtio: move PCI-specific fields to PCI device Maxime Coquelin
2020-12-30  3:08   ` Xia, Chenbo
2021-01-06  9:58   ` David Marchand
2020-12-20 21:13 ` [dpdk-dev] [PATCH 14/40] net/virtio: pack virtio HW struct Maxime Coquelin
2020-12-30  3:09   ` Xia, Chenbo
2021-01-06  9:58   ` David Marchand
2021-01-15  9:35     ` Maxime Coquelin
2020-12-20 21:13 ` [dpdk-dev] [PATCH 15/40] net/virtio: move legacy IO to Virtio PCI Maxime Coquelin
2020-12-30  3:09   ` Xia, Chenbo
2021-01-06 10:09   ` David Marchand
2020-12-20 21:13 ` [dpdk-dev] [PATCH 16/40] net/virtio: introduce generic virtio header Maxime Coquelin
2020-12-30  3:09   ` Xia, Chenbo
2021-01-06 10:08   ` David Marchand
2021-01-15  9:39     ` Maxime Coquelin
2020-12-20 21:13 ` [dpdk-dev] [PATCH 17/40] net/virtio: move features definition to generic header Maxime Coquelin
2020-12-30  3:14   ` Xia, Chenbo
2021-01-14  8:40     ` Maxime Coquelin
2020-12-20 21:13 ` [dpdk-dev] [PATCH 18/40] net/virtio: move virtqueue defines in " Maxime Coquelin
2020-12-30  3:14   ` Xia, Chenbo
2021-01-06 15:53   ` David Marchand
2021-01-15 10:55     ` Maxime Coquelin
2020-12-20 21:13 ` [dpdk-dev] [PATCH 19/40] net/virtio: move config definitions to " Maxime Coquelin
2020-12-30  3:15   ` Xia, Chenbo
2021-01-06 16:01   ` David Marchand
2021-01-15 11:01     ` Maxime Coquelin
2020-12-20 21:13 ` [dpdk-dev] [PATCH 20/40] net/virtio: make interrupt handling more generic Maxime Coquelin
2020-12-30  3:17   ` Xia, Chenbo
2021-01-14  8:43     ` Maxime Coquelin
2021-01-06 16:07   ` David Marchand
2020-12-20 21:13 ` [dpdk-dev] [PATCH 21/40] net/virtio: move vring alignment to generic header Maxime Coquelin
2020-12-30  3:18   ` Xia, Chenbo
2021-01-06 16:13   ` David Marchand
2020-12-20 21:13 ` [dpdk-dev] [PATCH 22/40] net/virtio: remove last PCI refs in non-PCI code Maxime Coquelin
2020-12-30  3:25   ` Xia, Chenbo
2021-01-14  8:46     ` Maxime Coquelin
2021-01-06 16:18   ` David Marchand
2021-01-15 11:10     ` Maxime Coquelin
2020-12-20 21:13 ` [dpdk-dev] [PATCH 23/40] net/virtio: make Vhost-user req sender consistent Maxime Coquelin
2021-01-06 11:50   ` Xia, Chenbo
2021-01-15  9:47     ` Maxime Coquelin
2020-12-20 21:13 ` [dpdk-dev] [PATCH 24/40] net/virtio: add Virtio-user ops to set owner Maxime Coquelin
2021-01-06 11:50   ` Xia, Chenbo
2020-12-20 21:13 ` [dpdk-dev] [PATCH 25/40] net/virtio: add Virtio-user features ops Maxime Coquelin
2021-01-06 11:54   ` Xia, Chenbo
2021-01-13 13:43     ` Adrian Moreno
2021-01-13 13:54       ` Maxime Coquelin
2021-01-15 14:19       ` Maxime Coquelin
2021-01-13 13:57   ` Adrian Moreno
2021-01-15 14:29     ` Maxime Coquelin
2020-12-20 21:13 ` [dpdk-dev] [PATCH 26/40] net/virtio: add Virtio-user protocol " Maxime Coquelin
2021-01-06 11:55   ` Xia, Chenbo
2020-12-20 21:13 ` [dpdk-dev] [PATCH 27/40] net/virtio: add Virtio-user memory tables ops Maxime Coquelin
2021-01-06 11:57   ` Xia, Chenbo
2021-01-15  9:57     ` Maxime Coquelin
2020-12-20 21:13 ` [dpdk-dev] [PATCH 28/40] net/virtio: add Virtio-user vring setting ops Maxime Coquelin
2021-01-05 21:24   ` David Marchand
2021-01-06 12:01   ` Xia, Chenbo
2021-01-15 10:12     ` Maxime Coquelin
2021-01-06 12:03   ` Xia, Chenbo
2021-01-15 10:15     ` Maxime Coquelin
2020-12-20 21:13 ` [dpdk-dev] [PATCH 29/40] net/virtio: add Virtio-user vring file ops Maxime Coquelin
2021-01-05 21:24   ` David Marchand
2021-01-06 12:04   ` Xia, Chenbo
2021-01-15 10:17     ` Maxime Coquelin
2020-12-20 21:13 ` [dpdk-dev] [PATCH 30/40] net/virtio: add Virtio-user vring address ops Maxime Coquelin
2021-01-06 12:06   ` Xia, Chenbo
2021-01-15 10:19     ` Maxime Coquelin
2020-12-20 21:13 ` [dpdk-dev] [PATCH 31/40] net/virtio: add Virtio-user status ops Maxime Coquelin
2021-01-06 12:09   ` Xia, Chenbo
2021-01-15 10:48     ` Maxime Coquelin
2020-12-20 21:13 ` [dpdk-dev] [PATCH 32/40] net/virtio: remove useless request ops Maxime Coquelin
2020-12-20 21:13 ` [dpdk-dev] [PATCH 33/40] net/virtio: improve Virtio-user errors handling Maxime Coquelin
2021-01-07  2:26   ` Xia, Chenbo
2021-01-15 11:09     ` Maxime Coquelin [this message]
2020-12-20 21:13 ` [dpdk-dev] [PATCH 34/40] net/virtio: move Vhost-user reqs to Vhost-user backend Maxime Coquelin
2020-12-20 21:14 ` [dpdk-dev] [PATCH 35/40] net/virtio: make server mode blocking Maxime Coquelin
2021-01-07  3:20   ` Xia, Chenbo
2021-01-15 11:13     ` Maxime Coquelin
2020-12-20 21:14 ` [dpdk-dev] [PATCH 36/40] net/virtio: move protocol features to Vhost-user Maxime Coquelin
2020-12-20 21:14 ` [dpdk-dev] [PATCH 37/40] net/virtio: introduce backend data Maxime Coquelin
2021-01-05 21:26   ` David Marchand
2021-01-13 17:18   ` Adrian Moreno
2021-01-15 16:49     ` Maxime Coquelin
2020-12-20 21:14 ` [dpdk-dev] [PATCH 38/40] net/virtio: move Vhost-user specifics to its backend Maxime Coquelin
2021-01-07  6:32   ` Xia, Chenbo
2021-01-15 12:03     ` Maxime Coquelin
2020-12-20 21:14 ` [dpdk-dev] [PATCH 39/40] net/virtio: move Vhost-kernel data " Maxime Coquelin
2021-01-07  6:42   ` Xia, Chenbo
2021-01-11  8:02   ` Xia, Chenbo
2021-01-15 11:54     ` Maxime Coquelin
2021-01-18 20:36     ` Maxime Coquelin
2020-12-20 21:14 ` [dpdk-dev] [PATCH 40/40] net/virtio: move Vhost-vDPA " Maxime Coquelin
2020-12-22 15:20   ` Maxime Coquelin
2021-01-07  6:50   ` Xia, Chenbo
2021-01-15 12:08     ` Maxime Coquelin
2021-01-11  8:05   ` Xia, Chenbo
2020-12-21 10:58 ` [dpdk-dev] [PATCH 00/40] net/virtio: Virtio PMD rework Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=111273ff-71a8-0aab-98b0-9d83d419222d@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=amorenoz@redhat.com \
    --cc=chenbo.xia@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=olivier.matz@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git