From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F504A0547; Mon, 5 Dec 2022 09:28:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 630A240F18; Mon, 5 Dec 2022 09:28:46 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 793DC40A87 for ; Mon, 5 Dec 2022 09:28:44 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 032B65C004D; Mon, 5 Dec 2022 03:28:42 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 05 Dec 2022 03:28:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1670228921; x= 1670315321; bh=o70t294LoFyRnZjue298Q/dojLFLFsIqBGWzLx3keSQ=; b=r VImSk7mb0kJy2jS4X1oHIBkLs2OU8/hMec+8ErqwF6wcAP+JZupiSy+eLjeTYpX5 eAz5JJvGcqiOo2faos7F7b1QjMkT9A7s9ONNHKIa9AHS2nhzqA0H7tIPZ5NDUmF0 z+jg51aGwpPjy0WTjefBb3wN2UoL9L/b1Rp7v/DSKItBE/2vOB8bzUOEvXCL/eih HQmscPJ8i8gFXCfsxMp6ILgEbitNHbfdLBZwEXnPccJ3uEYYhKKOPLebmQix0rGP BFQZnPOG3wKJLvBsZK49/5/HjYV0PlsRnxP1ynu6OCYhuGrcnZMbsbKnexAIMqH8 LasPJsPGSK1VDBP+tqMlg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1670228921; x= 1670315321; bh=o70t294LoFyRnZjue298Q/dojLFLFsIqBGWzLx3keSQ=; b=C Rdj+wrInxuFPqV3Z+Yrg9PSEjGM+anu6zo/n53Wq0919b+jd4Oo/kfjHy2GBRNIq isf2hhafkHeikxNrfN3cm3cC1wbbacfuR0mKi+HzS28inKjP1Do769GbtviQ1Wyd elb1dIWFwDofwVxlMAoe3ElqGQeQQd8a62gKHNa7DVe72xzrJ5e1bgAqTZDda07R JyHg6IfSnmLaVxMgBcNdtBpET6Q7Tdno6NBgshBGk2Gl859Zszs3H+9V8WA2V8t6 y8p3GOYNIwuX2tp+/T/TMzTL4P+Mu9ky5f3pNuMjdu97xnYeRyfMDYdHQCsKtN6f 7oU/AlsBV+TPcy8sSNP4A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudefgdduvddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeegtddtleejjeegffekkeektdejvedtheevtdekiedvueeuvdei uddvleevjeeujeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 5 Dec 2022 03:28:40 -0500 (EST) From: Thomas Monjalon To: Andrew Rybchenko , Hanumanth Reddy Pothula Cc: "dev@dpdk.org" , Aman Singh , Yuying Zhang , "dev@dpdk.org" , Jerin Jacob Kollanukkaran , Nithin Kumar Dabilpuram , "rasland@nvidia.com" , "orika@nvidia.com" , "viacheslavo@nvidia.com" Subject: Re: [EXT] Re: [PATCH v3 1/1] app/testpmd: control passing Rx metadata to PMD Date: Mon, 05 Dec 2022 09:28:35 +0100 Message-ID: <111350205.nniJfEyVGO@thomas> In-Reply-To: References: <20220802175151.2277437-1-hpothula@marvell.com> <8148001.T7Z3S40VBb@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 05/12/2022 08:59, Hanumanth Reddy Pothula: > From: Thomas Monjalon > > 02/12/2022 17:14, Hanumanth Reddy Pothula: > > > -----Original Message----- > > > > 27/10/2022 09:34, Thomas Monjalon: > > > > > 17/10/2022 10:32, Andrew Rybchenko: > > > > > > On 10/6/22 21:35, Hanumanth Pothula wrote: > > > > > > > Presently, Rx metadata is sent to PMD by default, leading to a > > > > > > > performance drop as processing for the same in rx path takes > > > > > > > extra cycles. > > > > > > > > > > > > > > Hence, introducing command line argument, 'nic-to-pmd-rx- > > metadata' > > > > > > > to control passing rx metadata to PMD. By default it=E2=80=99= s disabled. > > > > > > > > > > > > > > Signed-off-by: Hanumanth Pothula > > > > > > > > > > > > Acked-by: Andrew Rybchenko > > > > > > > > > > > > Applied to dpdk-next-net/main, thanks. > > > > > > > > > > I'm not sure this patch is really acceptable. > > > > > It is disabling Rx metadata by default just for benchmarking > > > > > reason because your driver is doing some processing even if > > > > > metadata is not > > > > required. > > > > > > > > > > From a user perspective, if a command requesting metadata is > > > > > entered, it won't work until we enable this new option on startup. > > > > > It looks terrible. > > > > > > > > > > Please tell me I misunderstood something. > > > > > > > > While pulling, I see that the name is not compliant with others. > > > > I think it should start with "enable-", use hyphens and be sorted. > > > > > > > > I'll drop it from the pull for now, we can have it in -rc3. > > > > > > > > > > @Thomas Monjalon I missed your comment, sorry for the delayed > > response. > > > > > > Sending Rx metadata to PMD is added recently, which breaking our driv= er > > performance. > > > Normally any feature added to testpmd will be disabled by default, to > > make sure it won't affect other code(PMD). > > > Hence adding new testpmd command line argument to disable this > > feature by default. > >=20 > > No, disabling by default doesn't mean you should enable with option. > > It should be enabled if required by a command. > >=20 > Yeah, got it, user can enable/disable the feature on the fly without rest= arting the application(testpmd). > Will introduce new command, like below,=20 > 'port config rx-nic-to-pmd-metadata on/off' >=20 > Please let me know your thoughts on this command implementation. > If it's fine, will start implementing the command. Suggest if there is an= y other better way to implement the same. What about enabling automatically when a flow command requests metadata?