DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Wei Hu (Xavier)" <xavier.huwei@huawei.com>
To: Thomas Monjalon <thomas@monjalon.net>, luyicai <luyicai@huawei.com>
Cc: <dev@dpdk.org>, <chas3@att.com>, <zhangliang@bigo.sg>,
	<chenchanghu@huawei.com>, <jerry.lilijun@huawei.com>,
	<haifeng.lin@huawei.com>, <guohongzhi1@huawei.com>,
	<ferruh.yigit@intel.com>,  <matan@mellanox.com>,
	<rasland@mellanox.com>,
	"Wei Hu (Xavier)" <xavier.huwei@huawei.com>
Subject: Re: [dpdk-dev] [PATCH] drivers/net/bonding: fix bug for lacp negotiation failed
Date: Sat, 11 Jul 2020 09:42:18 +0800	[thread overview]
Message-ID: <11149f9f-7edb-51ab-7679-4c4e07e46515@huawei.com> (raw)
In-Reply-To: <7487826.b65qEJXc0Y@thomas>


Hi, Thomas Monjalon

   The  patch V2 has been sent by luyicai, and V2 is good to me.

Thanks, Xavier


On 2020/7/11 5:07, Thomas Monjalon wrote:
> Still no review.
>
> Please give your real name in the Signed-off so it can be merged.
>
> 24/06/2020 12:43, Thomas Monjalon:
>> Any review please?
>>
>> 19/05/2020 13:18, luyicai:
>>> When two host is connected directly without any devices like switch,
>>> and also enable dedicated tx/rx queues on bonding devices slaves,
>>> rx_machine_update would recieving partner lacp negotiation packets,
>>> which partner's port mac filled with zeros. So in this situation,
>>> it would never go rx_machine branch with correct mac!
>>> Thus bond mode 4 will negotiation failed.
>>>
>>> Signed-off-by: luyicai <luyicai@huawei.com>
>>> ---
>>>   drivers/net/bonding/rte_eth_bond_8023ad.c | 3 ++-
>>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c
>>> index b77a37d..2002ec0 100644
>>> --- a/drivers/net/bonding/rte_eth_bond_8023ad.c
>>> +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
>>> @@ -798,7 +798,8 @@
>>>   		RTE_ASSERT(lacp->lacpdu.subtype == SLOW_SUBTYPE_LACP);
>>>   
>>>   		partner = &lacp->lacpdu.partner;
>>> -		if (rte_is_same_ether_addr(&partner->port_params.system,
>>> +		if (rte_is_zero_ether_addr(&partner->port_params.system) ||
>>> +			rte_is_same_ether_addr(&partner->port_params.system,
>>>   			&internals->mode4.mac_addr)) {
>>>   			/* This LACP frame is sending to the bonding port
>>>   			 * so pass it to rx_machine.
>>>
>>
>>
>>
>>
>>
>
>
>
>
>


  reply	other threads:[~2020-07-11  1:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-19 11:18 luyicai
2020-06-24 10:43 ` Thomas Monjalon
2020-07-10 21:07   ` Thomas Monjalon
2020-07-11  1:42     ` Wei Hu (Xavier) [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-05-19  7:53 luyicai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11149f9f-7edb-51ab-7679-4c4e07e46515@huawei.com \
    --to=xavier.huwei@huawei.com \
    --cc=chas3@att.com \
    --cc=chenchanghu@huawei.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=guohongzhi1@huawei.com \
    --cc=haifeng.lin@huawei.com \
    --cc=jerry.lilijun@huawei.com \
    --cc=luyicai@huawei.com \
    --cc=matan@mellanox.com \
    --cc=rasland@mellanox.com \
    --cc=thomas@monjalon.net \
    --cc=zhangliang@bigo.sg \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).