From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6ECC0A0528; Sat, 11 Jul 2020 03:42:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3B84C1DA7A; Sat, 11 Jul 2020 03:42:29 +0200 (CEST) Received: from huawei.com (szxga07-in.huawei.com [45.249.212.35]) by dpdk.org (Postfix) with ESMTP id EFCE71D506 for ; Sat, 11 Jul 2020 03:42:27 +0200 (CEST) Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 7D1764002AEFE7F18B73; Sat, 11 Jul 2020 09:42:26 +0800 (CST) Received: from [10.69.31.206] (10.69.31.206) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Sat, 11 Jul 2020 09:42:18 +0800 To: Thomas Monjalon , luyicai References: <1589887092-26360-1-git-send-email-luyicai@huawei.com> <3071696.IbEkSYjo7c@thomas> <7487826.b65qEJXc0Y@thomas> CC: , , , , , , , , , , "Wei Hu (Xavier)" From: "Wei Hu (Xavier)" Message-ID: <11149f9f-7edb-51ab-7679-4c4e07e46515@huawei.com> Date: Sat, 11 Jul 2020 09:42:18 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <7487826.b65qEJXc0Y@thomas> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.69.31.206] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH] drivers/net/bonding: fix bug for lacp negotiation failed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Thomas Monjalon The patch V2 has been sent by luyicai, and V2 is good to me. Thanks, Xavier On 2020/7/11 5:07, Thomas Monjalon wrote: > Still no review. > > Please give your real name in the Signed-off so it can be merged. > > 24/06/2020 12:43, Thomas Monjalon: >> Any review please? >> >> 19/05/2020 13:18, luyicai: >>> When two host is connected directly without any devices like switch, >>> and also enable dedicated tx/rx queues on bonding devices slaves, >>> rx_machine_update would recieving partner lacp negotiation packets, >>> which partner's port mac filled with zeros. So in this situation, >>> it would never go rx_machine branch with correct mac! >>> Thus bond mode 4 will negotiation failed. >>> >>> Signed-off-by: luyicai >>> --- >>> drivers/net/bonding/rte_eth_bond_8023ad.c | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c >>> index b77a37d..2002ec0 100644 >>> --- a/drivers/net/bonding/rte_eth_bond_8023ad.c >>> +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c >>> @@ -798,7 +798,8 @@ >>> RTE_ASSERT(lacp->lacpdu.subtype == SLOW_SUBTYPE_LACP); >>> >>> partner = &lacp->lacpdu.partner; >>> - if (rte_is_same_ether_addr(&partner->port_params.system, >>> + if (rte_is_zero_ether_addr(&partner->port_params.system) || >>> + rte_is_same_ether_addr(&partner->port_params.system, >>> &internals->mode4.mac_addr)) { >>> /* This LACP frame is sending to the bonding port >>> * so pass it to rx_machine. >>> >> >> >> >> >> > > > > >