From: Thomas Monjalon <thomas@monjalon.net>
To: "Morten Brørup" <mb@smartsharesystems.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v2] mbuf: improve mbuf comments
Date: Tue, 11 Nov 2025 13:17:33 +0100 [thread overview]
Message-ID: <11157846.ICPdZLu4VQ@thomas> (raw)
In-Reply-To: <20251107143629.612723-1-mb@smartsharesystems.com>
07/11/2025 15:36, Morten Brørup:
> Updated the comment preceding the 'rearm_data' fields to reflect that some
> ethdev drivers don't really set the rearm_data fields on Rx descriptor
> rearm, but rather when pulling the packet from the descriptor.
> By doing this, they avoid a store operation into the mbuf when they rearm
> the Rx descriptor, and instead postpone it to later, where it will be
> combined with other store operations into the mbuf.
>
> Updated the comment describing what the second cache line is used for, to
> reflect that there are exceptions, where some fields are set on Rx too.
>
> Updated comments describing what needs to be updated when adding new Rx
> and Tx offload flags.
>
> Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
Applied, thanks.
prev parent reply other threads:[~2025-11-11 12:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-05 11:28 [PATCH] " Morten Brørup
2025-11-05 11:33 ` Morten Brørup
2025-11-05 21:28 ` Thomas Monjalon
2025-11-06 7:50 ` Morten Brørup
2025-11-07 14:35 ` Morten Brørup
2025-11-07 14:39 ` Morten Brørup
2025-11-07 14:36 ` [PATCH v2] " Morten Brørup
2025-11-11 12:17 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11157846.ICPdZLu4VQ@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=mb@smartsharesystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).