From: Thomas Monjalon <thomas@monjalon.net>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v1 1/2] doc: add devargs documentation
Date: Sun, 30 Nov 2025 16:44:44 +0100 [thread overview]
Message-ID: <11158378.CDJkKcVGEf@thomas> (raw)
In-Reply-To: <f9c79b16f3f90c3521acabdcaa96a9e61dca705b.1763122378.git.anatoly.burakov@intel.com>
14/11/2025 13:13, Anatoly Burakov:
> Currently, the devargs syntax documentation is missing from the
> programmer's guide, and is only documented implicitly through the devargs
> API headers. Add a detailed description of the two supported devargs
> syntaxes.
Thank you for writing this. It is really important.
> +* **Bus identifier and arguments**: Which bus handles the device (e.g., ``pci``, ``vdev``) and bus-level parameters
> +* **Class identifier and arguments**: Device class (e.g., ``eth``, ``crypto``) and class-level parameters
> +* **Driver identifier and arguments**: The specific driver and its driver-specific parameters
> +
> +DPDK supports two devargs syntaxes:
> +
> +1. **Simplified syntax** - For common case targeting a specific device.
> +2. **Multi-layer syntax** - For device filtering by bus, class, or driver.
I would prefer we see the last one as a generic syntax.
Others are shortcuts.
> +
> +
> +Devargs Syntax
> +--------------
> +
> +Device-centric syntax
> +~~~~~~~~~~~~~~~~~~~~~
> +
> +In most cases, devargs can be used with simplified format that targets specific devices:
> +
> +.. code-block:: none
> +
> + [bus:]device_identifier[,arg1=val1,arg2=val2,...]
[...]
> +Driver-centric Syntax
> +~~~~~~~~~~~~~~~~~~~~~
If you give a PCI address or a vdev name, it targets a device.
> +
> +For advanced use cases that need to pass arguments to bus and/or class layers, or when matching multiple devices is required, DPDK supports a multi-layer syntax with three slash-separated segments:
> +
> +.. code-block:: none
> +
> + bus=<busname>,<bus_args>/class=<classname>,<class_args>/driver=<drvname>,<driver_args>
I think we should present this syntax first, with supported bus and class args.
Then we can present shortcuts equivalents with the old syntax.
[...]
> +Summary
> +-------
> +
> +Device arguments provide a flexible and standardized way to specify and configure devices in DPDK:
> +
> +* **Unified syntax**: Works across different bus types
> +* **Runtime and initialization**: Can be used both at EAL init and for hotplug
> +* **Driver configuration**: Supports arbitrary driver-specific parameters
> +* **Complex specifications**: Multi-layer syntax allows device filtering and configuration at bus, class, and driver levels
I'm not sur a summary is a good idea in such a documentation.
General statements are better viewed as intro.
You did a good job, but I think we should move things around to avoid confusion.
Please let's work on it together.
Thank you
prev parent reply other threads:[~2025-11-30 15:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 12:13 Anatoly Burakov
2025-11-14 12:13 ` [PATCH v1 2/2] doc: add device hotplug documentation Anatoly Burakov
2025-11-30 15:44 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11158378.CDJkKcVGEf@thomas \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).