From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f51.google.com (mail-wg0-f51.google.com [74.125.82.51])
 by dpdk.org (Postfix) with ESMTP id 3A87C683D
 for <dev@dpdk.org>; Wed,  1 Apr 2015 21:16:27 +0200 (CEST)
Received: by wgoe14 with SMTP id e14so63583294wgo.0
 for <dev@dpdk.org>; Wed, 01 Apr 2015 12:16:27 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=LhpT9nOxfxLZygvzs4kPp11MQiBq4f0Kxu9KTThnIio=;
 b=ZjQsYVBryXdccqAD3bjQ7jvnKHkCnpPkpFfJYaxxT+98SMcdUlGstDoPUNJ2w5CAk5
 oYmxRZU1TCiI14EFrE6K5WO7CHKAiROve57h8tXHc1mwi0lyKKZRblFZomPE7nZVNcfv
 5ooMAH4HsIPR7MOwt17axRO6i71KznCJeVYFUR/IdTLCeSGbAJFoJJxIWcFICE3/aH9L
 faBZZ91woFT22kbBiEV3Hh1BvwIJIonI+Vdt7y/Qfxat0c4P/rewgixvEapud+rvXjEF
 EqOG4vjl4iDAlCrT16n6CoY/uYjSuRa7wJf7o9aKDS0TO4uC2zeG8mSJO1KDVTnx4MTB
 ogBw==
X-Gm-Message-State: ALoCoQnadlrPu9kxf1+vk7Jmt65Nh+OKG9NtHCkuFmy74Q4YR3Zv8uEr83f+KzYRC7G5TdRQCT1H
X-Received: by 10.194.81.1 with SMTP id v1mr83542173wjx.50.1427915786664;
 Wed, 01 Apr 2015 12:16:26 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id cf12sm3973590wjb.10.2015.04.01.12.16.25
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 01 Apr 2015 12:16:25 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: David Marchand <david.marchand@6wind.com>
Date: Wed, 01 Apr 2015 21:15:44 +0200
Message-ID: <11183736.tf2gLjOhOM@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; )
In-Reply-To: <CALwxeUtxfcrU-gKyA37qZDCsWipE1mcaNS338yOsUuJB0YnPyQ@mail.gmail.com>
References: <1427839547-14705-1-git-send-email-thomas.monjalon@6wind.com>
 <CALwxeUtxfcrU-gKyA37qZDCsWipE1mcaNS338yOsUuJB0YnPyQ@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] pci: rename passthrough driver to kernel
	driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Apr 2015 19:16:27 -0000

> > Kernel driver (kdrv) seems easier to understand than
> > passthrough driver (pt_driver). It's also more generic
> > as a PMD could run on top of any PCI kernel driver if
> > it would offer such support.
> >
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> > ---
> >  lib/librte_eal/bsdapp/eal/eal_pci.c     |  3 +--
> >  lib/librte_eal/common/include/rte_pci.h | 12 ++++++------
> >  lib/librte_eal/linuxapp/eal/eal_pci.c   | 33
> > ++++++++++++++++-----------------
> >  lib/librte_ether/rte_ethdev.c           |  8 ++++----
> >  4 files changed, 27 insertions(+), 29 deletions(-)
> >
> 
> This looks ok for me.
> I suppose you checked it builds fine on both linux and bsd ?

Yes it builds fine in my Linux and FreeBSD 10.0.

> Acked-by: David Marchand <david.marchand@6wind.com>

Applied, thanks