From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6CA6C42C73; Sat, 10 Jun 2023 22:15:10 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E211E410EF; Sat, 10 Jun 2023 22:15:09 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 4C22C40DD8 for ; Sat, 10 Jun 2023 22:15:08 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 3C3485C0003; Sat, 10 Jun 2023 16:15:07 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sat, 10 Jun 2023 16:15:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1686428107; x=1686514507; bh=aBKXBqmgYTGHNCOx/78InDQUgVosEYlEt6l EA9xUbas=; b=Bmxrk8wqxXG6Yel5RuKm/dtK/F9tz8ESEdfaSqck3vtrle+fixw ycB67IXncGChiVildtt1rDWdxa5qjIwn6HQU5XRyvQvuyroUaHwTI28npEC0xB9x oYi9+7YNiRPA6ZOIVov9058s7ufpVsFxJ9uXvYnIpbIivgkbLQo2EV54ln4kzNRt iCr0JQmD0194fKmOWKpO5ECX4WNztbxoiKHWznf7736zVdSSOlLA8by5kIjZiaZQ Qa9+A7JBfwr8v8ghu6lMGKIGhfcu88I1zUPWBniSR9LqDWYJeYmsT8/7eLjnbrQH Cg9NxdTCP24bFxf7G79Hu07+Ew79EKjm3nw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1686428107; x=1686514507; bh=aBKXBqmgYTGHNCOx/78InDQUgVosEYlEt6l EA9xUbas=; b=AXPhA42dgF6CcC7l0iUMbkv6eyesPBQhEwej7VwiRSEZWVObSUO 71tNf8Wo2kOgO40ovkJKMx2Obkb3eJzbiFDPrswVxqVjldaaACWlBQB036fvy0xu 5rBhD6iAX728RSIAbU9idPxTXxBzn1xntjN8qTDy8RK3RLhdAAxnAsgLaVGnP++h 76a+HRgiAlR9TrDBzCCpRS6zElMYv5EYndHGteGYaprJh/SXbNwuOzO7Fz0QEacm gmT2Q8tBgR6idlV8QLy+sVnzS9z9+sPbG58ZiHJPd08TGO1DnB82uUttSHdcOWt4 ZyX9xAO6x/LocX480P6T47oJ/P0ycgy8C1A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgedutddgudehtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnhepheevgfejuefhfeefhfetvefhjedtgfeuudevieeulefgleek jeettedvgfeiteetnecuffhomhgrihhnpegrrhhmrdgtohhmnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 10 Jun 2023 16:15:05 -0400 (EDT) From: Thomas Monjalon To: Ciara Power Cc: dev@dpdk.org, kai.ji@intel.com, gakhil@marvell.com, Pablo de Lara , honnappa.nagarahalli@arm.com, fangming.fang@arm.com, david.marchand@redhat.com Subject: Re: [PATCH v2 8/8] crypto/ipsec_mb: set and use session ID Date: Sat, 10 Jun 2023 22:15:02 +0200 Message-ID: <112430369.nniJfEyVGO@thomas> In-Reply-To: <20230516152422.606617-9-ciara.power@intel.com> References: <20230421131221.1732314-1-ciara.power@intel.com> <20230516152422.606617-1-ciara.power@intel.com> <20230516152422.606617-9-ciara.power@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 16/05/2023 17:24, Ciara Power: > From: Pablo de Lara > > When creating a session, get the session ID that > defines the fixed session parameters and store it in the private data. > When retrieving IMB_JOB's, if their internal session ID matches > the one in the private session data, these fixed session parameters > do not need to be filled again. > > Signed-off-by: Pablo de Lara > Signed-off-by: Ciara Power [...] > +#if IMB_VERSION(1, 3, 0) < IMB_VERSION_NUM > + sess->session_id = imb_set_session(mb_mgr, &sess->template_job); > +#endif For info, this does not compile with https://git.gitlab.arm.com/arm-reference-solutions/ipsec-mb.git because Arm did not merge Intel's code correctly, and imb_set_session() is missing while version is 1.4.0-dev. Anyway I hate this situation having 2 repos for the same thing. Please merge Arm code in the original repository from Intel.