From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE8F6A0032; Mon, 15 Nov 2021 18:08:29 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 49F5740E01; Mon, 15 Nov 2021 18:08:29 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id E8D7040141 for ; Mon, 15 Nov 2021 18:08:27 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10169"; a="296911755" X-IronPort-AV: E=Sophos;i="5.87,237,1631602800"; d="scan'208";a="296911755" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2021 09:08:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,237,1631602800"; d="scan'208";a="734884824" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga006.fm.intel.com with ESMTP; 15 Nov 2021 09:08:26 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 15 Nov 2021 09:08:26 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 15 Nov 2021 09:08:25 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 15 Nov 2021 09:08:25 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.107) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 15 Nov 2021 09:08:25 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iCaUX3hTVgdnsoJ7oaWNAKCfYgzxcFdoPvSPaaa9ftCVAk5HZM+hO24VR+84pIwxh0v7VKL/nLgiaIdhhj3jePxZloR5lbX18qWRP6yLUANz/DqVS2EHzmGmuh8MEk/sQzcsHxetSlMnDFuDAktcXjldgAbwyxOxLAIdHKlShHR4dJ2h1RegS3AHpegi/fiQSxoZg7v+F+xPSm7sb+RCN8QxWHrvHdg9aDFbj6ch0zXIUMz/vUhyzu6T8q2okLL6M+2Ri2fWP/LuAP7PrVbw+uxOxBfLDcHSBlzICiHo/BSLa4SwZoBeOeW3pX1RgA030oztfKnfeqlIL7YUwM0JkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O25sHH/BbbE/gS3XNAOOjKS3VTMQ9MdZTIWfNV+efog=; b=F7ZN5Lh6jGDsBWamY6KMTXkYYNaxZcXVg5T0+wdqQMnS8tj9DElTYwzh8JcoXHYEYLnJztzMOaBvzmOFuXZEQy0cQJcXFX30cr1rbas68bp2XO5KRgr1XM93q81RX4ma6b1YWqatpCuzqG7ZT8/VHeP+Mi05pR2eld1HT9hRtbo1X0thriRRsQF0c/ojk5yxvTUpn3SP2/tawS4XZLZwsReKVRaC5zgC7b63QKI7u5mkgmEiDwa5EztvSumoMi2lnywVjXVSyFmmYm5y5Q1OY1+J2+yBNmnMsoc8FPBc3EyZyTigAG3J9di47oTx+iWN1lerpx5YBvhASjAb4icQXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O25sHH/BbbE/gS3XNAOOjKS3VTMQ9MdZTIWfNV+efog=; b=FGH+V8bMwZULhiyTLlNf7Nep8nLBYCnL2idZDgGeUIYv6x2Kzmiktb29dmakzu3cfem8P6Rc+2r1SVclhZRL6rA8zkgeIK9h8BfxvStCKCpPp+3FiPLCzjVk6FPB8UeWPAUgT9X9GU2LkG3m5sutcix7J2j/2cJrnJwaNK2KgrY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5902.namprd11.prod.outlook.com (2603:10b6:510:14d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.26; Mon, 15 Nov 2021 17:08:24 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c%5]) with mapi id 15.20.4690.027; Mon, 15 Nov 2021 17:08:24 +0000 Message-ID: <11265174-7f74-9926-8931-134b6a97eba4@intel.com> Date: Mon, 15 Nov 2021 17:08:18 +0000 Subject: Re: [PATCH 1/2] net/af_xdp: revert use BPF link for XDP programs Content-Language: en-US To: Ciara Loftus , References: <20211112103002.50380-1-ciara.loftus@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211112103002.50380-1-ciara.loftus@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB8PR06CA0029.eurprd06.prod.outlook.com (2603:10a6:10:100::42) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB8PR06CA0029.eurprd06.prod.outlook.com (2603:10a6:10:100::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.15 via Frontend Transport; Mon, 15 Nov 2021 17:08:23 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 282a144d-ea7b-4e87-275e-08d9a85a8867 X-MS-TrafficTypeDiagnostic: PH0PR11MB5902: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:660; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wN9JecXIqEDQ0XwsHoyXdCLxT89fw6bcnADnkKCG6UaR7Bx93YOff+ejTJe65WOj/97bb4ijmC4PuVrdQiz+l58v6bjvEcxaS0/S9kYwLSiNdJsAnfy/8gqIrS5RPZHfAuZ86O+jRLqbVu8YepfWtLEWfIHKBROHqxDDoGIl8C+A7RqYkpUbqVNfHJlivfv0lytW/XAQf6SymdQQXsnFNOrk5tU6MLuFRO1uLGs/0sX+QxzR0lXONGvgcdStWIXpcwPPOmCrKwIlZviNp4lvqClDkMW+ltn0FvsDdM1HQpJW5fJb16Pg7hcdCa6tn7TUAeQgtPPTGh2V7ubCV9ooAdoD/oyYzI6LGffLe86yfPAm/RGggPk5znJrx7qw+IJM7ywgi5djqR2XOtp9wRst2xBRmny2n9iLwToliAijkAe9Fpqq+3EeCYunEU7t0aTi6llZLb4EeKDy45pi5IIM6hTYZusxeL+dw3ZELfG/Qg+Zw+Wyhf4aidNoguumeyjt/I0Mz30B7vZYT8zrvjx82hDFFFFFWM5B0O5Dlts4ir5fX/knQYsW5KUN2RmMuX/EvDYxR8gQ9zayt7k5npGoPXDVdKqoTSM694k95xlqaE/m3weDNqKEw2RI1NE7rkygI8cAKUwFvBPsHELZYqY36VcRH+GeeoaUdTurPwHbeMQBdv9cabkR8Ah9arOC8WADCuFojEC3C9SahHxDyhJYqw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(66476007)(53546011)(31686004)(66556008)(66946007)(2616005)(956004)(508600001)(5660300002)(186003)(2906002)(36756003)(38100700002)(4744005)(6666004)(82960400001)(86362001)(8936002)(26005)(8676002)(6486002)(44832011)(316002)(16576012)(31696002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YVRnUWdUSDBhejBiYnNONCtUeHlMMllhNEpUN1M2QWVJZm5OVkQ4TzM0TlNq?= =?utf-8?B?VmJzcVdHdW5tMTlRQlhDWFBTWVpKWXBqVE5WVWZPakZaK21yVDhDVEhUZmFk?= =?utf-8?B?RFdnZUpUN1IrTEVqcVJGS3d2QUZDMXNNMDNseVBwejJ4cHVEODEwbGlPNjRa?= =?utf-8?B?MkZBTWMvOW5zZlRQVlVRbDFFWk9LNmYzbmQ4eG9Vekd2K2cvWjNnVXlvQUFq?= =?utf-8?B?M29JcjZ3Z0k2ajBEOXdGK3crcWFubWJsdWtoa1ZOUGVaTEhaTFlPZlFTamV1?= =?utf-8?B?aGhOR1hGTSswL3pGUHpLN0tReEFwajhEOE9DbVZjZFFXZy9KRU1yYkVUai95?= =?utf-8?B?Z3FFalhGNG5qeG1WdkdhNDZQQkkwRzY3RjFYSCtuaGoyUmFZWUx1dVlFcTNl?= =?utf-8?B?NUNXRGZObHNxY1JTMFJsczYzMGQzbkxxNFFrWk43aGZEOW43MUpJelRNL0s4?= =?utf-8?B?OS9pSUlJTFZncndwM2NndGtLUzRQTWVsUzRyaHBObjVzeUxuSDliVloyZml1?= =?utf-8?B?dEIxM3gzQ0ttNUdwQmZuc1lKTi9rMUx1ZUcvdC9FaDE5Q1g5WUk1a2FuQ2Jz?= =?utf-8?B?K2NVNHFlUmorZjR4MTRkMUljVENLbGVTV0h2cW01RUUrTkIyV1p0Y1c0OG9s?= =?utf-8?B?c09HS1ppSUg5WXVueU5ZQ1MrdTFZS3BkcktIRVdVa1RlTUdxY2xUQWRwSVhy?= =?utf-8?B?Wm1ibks0UkJOeEpHalZXZGhPd3dKNVIzWkNTSEVyVW1Eb0RIeVFVK1R2S1o2?= =?utf-8?B?QThwRXNSOGdmRUNra2IwSVYwOUYzQXk0QWs4KzRNUkdydDVtdnZucWgxcGtV?= =?utf-8?B?SENpY3c0dm9lMENjN3BNSzc2TDJjOGo3YUNtVkRIRk02Q1dqWmJ5RU1xWlJQ?= =?utf-8?B?enRnaEk4SUNuUkNjeWl5RnpXSm1yenZPMXBURHducmh4T00wdUFoS1VYWmtk?= =?utf-8?B?d1FNU1Q4RFltNWI1SVJkdTJIa3k3TVA2aENod29uRjJJbzQ0aTJENWJuWExO?= =?utf-8?B?WWFzZGZOZDZHL0w4MVJwUkxnUVMzRE9vZnRabG00WXhJYktCMkNDOWk0V1hO?= =?utf-8?B?THRBQTNETGdUaXd0blMwanhCV3hwNHNGcSs3UG05eUMxUkhmMXVIQzRvR0N4?= =?utf-8?B?T2J3NG4vTFUyaU5aYlJhWDc5ZUcwYXFERlo2cHRCeGdma3JJbEtCZmV5cDhq?= =?utf-8?B?am9POERxRkREWE0zRVNCWUlvT051amo3NmJwK1ZqS29UNHhkWXh4RXVMQ0Nh?= =?utf-8?B?d3I1WnMzQW9QaXFMTFdNWHpZbjhqR2trMWVvdndULytEMGg2WWlBTUhiSHJX?= =?utf-8?B?OEpDNWFqK3lYRHNmZTRhbCs4THBxTHZnR2Q2TTl0V0tDK1daVytPUlhTcGhn?= =?utf-8?B?cmRwRUhwY1JUK1BZTE03WTVzc2lUZUQ2RGNYYmluZWJyTFV2NkRXdzVRWmY3?= =?utf-8?B?MjNpZVFCQUxWYVVQZ3BpUGp4WkRIb0c5K3dOOUovNGIwSFRKNXR4U1ppajhv?= =?utf-8?B?Ym1xRU5NMTBUd0JWOUhPeTVkZlIvLzRtQm1xbkhMb1BtUStReWNtUE8vQVVM?= =?utf-8?B?NXd3S0RkTWxER3ZVRmhRM1h4VGh5amRjdG5DVWdhVXRNQ1I4NXkxaVc0NEVN?= =?utf-8?B?OWJ5dWRuWmNFRVpBUVRwYzQ3bXJ6QmpsOEUwdWZzeElYQUhibkRkRkYvY21l?= =?utf-8?B?dVlucmxvSjlYa0lWdURwSE9vY3RHU094bk5FYVdBUVNjV0g5c2VXeGJxbEVs?= =?utf-8?B?SiswdjBmcDJXZzhUT3BYZXlCNUU3UDNVdDN1aUIwNm4vcEZtN1lFMFFjTHZz?= =?utf-8?B?NXpuZXdxcmZtYlU2MUxmMm9uZXB3ZngvbTFWTGgySHJrbTBObkEyZFExTTdF?= =?utf-8?B?elFZdDE1aU8zVEpCc1FnbTZCb3lyRlRRUVhQRitNYWZtcWNsMkxzT1hIMFhE?= =?utf-8?B?SnY3TWpTRWljWDU5Tzk5a0ErTHNNMTBFV3J4Slg1RmxGS3VIdVpZRmo4NGFT?= =?utf-8?B?SDNLR1lqTHV4djViTnhqTDZOcFdiOXRGcWR1bDNQNGlDUmdIODJqODJYeTZq?= =?utf-8?B?LzN4Mld5b0ZzTE9sVWlETXFBRVpoNFMyWFl3dUtDOWs4ODFKRUF3cmZHT3ZY?= =?utf-8?B?UDcrcXF0R0I2VXpnLzRiK1AraFViZFYxeXZNcSt6d3ByTkVJeWVFNnBzTGVZ?= =?utf-8?Q?haOXGwph61Lwp4sUqgpKlCI=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 282a144d-ea7b-4e87-275e-08d9a85a8867 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2021 17:08:24.4375 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HNi1u6y79yVDCylgDdCnQZLplBPjbnENeBI0XwAx12/0DTczB/ibBgj2pbEoKPISkTO9qgj80zlqlh9uSVM4+Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5902 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/12/2021 10:30 AM, Ciara Loftus wrote: > The commit ae70cc6e893b ("net/af_xdp: use BPF link for XDP programs") > caused compilation errors on kernels older than v5.8 due to absence of > the bpf_link_info struct and some definitions in the linux/bpf.h header. > Since relying on the reported kernel version is not a robust solution > and also since there doesn't appear to be a suitable definition in the bpf > header that the preprocessor could rely on to determine support for bpf > link, we will take a different approach to solving the issue that the > original patch attempted to solve. The next commit will address this. > > Fixes: ae70cc6e893b ("net/af_xdp: use BPF link for XDP programs") > > Signed-off-by: Ciara Loftus Series applied to dpdk-next-net/main, thanks.