DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] examples/vhost: fix out of sequence packets
@ 2016-01-19 19:18 Jianfeng Tan
  2016-01-20  2:47 ` Yuanhan Liu
  0 siblings, 1 reply; 3+ messages in thread
From: Jianfeng Tan @ 2016-01-19 19:18 UTC (permalink / raw)
  To: dev

Issue description: when packets go through vhost example to virtio
device and come back to another virtio device or physical NIC, the
sequence of packets will be changed.

Reported-by: Thomas Long <thomas.long@intel.com>
Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
---
 examples/vhost/main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/examples/vhost/main.c b/examples/vhost/main.c
index 2dcdacb..aa9aa5a 100644
--- a/examples/vhost/main.c
+++ b/examples/vhost/main.c
@@ -1336,8 +1336,8 @@ switch_worker(__attribute__((unused)) void *arg)
 							rte_pktmbuf_free(pkts_burst[--tx_count]);
 					}
 				}
-				while (tx_count)
-					virtio_tx_route(vdev, pkts_burst[--tx_count], (uint16_t)dev->device_fh);
+				for (i = 0; i < tx_count; ++i)
+					virtio_tx_route(vdev, pkts_burst[i], (uint16_t)dev->device_fh);
 			}
 
 			/*move to the next device in the list*/
-- 
2.1.4

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] examples/vhost: fix out of sequence packets
  2016-01-19 19:18 [dpdk-dev] [PATCH] examples/vhost: fix out of sequence packets Jianfeng Tan
@ 2016-01-20  2:47 ` Yuanhan Liu
  2016-02-28 21:31   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Yuanhan Liu @ 2016-01-20  2:47 UTC (permalink / raw)
  To: Jianfeng Tan; +Cc: dev

On Wed, Jan 20, 2016 at 03:18:11AM +0800, Jianfeng Tan wrote:
> Issue description: when packets go through vhost example to virtio
> device and come back to another virtio device or physical NIC, the
> sequence of packets will be changed.
> 
> Reported-by: Thomas Long <thomas.long@intel.com>
> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>

Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>

	--yliu

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] examples/vhost: fix out of sequence packets
  2016-01-20  2:47 ` Yuanhan Liu
@ 2016-02-28 21:31   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2016-02-28 21:31 UTC (permalink / raw)
  To: Jianfeng Tan; +Cc: dev

2016-01-20 10:47, Yuanhan Liu:
> On Wed, Jan 20, 2016 at 03:18:11AM +0800, Jianfeng Tan wrote:
> > Issue description: when packets go through vhost example to virtio
> > device and come back to another virtio device or physical NIC, the
> > sequence of packets will be changed.
> > 
> > Reported-by: Thomas Long <thomas.long@intel.com>
> > Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
> 
> Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-02-28 21:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-19 19:18 [dpdk-dev] [PATCH] examples/vhost: fix out of sequence packets Jianfeng Tan
2016-01-20  2:47 ` Yuanhan Liu
2016-02-28 21:31   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).