DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: chas3@att.com
Cc: dev@dpdk.org, "Doherty, Declan" <declan.doherty@intel.com>,
	Radu Nicolau <radu.nicolau@intel.com>,
	stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/bonding: stop and deactivate slaves when bonding port is stopped
Date: Sun, 05 Aug 2018 23:55:45 +0200	[thread overview]
Message-ID: <11360076.HoYMhSRcrZ@xps> (raw)
In-Reply-To: <0c16cb66-6ee4-ff2d-6d16-7a3fdd021b0c@intel.com>

02/08/2018 15:38, Doherty, Declan:
> On 01/08/2018 2:18 PM, Radu Nicolau wrote:
> > When a bonding port is stopped also stop and deactivate all slaves.
> > Otherwise slaves will be still listed as active.
> > 
> > Fixes: 69bce062132b ("net/bonding: do not clear active slave count")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
> 
> Acked-by: Declan Doherty <declan.doherty@intel.com>

Waiting for opinion from the other bonding maintainer (Chas)
who started to review and has some doubts.

Chas, please do you agree with Declan's ack?

  reply	other threads:[~2018-08-05 21:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-01 13:18 Radu Nicolau
2018-08-01 13:44 ` Chas Williams
2018-08-01 14:02   ` Radu Nicolau
2018-08-02 13:38 ` Doherty, Declan
2018-08-05 21:55   ` Thomas Monjalon [this message]
2018-08-06 15:50     ` Chas Williams
2018-08-23 13:15       ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2018-08-23 15:21         ` Chas Williams
2018-08-24 10:39           ` Ferruh Yigit
2018-08-24 14:05             ` Chas Williams
2018-09-28 10:00               ` Ferruh Yigit
2018-09-28 10:03                 ` Ferruh Yigit
2018-09-28 11:04       ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11360076.HoYMhSRcrZ@xps \
    --to=thomas@monjalon.net \
    --cc=chas3@att.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=radu.nicolau@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).