From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E5074A04BC; Fri, 9 Oct 2020 09:41:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C40271BEE4; Fri, 9 Oct 2020 09:41:51 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 9BF621C114; Fri, 9 Oct 2020 09:41:48 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 4AB2679A; Fri, 9 Oct 2020 03:41:44 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 09 Oct 2020 03:41:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= 2Q4OUEZGUvpfWvvQX1MckWtB5WK9piJcPhNmiCRKW/U=; b=pXK++zcc3UX15+Wo nc2qrzqSRutSTGiRifO/sWmKikYRjSOkIfpUyPvZLeL/wZQCAEZtx+dmdRYzmBcq PG7jBNYG/1lbHHk477omYf+O7mqPlRAHuFtB+yoZhXKXl1qwSy4fOmLL63tPn0rs g7Dj4XS6lxPQeuO6eSzTMXWQAKgssh4PrR7MjNwDKAkEoV4yFI/wWrrws/gGPEPO rr5+UWb/hFnRt3uceykaayjeFzTtH95LqYEH/ySR6UbLpx8/cj4MMWCS/wNHUogr aCTQoj6Hduy9/IYQ3/KwQ41GaRsxEUF+n0dnisW7lmdZq5lp3cW5hOmNBdM54kch /qsRxg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=2Q4OUEZGUvpfWvvQX1MckWtB5WK9piJcPhNmiCRKW /U=; b=PNSQJohM9d83i4QqBD71/CN4/gRkF8YOpYKfm6j9gxP88n0dZTcvY1MCx go38sYxxku9yE53orm8IhYrjrKsfNngl5WV4M0KIb17pVz/Dt/VzJ8U/z5ceFTb/ 8KW8B/NN0bJlbKPnBGHmZI4/kuMBXNgXjY1AxCssTgkAqcUj+sMxAld/f/uniLO7 gW37f8G7tHRYR/5at5rpubE+xw3evlFhyoZf07KPckAYhiCuErIHOhB/9sHjzr+e 93WvHj1NMq4P4CU4sCWf/BISwpjH58A76dJrerQy4+1SYs3+FLl6BmDJZGB+LzhU X+NAa8SdsWJS2rRCTFocaR3JsibcQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrhedtgdduvddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 03D7F306467E; Fri, 9 Oct 2020 03:41:41 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: Harry van Haaren , dev@dpdk.org, dpdk stable , Vipin Varghese , olivier.matz@6wind.com Date: Fri, 09 Oct 2020 09:41:41 +0200 Message-ID: <11364413.axyC4qeYav@thomas> In-Reply-To: References: <20201009071554.30510-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: fix doxygen for EAL cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/10/2020 09:24, David Marchand: > > --- a/lib/librte_eal/include/rte_eal.h > > +++ b/lib/librte_eal/include/rte_eal.h > > @@ -130,8 +130,9 @@ int rte_eal_init(int argc, char **argv); > > * be made. It is expected that common usage of this function is to call it > > * just before terminating the process. > > * > > - * @return 0 Successfully released all internal EAL resources > > - * @return -EFAULT There was an error in releasing all resources. > > + * @return > > + * - 0 Successfully released all internal EAL resources. > > + * - -EFAULT There was an error in releasing all resources. > > */ > > int rte_eal_cleanup(void); > > Side note, this function has never returned anything but 0. > Is this some stale doxygen comment from the introduction of this function? > > I wonder what an application could do if the cleanup failed, anyway. > EAL will probably have error logs in such a situation? I think it's quite useful to programmatically know whether the cleanup was done properly or not. There's nothing to do except warn the user that a reboot may be needed :) Note ethdev close is returning error now.