From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 573A943B01; Mon, 12 Feb 2024 15:30:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3AF61402D9; Mon, 12 Feb 2024 15:30:29 +0100 (CET) Received: from wfhigh2-smtp.messagingengine.com (wfhigh2-smtp.messagingengine.com [64.147.123.153]) by mails.dpdk.org (Postfix) with ESMTP id 7B09E402D0; Mon, 12 Feb 2024 15:30:27 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfhigh.west.internal (Postfix) with ESMTP id 73D9D180007C; Mon, 12 Feb 2024 09:30:23 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 12 Feb 2024 09:30:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1707748222; x=1707834622; bh=5Bld5e7+VyJHRT+lOiWXr7581OciUiYz4NRuC+HtxQY=; b= DekxMXqtc29BuusUGXFIjM6rsZMxjJ/AtnSGuEmiGEI2qsUvUw3HJakNYr7L5ycx 9qFB8IMDvxN5FB/3nOF6Ltj+wwjncOmyGmjjUawREF6UxfxN5E4KyfZZyZX4JUKi 5QOVFj4/DJVWGs2iE4vXEQRRVvu9y4U2AK+rgVPdMRYG1rs3M+MBCfDUl5JPVvxx p/KahTtn3v9Xf3XvzsQK3a8P7X/ha38jUGrgoj6sg1WybfHCL0O+27YL25/BtJuE JTpP7pahurx6ZyovWc2olKzWFHFPiiO066wrv0Kok2ZQX5B9Rm70aCcwpiN/GSqZ rCbUqy4RH0IH99qFIqUopQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1707748222; x= 1707834622; bh=5Bld5e7+VyJHRT+lOiWXr7581OciUiYz4NRuC+HtxQY=; b=j cPqc6crg/C892cYepqYFXiWzNrNDqzo7umBXf+sWfoHZIG38SR3rwJp3nRXSbyTt vrUSQmQD45zk7R/pw7aqD5qg71pJqjTXkS6rk1K9MOIPE/KJ3Mdx9CAzlBb3JVYx XD1wy3A/ks8ohs8YPDyTUEkttb7DITFckBb0j97IaIxezwLiHRa85by37ITYnJAo gJ8xuO9sYSETBqMGpGdaRjLsENVjwPBS07nSad6ptfjHVj5hwXty8IgJZ20UbDSC lu0pZS80gL5pzK0bQTCrIz5G7fLOQC68q8po51SOFcOBZKDVxCRnpgEny0F4skb3 /FIyzvX0+eHCfhQiw9arQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudefgdeifecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepgedttdeljeejgeffkeekkedtjeevtdehvedtkeeivdeuuedviedu vdelveejueejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 12 Feb 2024 09:30:21 -0500 (EST) From: Thomas Monjalon To: Kumara Parameshwaran Cc: dev@dpdk.org, =?utf-8?B?6IOh5ZiJ55Gc?= , stable@dpdk.org Subject: Re: [PATCH v13] gro: fix reordering of packets in GRO layer Date: Mon, 12 Feb 2024 15:30:19 +0100 Message-ID: <11463992.MucGe3eQFb@thomas> In-Reply-To: References: <20231208181738.23931-1-kumaraparamesh92@gmail.com> <20240108160453.723207-1-kumaraparamesh92@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 16/01/2024 15:28, =E8=83=A1=E5=98=89=E7=91=9C: >=20 > =E5=9C=A8 2024/1/9 =E4=B8=8A=E5=8D=8812:04, Kumara Parameshwaran =E5=86= =99=E9=81=93: > > In the current implementation when a packet is received with > > special TCP flag(s) set, only that packet is delivered out of order. > > There could be already coalesced packets in the GRO table > > belonging to the same flow but not delivered. > > This fix makes sure that the entire segment is delivered with the > > special flag(s) set which is how the Linux GRO is also implemented > > > > Signed-off-by: Kumara Parameshwaran >=20 > Reviewed-by: Jiayu Hu Applied with Cc stable, thanks.