From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id B3EF837A8; Tue, 2 Apr 2019 02:37:53 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 387EC21ED6; Mon, 1 Apr 2019 20:37:53 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 01 Apr 2019 20:37:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=kx7rHssEADVrjjjP34na+3Fm3v2GaKBLgfTtRMI6KX8=; b=sJoAkbPLkUZg 5Ou4y4nE3EhIUy+kxMXBqut2k3owie/IStpjbXDrhGCSYEkk6vdJCMGQZ4gYReL3 4KrBauCT7sUZfpiFalmtvYXWBTGaKBpTAc+cSoqQiuIL5zM4HOknqAuGOLrEBTzb yZZise7azKjcgi7DRz6pUZo3hCV3c/0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=kx7rHssEADVrjjjP34na+3Fm3v2GaKBLgfTtRMI6K X8=; b=4IWzdMQmKD9/tCoIHbcLq/p8jxaDj3Kvquq0fGNO39myorbPaT5mIulEU g70jzvgesBoXotgv13gE033vlmlY2L+MTgtlUSbrRJLzXqFpcOjl518UTGzzMO77 H++Bk9sYp1oK4za3Dgq9IEnLisky/5iOHkWZj/S8FF9SgXOfd4cI/O1uva75zjH/ 9aRvviuik8E9xEmgyFWsZ//5/1dUVmO2zWvllLCzl4wcVtDKSj0ZgP1R1uu7hUjQ x/3r7KIDG1hen1Fc5NQU3ufwUsyJKuWucttMndS+SOtCFX+S8ybQXNfNAsxQManN 7BGRJ/zDL/nI80szOrn3iQwIMUbDw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrleehgdefhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 55BB3E46B8; Mon, 1 Apr 2019 20:37:51 -0400 (EDT) From: Thomas Monjalon To: Pallantla Poornima Cc: dev@dpdk.org, Aaron Conole , reshma.pattan@intel.com, ferruh.yigit@intel.com, bruce.richardson@intel.com, stephen@networkplumber.org, stable@dpdk.org Date: Tue, 02 Apr 2019 02:37:50 +0200 Message-ID: <11514522.tD9ysAbmMG@xps> In-Reply-To: References: <1552475243-16215-1-git-send-email-pallantlax.poornima@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] app/test: fix sprintf with strlcat X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Apr 2019 00:37:54 -0000 13/03/2019 14:51, Aaron Conole: > Pallantla Poornima writes: > > > sprintf function is not secure as it doesn't check the length of string. > > More secure function strlcat is used. > > > > Fixes: 727909c592 ("app/test: introduce dynamic commands list") > > Cc: stable@dpdk.org > > > > Signed-off-by: Pallantla Poornima > > --- > > v2: Used strlcat to avoid buffer overflow. > > --- > > LGTM. > > Reviewed-by: Aaron Conole Applied, thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 94F29A0679 for ; Tue, 2 Apr 2019 02:37:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B4CAB4CAF; Tue, 2 Apr 2019 02:37:55 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id B3EF837A8; Tue, 2 Apr 2019 02:37:53 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 387EC21ED6; Mon, 1 Apr 2019 20:37:53 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 01 Apr 2019 20:37:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=kx7rHssEADVrjjjP34na+3Fm3v2GaKBLgfTtRMI6KX8=; b=sJoAkbPLkUZg 5Ou4y4nE3EhIUy+kxMXBqut2k3owie/IStpjbXDrhGCSYEkk6vdJCMGQZ4gYReL3 4KrBauCT7sUZfpiFalmtvYXWBTGaKBpTAc+cSoqQiuIL5zM4HOknqAuGOLrEBTzb yZZise7azKjcgi7DRz6pUZo3hCV3c/0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=kx7rHssEADVrjjjP34na+3Fm3v2GaKBLgfTtRMI6K X8=; b=4IWzdMQmKD9/tCoIHbcLq/p8jxaDj3Kvquq0fGNO39myorbPaT5mIulEU g70jzvgesBoXotgv13gE033vlmlY2L+MTgtlUSbrRJLzXqFpcOjl518UTGzzMO77 H++Bk9sYp1oK4za3Dgq9IEnLisky/5iOHkWZj/S8FF9SgXOfd4cI/O1uva75zjH/ 9aRvviuik8E9xEmgyFWsZ//5/1dUVmO2zWvllLCzl4wcVtDKSj0ZgP1R1uu7hUjQ x/3r7KIDG1hen1Fc5NQU3ufwUsyJKuWucttMndS+SOtCFX+S8ybQXNfNAsxQManN 7BGRJ/zDL/nI80szOrn3iQwIMUbDw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrleehgdefhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 55BB3E46B8; Mon, 1 Apr 2019 20:37:51 -0400 (EDT) From: Thomas Monjalon To: Pallantla Poornima Cc: dev@dpdk.org, Aaron Conole , reshma.pattan@intel.com, ferruh.yigit@intel.com, bruce.richardson@intel.com, stephen@networkplumber.org, stable@dpdk.org Date: Tue, 02 Apr 2019 02:37:50 +0200 Message-ID: <11514522.tD9ysAbmMG@xps> In-Reply-To: References: <1552475243-16215-1-git-send-email-pallantlax.poornima@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] app/test: fix sprintf with strlcat X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190402003750.EuFTHKhBnogAJGEeLoxIhkP7fDZFkFQPCQm5d-9jDs8@z> 13/03/2019 14:51, Aaron Conole: > Pallantla Poornima writes: > > > sprintf function is not secure as it doesn't check the length of string. > > More secure function strlcat is used. > > > > Fixes: 727909c592 ("app/test: introduce dynamic commands list") > > Cc: stable@dpdk.org > > > > Signed-off-by: Pallantla Poornima > > --- > > v2: Used strlcat to avoid buffer overflow. > > --- > > LGTM. > > Reviewed-by: Aaron Conole Applied, thanks