From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 276BCC3DC for ; Fri, 19 Feb 2016 15:35:52 +0100 (CET) Received: by mail-wm0-f54.google.com with SMTP id g62so79267140wme.1 for ; Fri, 19 Feb 2016 06:35:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=pqoOgjq+uba6qRF36aY21bRGcjOn247OGt+xuuLE6IU=; b=z/ozmVE9RmpERqsnJO3N1t58gK+6mAgFfHYFAuzxdoKtu97F65ww63CgV/jDynKwm4 YpTGxFvs3JpBf9LTjfj7b1gs9pI+Fg5uI773fvvUaZqqO1lz3FExWiB2q8e8WKH6U/CN T+4RAJC5UGdrI8CJXzcYA0mlQd7ZltYkAnRKXDSUihT8F2+rxy/YJg/dgtnLsamGlP6f Po/lv73hOzdX6TpUI8920AX9eddHcs5RnrxPECbjvE0f/v793tvYEQWbpxHVtlHshjiJ X2qK5n0KWHdvcQZhxpYf460fMhLkbOb+ijMKFqQoZNsU9gnDRD5lkDP6IIEq4Nffbayh ilQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=pqoOgjq+uba6qRF36aY21bRGcjOn247OGt+xuuLE6IU=; b=LcO1spXgoLkSUI19G47Hzp8vIdfxuVWAbZ4KHZvkdnUUs9UY/d4qlQhM+VvrXh8Z1r qoSmFr0ezQKZ2BFEK+5nPVvmBSa/RZqQWXL6AAetGtoO8hkeWfDDxlUtMboUmIh2wTb/ c4HuYCwsRS+qaq/uv3POMgxoHV5vZXSF61yfDG74yPtoAgSNaCdL88OYO95xvoxQWmXS s79AZYljau6qUYC54EsLGhUUOcrQZV8XU9u/u5YHzEbGzBsZdo51uK/sOuuviwf3DTZO iSr/+C/VbTa3jTHhqE3HRElwkSJCSJ0k6p7zITcrZJo0b54kft9ZOEaVEHv11QFp2KB8 1hgg== X-Gm-Message-State: AG10YOSfVam9X3bejQryLnk9vGTHf9+5rX2/12FfRMXcVZeaJYigF8f/qLvGg0dTXxWnW8Wz X-Received: by 10.28.140.85 with SMTP id o82mr10249938wmd.0.1455892090534; Fri, 19 Feb 2016 06:28:10 -0800 (PST) Received: from xps13.localnet (111.204.154.77.rev.sfr.net. [77.154.204.111]) by smtp.gmail.com with ESMTPSA id y3sm7888858wmy.17.2016.02.19.06.28.09 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 19 Feb 2016 06:28:09 -0800 (PST) From: Thomas Monjalon To: Yuanhan Liu Date: Fri, 19 Feb 2016 15:26:36 +0100 Message-ID: <11566175.eoXr2zdVvr@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1454043483-24579-3-git-send-email-yuanhan.liu@linux.intel.com> References: <1450321921-27799-1-git-send-email-yuanhan.liu@linux.intel.com> <1454043483-24579-1-git-send-email-yuanhan.liu@linux.intel.com> <1454043483-24579-3-git-send-email-yuanhan.liu@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, Victor Kaplansky , "Michael S. Tsirkin" Subject: Re: [dpdk-dev] [PATCH v3 2/8] vhost: introduce vhost_log_write X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2016 14:35:52 -0000 2016-01-29 12:57, Yuanhan Liu: > Introduce vhost_log_write() helper function to log the dirty pages we > touched. Page size is harded code to 4096 (VHOST_LOG_PAGE), and each > log is presented by 1 bit. > > Therefore, vhost_log_write() simply finds the right bit for related > page we are gonna change, and set it to 1. dev->log_base denotes the > start of the dirty page bitmap. > > Signed-off-by: Yuanhan Liu > Signed-off-by: Victor Kaplansky > Tested-by: Pavel Fedin [...] > +static inline void __attribute__((always_inline)) > +vhost_log_write(struct virtio_net *dev, uint64_t addr, uint64_t len) lib/librte_vhost/vhost_rxtx.c:59:1: error: unused function 'vhost_log_write' I think it's better to squash with the next patch.