From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 4C0E2A0C47;
	Tue, 12 Oct 2021 18:12:28 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 2977D410E0;
	Tue, 12 Oct 2021 18:12:28 +0200 (CEST)
Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com
 [66.111.4.221]) by mails.dpdk.org (Postfix) with ESMTP id 74E3340E50
 for <dev@dpdk.org>; Tue, 12 Oct 2021 18:12:27 +0200 (CEST)
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43])
 by mailnew.nyi.internal (Postfix) with ESMTP id 239CA580285;
 Tue, 12 Oct 2021 12:12:27 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute3.internal (MEProxy); Tue, 12 Oct 2021 12:12:27 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=fm2; bh=
 S3T+x4HbpsMTwyVnjSFjqmjk0KCWmqqUke8zW1dUVxk=; b=jamoa/RfmU7+co4W
 N4h1ZgOmJRa+QyJ6jYTLj09+pIGcuK/nrjWmE65KqQrnfqYyGfexOYwblLnIrkh1
 0MPRh7tOT217//T+0O07BwcqXAAxgGjHYZ+ywPH4Y7aOMcvXQnxqVGjXFHi1Ctce
 kjks25kIay2n5iDIK51mf6AmOiE7EY8MXZWtkDJ9G58BHW9+9ScM79mv4owvsHnM
 nxNuzVSQkkfVj/6TeZjIMcp9ByHgJsAqhlFlGmAj7efHZxUyczqC04FP9PM5Gx/u
 XqMmmbFhm6Qo9SHctB1xsCnvhAMDFp2bzpuoE4bCGt2zHldjgY0pRall8b7B3qNH
 f14D9A==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=S3T+x4HbpsMTwyVnjSFjqmjk0KCWmqqUke8zW1dUV
 xk=; b=FxK/83w1XK1QDVOiVbngBjAxE/yh2D9ar5aB38mEaLCJ1i4Vb4noAZb41
 TcHi9hThfY5Pz2O9UY6kDpRpPWk9CNA662jbsHk66gNQ4KTi+7I3xrjQL5qYxzPj
 jLNE+GKd7JkdXWQahDY2dwnUwY01On417IDYZJmRoyHha9W5nGv8XoUL/B/LndJ5
 JllOzoAuyT5qBvqL/yMyrzCo6ZQguG7X/RMF81aDniccFPIMWqkfEfWeWSX5S41A
 9ffBY67Gtzr2pt0u4j9mW7NkCyAMTIy54Hf20Yjq3ErHBuKA+kF1l32HbvIHhJyu
 2khmDesJdUmk8/f84foA5ChB2lJyw==
X-ME-Sender: <xms:6rNlYX6m0Ek1PhQQbX3-N57CoameApeMC3RM-FXM3URcz1XaDB-g2A>
 <xme:6rNlYc4ziutWynWOmOpin-2mEy_W5ORmx9YRKy4aZp53mwYwo7AjtR6-_--fDvcI2
 nXWyyMp3BAKWQLuqw>
X-ME-Received: <xmr:6rNlYed6q9FaOvbtb1aTQQZomr2IfCnc8ZsHSHhot0-hduHvrm4BLo48mgO3MYWCv1z8GisO_p1yjjYtAVSfn_AX8_9isHfsDak8Mn5R>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddtkedgleegucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
 shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
 ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu
 ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh
 homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth
X-ME-Proxy: <xmx:6rNlYYJKRjrHDrrM2wUVEzyzEtqswihDAGmy-b9nLo3jaO_OExq1Hw>
 <xmx:6rNlYbJJ-p4wiSPXA9WVen2jmE3x3HmTbA4t0mz1hch4PmzMPuGeug>
 <xmx:6rNlYRzpxVt6QXzTyWa5IDC_cy0s7RGnWqd9PP_qQHeCaA35GC0_Gg>
 <xmx:67NlYcUPa_gxNy7pIubZa3SP45X-YZddGBzAcFwjYjsz2M8vJYdbKQ>
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
 12 Oct 2021 12:12:23 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>
Cc: dev@dpdk.org, dmitry.kozliuk@gmail.com, khot@microsoft.com,
 dmitrym@microsoft.com, roretzla@microsoft.com, talshn@nvidia.com,
 ocardona@microsoft.com, bruce.richardson@intel.com, david.marchand@redhat.com,
 pallavi.kadam@intel.com
Date: Tue, 12 Oct 2021 18:12:21 +0200
Message-ID: <11591275.oo6G3FHbOz@thomas>
In-Reply-To: <1633765318-28356-3-git-send-email-navasile@linux.microsoft.com>
References: <1633732841-17873-1-git-send-email-navasile@linux.microsoft.com>
 <1633765318-28356-1-git-send-email-navasile@linux.microsoft.com>
 <1633765318-28356-3-git-send-email-navasile@linux.microsoft.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v16 2/9] eal: add thread attributes
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

09/10/2021 09:41, Narcisa Ana Maria Vasile:
> From: Narcisa Vasile <navasile@microsoft.com>
> 
> Implement thread attributes for:
> * thread affinity
> * thread priority
> Implement functions for managing thread attributes.
> 
> Priority is represented through an enum that allows for two levels:
> 	- RTE_THREAD_PRIORITY_NORMAL
> 	- RTE_THREAD_PRIORITY_REALTIME_CRITICAL

It doesn't say how do you translate these priorites in POSIX and win32.

> Affinity is described by the rte_cpuset_t type.
> 
> An rte_thread_attr_t object can be set to the default values
> by calling rte_thread_attr_init().
> 
> Signed-off-by: Narcisa Vasile <navasile@microsoft.com>
[...]
>  lib/eal/common/rte_thread.c  | 46 ++++++++++++++++++
>  lib/eal/windows/rte_thread.c | 44 +++++++++++++++++

These 2 files look like code duplication.