From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f46.google.com (mail-wg0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id BCB4B7E62 for ; Fri, 24 Oct 2014 11:39:41 +0200 (CEST) Received: by mail-wg0-f46.google.com with SMTP id l18so704757wgh.5 for ; Fri, 24 Oct 2014 02:48:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=KxBNXIR8q2+45L5qK+ceJvK0obs6taQ/wkLDSG3+Ces=; b=NyTBO7b6ZXBkU8vyffsttDqBFZGEE1dPfRG9t7Wb1h7N8oSlVv8fyebGyFTPqpqm/D 1NBcSi6avGx3PQIJXIskkk6ZBVczEoHTYui3Cy5T40HNQ/hWmpmtS3fcNCGuSxxS/tDZ 0+79diEtmGN4+obTR51vtzIzkR5NOZ0rvBl8iyVhjaoNmOxbCSh98ZEXMgV3g8iB/9xL m56xF/e3WvKpD7q+11hF1n7hBTynW5uteyJU4x/CDcFs4Fs9lXofNg2f5F0occB85WQh s2ueAXxhT7GN725ZaUDr5ZcVnQTHKnl0JvDgN0vHnYFLgcV+g8RyibQejUlZSLVG18l+ y2cg== X-Gm-Message-State: ALoCoQkY4Amj5iY4KGiXwcUdeqjhPUYMqNg1eYEXGe6HnLgNl1Q753Zy6pn2i87LbBIa9ysoZePb X-Received: by 10.180.104.199 with SMTP id gg7mr2884027wib.41.1414144090450; Fri, 24 Oct 2014 02:48:10 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id kw2sm5017729wjb.34.2014.10.24.02.48.09 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Oct 2014 02:48:09 -0700 (PDT) From: Thomas Monjalon To: Ouyang Changchun Date: Fri, 24 Oct 2014 11:47:46 +0200 Message-ID: <11605757.Du0pTjUQ40@xps13> Organization: 6WIND User-Agent: KMail/4.14.2 (Linux/3.16.4-1-ARCH; KDE/4.14.2; x86_64; ; ) In-Reply-To: <1414138209-24431-1-git-send-email-changchun.ouyang@intel.com> References: <1414138209-24431-1-git-send-email-changchun.ouyang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 0/3] Vhost app removes dependency of REFCNT X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Oct 2014 09:39:41 -0000 2014-10-24 16:10, Ouyang Changchun: > To remove the dependency of RTE_MBUF_REFCNT for vhost zero copy, > the mbuf need introduce EXTERNAL_MBUF(in ol_flags) to indicate it > attaches to an external buffer, say, from guest space. And don't > free the external buffer when freeing the mbuf itself in host, in > addition, RX function in PMD need make sure not overwrite this flag > when filling ol_flags from descriptors to mbuf. So you are replacing refcnt by something else which requires special handling in drivers. I feel this is not the right design. Why do you want to remove refcnt dependency? -- Thomas