From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, Luca Boccassi <bluca@debian.org>
Subject: Re: [dpdk-dev] [PATCH] build: add unused parameter warnings to meson build
Date: Tue, 04 Jun 2019 00:07:00 +0200 [thread overview]
Message-ID: <11646740.uuxpLcOtf9@xps> (raw)
In-Reply-To: <9f4ab8070d3ac32ada2f52f160d9b1a983276c71.camel@debian.org>
15/05/2019 16:39, Luca Boccassi:
> On Wed, 2019-05-15 at 12:38 +0100, Bruce Richardson wrote:
> > To improve code quality we want to turn on as many warnings as we can
> > in
> > the DPDK code, so turn on the "unused-parameter" warning in meson
> > builds to
> > match that of the make builds. To ensure correct compilation, disable
> > the
> > warning selectively for driver base code that otherwise would have
> > issues.
> >
> > Signed-off-by: Bruce Richardson <
> > bruce.richardson@intel.com
>
> Acked-by: Luca Boccassi <bluca@debian.org>
Applied, thanks
prev parent reply other threads:[~2019-06-03 22:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 11:38 Bruce Richardson
2019-05-15 11:38 ` Bruce Richardson
2019-05-15 14:39 ` Luca Boccassi
2019-05-15 14:39 ` Luca Boccassi
2019-06-03 22:07 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11646740.uuxpLcOtf9@xps \
--to=thomas@monjalon.net \
--cc=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).