From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 9676AA0C41;
Tue, 11 May 2021 09:36:51 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 1BE0E40140;
Tue, 11 May 2021 09:36:51 +0200 (CEST)
Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com
[64.147.123.25]) by mails.dpdk.org (Postfix) with ESMTP id 79DDB4003E
for <dev@dpdk.org>; Tue, 11 May 2021 09:36:50 +0200 (CEST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
by mailout.west.internal (Postfix) with ESMTP id C8F98CC3;
Tue, 11 May 2021 03:36:47 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute2.internal (MEProxy); Tue, 11 May 2021 03:36:48 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=fm1; bh=
+/2YJZEpv5uDrRgbwFgPD958T6GVc6pGx/523mtupj8=; b=nEmhKEX0dKFOolTW
WHA8H6snrv7FdGU6dwF7d6G0f2qfC/3UFmMYsgB+kbAJU9WzbVBglKXvu7ANbFgJ
Jg5QgnpgoU2m6d4wLLNL+YGhzcxPtLyqPL55OtLXHjxgOOOsBUjxsOVFSIhmtcr/
u5GOd2FXxyx6X7QqPd3V9yEyPZ5tTWR54cvizncG7KOUXPYbOOG5sQbEQAJ17HsS
i6OIG7rP9QO+sK6sV5OUssD9SmHceqQRS+WLkUc0tYJpnU2FCbnTu8aeLHaNauT+
oZv9oVsK9STQG203YNXJyqfoGF4FNYJcjlHr7bM0VqCpbwmMOja87Doc3Y8cYZY/
HCsq0A==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm2; bh=+/2YJZEpv5uDrRgbwFgPD958T6GVc6pGx/523mtup
j8=; b=eWNwzoeljbQ7/6fz5VNNwk6fz6XkpDIPS/V72y51uLD1GbdN+FvA7TkY6
qcOlcbDTV5LHvQTtS61a+Wx8Vjkwmnp9n5eK1AvrHOGPmzLnjoGfRszuYCi7iaj+
yFbRaHLIpMAMB/01TTQ++x7hhW8xIVnxUDTIghciRGs8a6Z6wIx9K4dhhvJ4kidw
QvEt2hvC1fXKyi6X083/JpBKNDmSc1I4N5lx62WdT7SwwKI3ECDS2k+f2cMIqDVh
IZPu+XILQAdzSBtnixNMrzagD2HhM2JTvXMQnNrDt0DeUY97YyI5FtlOGvY8OZsn
S+DoudYBRXfl6hkjNphoQJfy/iPaA==
X-ME-Sender: <xms:DjSaYN3iIF0AKtLZmVQt5bz-ZRfkE4LXBHWI1TN2pwsj85TrO-afqw>
<xme:DjSaYEFChURhOLKjiJU6M90R5X-zx8SerMY3HeAbG-Vm79fU7JcZWDosbrgrnNztM
TT3Kb-CPINFvTFfRA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdegledguddvvdcutefuodetggdotefrod
ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
enucfjughrpefhvffufffkjghfggfgtgesthhqredttddtudenucfhrhhomhepvfhhohhm
rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc
ggtffrrghtthgvrhhnpeefgeffiefhfeettdfhvdfgteekffffudekvedtvedtvdfgveeu
udevgedvgeegtdenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh
fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr
lhhonhdrnhgvth
X-ME-Proxy: <xmx:DjSaYN7zj0-ngZBGNwn2smm6wrS66E4sPo7ICwm_TnF7r6WJo7bz6g>
<xmx:DjSaYK217841DExu_pjBlUx_3sjxic-6gQ4mT0nV7y-43pku7yEEfw>
<xmx:DjSaYAGNCTcp_UZq1ioMm9pcOcBCKQiaOW0VcB-ah3RbbDtEAjB6sQ>
<xmx:DzSaYMh8RPEc7uSXWhRQOTb0mfA3he5Oh-avqMUJQlBw4w90QmfGvA>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA;
Tue, 11 May 2021 03:36:45 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Chengwen Feng <fengchengwen@huawei.com>
Cc: ferruh.yigit@intel.com, mb@smartsharesystems.com, skori@marvell.com,
jerinj@marvell.com, dev@dpdk.org, linuxarm@openeuler.org
Date: Tue, 11 May 2021 09:36:43 +0200
Message-ID: <11662132.FWA8Suj1gP@thomas>
In-Reply-To: <1620186231-35245-1-git-send-email-fengchengwen@huawei.com>
References: <1619662241-61955-1-git-send-email-humin29@huawei.com>
<1620186231-35245-1-git-send-email-fengchengwen@huawei.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Subject: Re: [dpdk-dev] [PATCH v3] eal: fix use wrong time API
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
05/05/2021 05:43, Chengwen Feng:
> Currently, the mp uses gettimeofday() API to get the time, and used as
> timeout parameter.
>=20
> But the time which gets from gettimeofday() API isn't monotonically
> increasing. The process may fail if the system time is changed.
>=20
> This fixes it by using clock_gettime() API with monotonic attribution.
>=20
> Fixes: 783b6e54971d ("eal: add synchronous multi-process communication")
> Fixes: f05e26051c15 ("eal: add IPC asynchronous request")
> Cc: stable@dpdk.org
>=20
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> Acked-by: Morten Br=F8rup <mb@smartsharesystems.com>
> ---
> v3:
> * add acked-by.
> * change patch's author.
I did some comments on v2 about potential errors to catch,
but you sent this v3 without participating in v2 discussion.