Re: [dpdk-dev] [PATCH 1/2] test/mempool_perf: Free mempool on exit

[santosh <santosh.shukla@caviumnetworks.com>]

Hi Shreyansh,

On Wednesday 05 April 2017 03:27 PM, Shreyansh Jain wrote:

> Hello Santosh,
> On Wednesday 05 April 2017 02:21 PM, Santosh Shukla wrote:
>> Mempool_perf test not freeing pool memory.
>> Cc: stable@dpdk.org
>> Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
>> ---
>>  test/test/test_mempool_perf.c |   31 +++++++++++++++++++------------
>>  1 file changed, 19 insertions(+), 12 deletions(-)
>> diff --git a/test/test/test_mempool_perf.c b/test/test/test_mempool_perf.c
>> index ebf1721..3c45971 100644
>> --- a/test/test/test_mempool_perf.c
>> +++ b/test/test/test_mempool_perf.c
>> @@ -312,6 +312,8 @@ struct mempool_test_stats {
>>  static int
>>  test_mempool_perf(void)
>>  {
>> +    int ret = -1;
>> +
>>      rte_atomic32_init(&synchro);
>>      /* create a mempool (without cache) */
>> @@ -322,7 +324,7 @@ struct mempool_test_stats {
> Can you check why the patch is showing "struct mempool_test_stats" as
> the context?
> I tried creating this patch and it shows "test_mempool_perf(void)" as
> context.
> off the topic, does it matter to maintainers if context is not correct?
> t

That was because of older git-version i.e. < 2.x.

I upgraded to 2.11.0 and applied same patch then did 'git show' shows
correct context.

So in short; Posted patch won't break anything. if end user has
git version < 2.x then he'll see disparity in patch context however
> 2.x won't.

In anycase I will post v2. Thanks for pointing out.

diff --git a/test/test/test_mempool_perf.c b/test/test/test_mempool_perf.c
index ebf1721ac..3c45971ab 100644
--- a/test/test/test_mempool_perf.c
+++ b/test/test/test_mempool_perf.c
@@ -312,6 +312,8 @@ do_one_mempool_test(unsigned cores)
 static int
 test_mempool_perf(void)
 {
+       int ret = -1;
+
        rte_atomic32_init(&synchro);
 
        /* create a mempool (without cache) */
@@ -322,7 +324,7 @@ test_mempool_perf(void)
                                                my_obj_init, NULL,
                                                SOCKET_ID_ANY, 0);
        if (mp_nocache == NULL)
-               return -1;
+               goto err;

[...]

> Other than that:
> Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>

Thanks!,

>