From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id EE017A04DC;
	Sat, 31 Oct 2020 22:09:48 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 6C4A9558E;
	Sat, 31 Oct 2020 22:09:46 +0100 (CET)
Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com
 [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id E3BB154AE
 for <dev@dpdk.org>; Sat, 31 Oct 2020 22:09:44 +0100 (CET)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
 by mailout.west.internal (Postfix) with ESMTP id 44A456AB;
 Sat, 31 Oct 2020 17:09:42 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute2.internal (MEProxy); Sat, 31 Oct 2020 17:09:42 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=fm2; bh=
 LsI1qGm7ddFYjWB10a96nbfxe/g8eflhmjTiIJ5fwto=; b=eqhMfoXDg+4IynfF
 EJ6AdZw1bIAuDt4KnQfPWle7g/5KtKkW9FQ0MxUGoHb2e0BnIXbFU8mKuQsO54Z3
 aTIq94vovOcgTq80pDkBOIwgx35Mu3wcmle7XTB4vSuaBKO1B+y4hiLeTgKe8ZU4
 T8tM9rCdk+GEi9Pyz/q+cdt1up+EiPJFy6JQ0jflqbPsYHKeTdPyLq2QJOttG5+H
 rTD4bKZDYIX8I+aGJNdx/vgRqvmXUXBIKBmHHj4SGy9i7YvAa9YEVN8VsqzSWqUf
 sesT5i+s1luhYz/66f4QspUhxC49Srh0F6pwjYZDqMWZDvvKNFIxeY0u9tcPB9hU
 AwAcwg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=LsI1qGm7ddFYjWB10a96nbfxe/g8eflhmjTiIJ5fw
 to=; b=YMvbc0oK1m2rQyRpuobfPz3rCsfHAzlH8/amk9bZmLl9kzMYpcERnNnqz
 SaD98tb2uA91GOOqRiTCOk5Okg15Be5x6tQwVh9sp/pkXwzKnjZqhokHi1tZaYeX
 ZsK/bSJAFwmL4iEH8nAYurCAwKnHIkpQrLK97lF78S1sirZ1u+Lq6DIsYYy+BW3R
 qUdTeY7jpXsND7dkFBvSSuFz5QrvXh0Dql2mfC7+BJnhfKJvJy3MJsTQSWM7x6Fg
 ozllbIvz29WULpf82UvT5sbqKaWrU5FpUWauCit3EuHI35f9jXRIJDQD7i0b5he6
 Ujknu0g3/fG7tzYgDdKWeRz55w05g==
X-ME-Sender: <xms:ldKdX3H3qCfCbTSRkBZRP_y-M4ss62kLJE4NMkjGXF9HtCqJjnC_Bg>
 <xme:ldKdX0X9YhPgqiHVJ-KTkLw14_7DbhxyvMLtvpnAVzanqeNSuq_8fLBanBi3Urhs3
 kTXJKW3IcC0WZD5AA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrleejgddugeeiucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
 shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
 ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu
 ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf
 hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl
 ohhnrdhnvght
X-ME-Proxy: <xmx:ldKdX5IsrnkeyJFD0LiPa6cM5LCbrgKwzsp7Cb1BNrHGS08RIC7sdw>
 <xmx:ldKdX1GSr0KUDGx6ZGD2bTYxH1K2o1ZuJoRu7Cd1Vnq3AhdLF7wtTw>
 <xmx:ldKdX9XWJX-tMPA6CNNA1UzJi9tGKNK81zgdZjDOhT09o2UoF4tqSA>
 <xmx:ldKdXwQWN5n3wRJ2qCra5jcF_SOZvewewomLxfmMYYHL4MJmuhZibQ>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 5B5973280059;
 Sat, 31 Oct 2020 17:09:40 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
 Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>,
 Olivier Matz <olivier.matz@6wind.com>
Date: Sat, 31 Oct 2020 22:09:37 +0100
Message-ID: <11710466.Nu2QobosFU@thomas>
In-Reply-To: <20201028122013.31104-10-david.marchand@redhat.com>
References: <20201027221343.28551-1-david.marchand@redhat.com>
 <20201028122013.31104-1-david.marchand@redhat.com>
 <20201028122013.31104-10-david.marchand@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2 9/9] mbuf: remove seqn field
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

28/10/2020 13:20, David Marchand:
> As announced in the deprecation note, the field seqn is removed to give
> more space to the dynamic fields.
> 
> This is how the mbuf layout looks like (pahole-style):
> 
> word  type                              name                byte  size
>  0    void *                            buf_addr;         /*   0 +  8 */
>  1    rte_iova_t                        buf_iova          /*   8 +  8 */
>       /* --- RTE_MARKER64               rearm_data;                   */
>  2    uint16_t                          data_off;         /*  16 +  2 */
>       uint16_t                          refcnt;           /*  18 +  2 */
>       uint16_t                          nb_segs;          /*  20 +  2 */
>       uint16_t                          port;             /*  22 +  2 */
>  3    uint64_t                          ol_flags;         /*  24 +  8 */
>       /* --- RTE_MARKER                 rx_descriptor_fields1;        */
>  4    uint32_t             union        packet_type;      /*  32 +  4 */
>       uint32_t                          pkt_len;          /*  36 +  4 */
>  5    uint16_t                          data_len;         /*  40 +  2 */
>       uint16_t                          vlan_tci;         /*  42 +  2 */
>  5.5  uint64_t             union        hash;             /*  44 +  8 */
>  6.5  uint16_t                          vlan_tci_outer;   /*  52 +  2 */
>       uint16_t                          buf_len;          /*  54 +  2 */
>  7    uint64_t                          timestamp;        /*  56 +  8 */
>       /* --- RTE_MARKER                 cacheline1;                   */
>  8    struct rte_mempool *              pool;             /*  64 +  8 */
>  9    struct rte_mbuf *                 next;             /*  72 +  8 */
> 10    uint64_t             union        tx_offload;       /*  80 +  8 */
> 11    struct rte_mbuf_ext_shared_info * shinfo;           /*  88 +  8 */
> 12    uint16_t                          priv_size;        /*  96 +  2 */
>       uint16_t                          timesync;         /*  98 +  2 */
> 12.5  uint32_t                          dynfield1[7];     /* 100 + 28 */
> 16    /* --- END                                             128      */
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>

Acked-by: Thomas Monjalon <thomas@monjalon.net>