From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B149FA0C4A; Thu, 8 Jul 2021 12:28:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 706C34069C; Thu, 8 Jul 2021 12:28:32 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 4F47440696 for ; Thu, 8 Jul 2021 12:28:31 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id E43D55C0135; Thu, 8 Jul 2021 06:28:28 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Thu, 08 Jul 2021 06:28:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= Gu1k88KT1KX/494QjLC7icThTK8HtWypkUQpoOF4j74=; b=dV7ImedRg3jlQMl1 +m4WtkAdtVWbbJHv4UOYRFw4BBQVwrVTEzd0aVpBwkJlhO2Y8Y0ra+kQ3vUOD4/n MD+0cPDV8XQA7BEUXWchn8klsDza25M25SqEhDnXl51EMc2m1iJHQfGO7f9sb0ax AeFlfcKmRPb8KaGCTYEIxZO3W8TkqaIjMA3grxp3wzg+751MuDGb46HEHFtbkoNG RvXo1olclKdo94ZnEJfYO0pcs3pf42v6hf2ujdIpcTY3y6nLlg9m8lcqw23QM7qg +Rh4KMCI8MQoCiIdEhRrb1JmOUbT6ytO7UNGEmGeOkH1rEgmnV2M8JqqB5HODBUm jeauCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=Gu1k88KT1KX/494QjLC7icThTK8HtWypkUQpoOF4j 74=; b=Tw5zd0vOaPg/+3QgnBEap4dDAboMVbkkFjMqe1s1jVrF3gBl5Hz8enXE9 19cRUaTAkHqqrIGdIySZirMVsBX0XlDiZE061dOyMhxtMCfKFvD/kRkxnZknlDt7 TNhlCBiWn4GC9Y32wC5O3RYr4NPfswPAHi0IG7ntKMqEmybphBssj2xbbrYvzoT5 gMAgAITm+33Jc09hemFFNZczeU/9+bA+c48FjURwG8uqtEvX+ysdrQbdfvOyE0r1 E70T/gpLWYTxC6jq10Y1j2vAX0RLBnL9a7Pkojg6LELgLqnqcKTF1S3j1vbZcFY0 AzAWwoxqkK3Ig7dBlDqVGZuICfLEA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrtdeggddvjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 8 Jul 2021 06:28:27 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob , Ruifeng Wang Cc: Bruce Richardson , Jan Viktorin , "jerinj@marvell.com" , "dev@dpdk.org" , "david.marchand@redhat.com" , nd , Honnappa Nagarahalli , nd Date: Thu, 08 Jul 2021 12:28:25 +0200 Message-ID: <11782720.2BaofqzToz@thomas> In-Reply-To: References: <20200424070741.16619-1-gavin.hu@arm.com> <4337273.iQpEcjLWDA@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 3/3] build: add option to enable wait until equal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/07/2021 11:21, Ruifeng Wang: > From: Thomas Monjalon > > 08/07/2021 08:32, Jerin Jacob: > > > On Thu, Jul 8, 2021 at 11:55 AM Ruifeng Wang > > wrote: > > > > From: Jerin Jacob > > > > > On Wed, Jul 7, 2021 at 5:57 PM Bruce Richardson > > > > > wrote: > > > > > > On Wed, Jul 07, 2021 at 06:46:33AM +0000, Ruifeng Wang wrote: > > > > > > > From: Thomas Monjalon > > > > > > > > 07/07/2021 07:48, Ruifeng Wang: > > > > > > > > > Introduce a meson option 'use_wfe' to select wait until equal > > method. > > > > > > > > > The default is disable. Traditional polling loop is used. > > > > > > > > > When enabled, architecture specific mechanism is relied on > > > > > > > > > to do the wait. > > > > > > > > > > > > > > > > Why do we need an option? > > > > > > > > Can it be automatic to enable it when supported? > > > > > > > > > > > > > > > The problem is inconsistency in performance on different Arm > > platforms. > > > > > We had decided that each platform needs to enable it after some > > testing. > > > > > > > > > > > > > Can that not be done via variables in the cross-file for the > > > > > > builds, or via automatic detection if it's a native build? Is it > > > > > > likely that individual users of DPDK will be knowledgable enough > > > > > > to use this option > > > > > correctly? > > > > > > > > > > +1 to add this in cross-file instead of the top of config option > > > > > +as > > > > > scope if is only for arm64 builds. > > > > > > > > Currently this option is in config/arm/meson.build (flags_common). > > > > SoCs can build with this option enabled/disabled. And the ability is > > > > available for both native build and cross build as cross build also goes > > through meson.build. > > > > If a SoC needs to enable the option by default, an entry and be added to > > the SoC flags. > > > > > > > > The key difference here is whether this option need to be exposed to > > the top level config. > > > > > > In the view of limiting top-level config options and it is specific to > > > Arm, I think, it better to be a cross file only option. > > > > +1, sorry for the late notice. > > I would advocate to take this patch in 21.08-rc2. > > > If the decision is not to expose this option in top-level config, we can just drop 3/3 patch. > Do I need to send a new version? No it looks not needed to send a new version, I can take patches 1 & 2.