From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3ED57A09E4; Fri, 29 Jan 2021 02:14:04 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9F70D4067E; Fri, 29 Jan 2021 02:14:03 +0100 (CET) Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) by mails.dpdk.org (Postfix) with ESMTP id 843664067B for ; Fri, 29 Jan 2021 02:14:02 +0100 (CET) Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4DRfTm6dqpzjDkD; Fri, 29 Jan 2021 09:13:00 +0800 (CST) Received: from [10.67.103.119] (10.67.103.119) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.498.0; Fri, 29 Jan 2021 09:13:59 +0800 To: Thomas Monjalon CC: , , , References: <1611150232-609-1-git-send-email-oulijun@huawei.com> <1611837805-42429-1-git-send-email-oulijun@huawei.com> <1611837805-42429-3-git-send-email-oulijun@huawei.com> <2843903.C3Glkg52S3@thomas> From: oulijun Message-ID: <117895e7-b00b-4f72-05ee-ced0d62d2aae@huawei.com> Date: Fri, 29 Jan 2021 09:13:59 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <2843903.C3Glkg52S3@thomas> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.119] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v2 2/5] net/hns3: add FEC feature for hns3.ini X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" ÔÚ 2021/1/28 22:12, Thomas Monjalon дµÀ: > 28/01/2021 13:43, Lijun Ou: >> The hns3 PMD add FEC features implementation in 20.11. >> Therefore, need to update the hns3.ini for supporting. >> >> Fixes: 9bf2ea8dbc65 ("net/hns3: support FEC") >> Cc: stable@dpdk.org >> >> Signed-off-by: Lijun Ou >> --- >> doc/guides/nics/features/hns3.ini | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/doc/guides/nics/features/hns3.ini b/doc/guides/nics/features/hns3.ini >> index a467396..4ea568c 100644 >> --- a/doc/guides/nics/features/hns3.ini >> +++ b/doc/guides/nics/features/hns3.ini >> @@ -39,5 +39,6 @@ Stats per queue = Y >> FW version = Y >> Registers dump = Y >> Multiprocess aware = Y >> +FEC = Y > > Please don't use tabs but only spaces in such .ini file. > OK£¬ I will fix it > Can it be squashed with the commit adding the feature in default.ini? Do you think patch[1/5] is merged into one ? I took ferruh.yigit's advice. > > > > . >