[dpdk-dev] [PATCH v2] usertools: update to usertool for baseband device

[dpdk-dev] [PATCH v2] usertools: update to usertool for baseband device

[Nicolas Chautru]

Purely minor script change to support the BBDEV devices
An FPGA BBDEV PMD is being pushed in parallel but this patch can 
be pushed independently from CI point of view.

This was pushed earlier as a v1 in previous patchset
https://patches.dpdk.org/project/dpdk/list/?series=4657

Nicolas Chautru (1):
  usertools: update to usertool for baseband device

 usertools/dpdk-devbind.py | 10 +++++++++-
 usertools/dpdk-setup.sh   |  6 +++---
 2 files changed, 12 insertions(+), 4 deletions(-)

-- 
1.8.3.1

[dpdk-dev] [PATCH v2] usertools: update to usertool for baseband device

[Nicolas Chautru]

Allows binding of baseband devices

Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
---
 usertools/dpdk-devbind.py | 10 +++++++++-
 usertools/dpdk-setup.sh   |  6 +++---
 2 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
index 9e79f0d..a6ee8f9 100755
--- a/usertools/dpdk-devbind.py
+++ b/usertools/dpdk-devbind.py
@@ -18,6 +18,8 @@
                    'SVendor': None, 'SDevice': None}
 intel_processor_class = {'Class': '0b', 'Vendor': '8086', 'Device': None,
                    'SVendor': None, 'SDevice': None}
+acceleration_class = {'Class': '12', 'Vendor': None, 'Device': None,
+               'SVendor': None, 'SDevice': None}
 cavium_sso = {'Class': '08', 'Vendor': '177d', 'Device': 'a04b,a04d',
               'SVendor': None, 'SDevice': None}
 cavium_fpa = {'Class': '08', 'Vendor': '177d', 'Device': 'a053',
@@ -40,6 +42,7 @@
 crypto_devices = [encryption_class, intel_processor_class]
 eventdev_devices = [cavium_sso, cavium_tim, octeontx2_sso]
 mempool_devices = [cavium_fpa, octeontx2_npa]
+baseband_devices = [acceleration_class]
 compress_devices = [cavium_zip]
 
 # global dict ethernet devices present. Dictionary indexed by PCI address.
@@ -89,7 +92,7 @@ def usage():
 
     --status-dev:
         Print the status of given device group. Supported device groups are:
-        "net", "crypto", "event", "mempool" and "compress"
+        "net", "crypto", "baseband", "event", "mempool" and "compress"
 
     -b driver, --bind=driver:
         Select the driver to use or \"none\" to unbind the device
@@ -586,6 +589,9 @@ def show_status():
     if status_dev == "crypto" or status_dev == "all":
         show_device_status(crypto_devices, "Crypto")
 
+    if status_dev == "baseband" or status_dev == "all":
+        show_device_status(baseband_devices, "Baseband")
+
     if status_dev == "event" or status_dev == "all":
         show_device_status(eventdev_devices, "Eventdev")
 
@@ -667,6 +673,7 @@ def do_arg_actions():
             # refresh if we have changed anything
             get_device_details(network_devices)
             get_device_details(crypto_devices)
+            get_device_details(baseband_devices)
             get_device_details(eventdev_devices)
             get_device_details(mempool_devices)
             get_device_details(compress_devices)
@@ -688,6 +695,7 @@ def main():
     get_device_details(network_devices)
     get_device_details(crypto_devices)
     get_device_details(eventdev_devices)
+    get_device_details(baseband_devices)
     get_device_details(mempool_devices)
     get_device_details(compress_devices)
     do_arg_actions()
diff --git a/usertools/dpdk-setup.sh b/usertools/dpdk-setup.sh
index d008074..15f91b8 100755
--- a/usertools/dpdk-setup.sh
+++ b/usertools/dpdk-setup.sh
@@ -496,13 +496,13 @@ step2_func()
 	TEXT[5]="Setup hugepage mappings for NUMA systems"
 	FUNC[5]="set_numa_pages"
 
-	TEXT[6]="Display current Ethernet/Crypto device settings"
+	TEXT[6]="Display current Ethernet/Crypto/Baseband device settings"
 	FUNC[6]="show_devices"
 
-	TEXT[7]="Bind Ethernet/Crypto device to IGB UIO module"
+	TEXT[7]="Bind Ethernet/Crypto/Baseband device to IGB UIO module"
 	FUNC[7]="bind_devices_to_igb_uio"
 
-	TEXT[8]="Bind Ethernet/Crypto device to VFIO module"
+	TEXT[8]="Bind Ethernet/Crypto/Baseband device to VFIO module"
 	FUNC[8]="bind_devices_to_vfio"
 
 	TEXT[9]="Setup VFIO permissions"
-- 
1.8.3.1

Re: [dpdk-dev] [PATCH v2] usertools: update to usertool for baseband device

[Mokhtar, Amr]

> -----Original Message-----
> From: Chautru, Nicolas
> Sent: Tuesday 11 June 2019 01:33
> To: thomas@monjalon.net; akhil.goyal@nxp.com; dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Mokhtar, Amr
> <amr.mokhtar@intel.com>; Chautru, Nicolas <nicolas.chautru@intel.com>
> Subject: [PATCH v2] usertools: update to usertool for baseband device
> 
> Allows binding of baseband devices
> 
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> ---

Acked-by: Amr Mokhtar <amr.mokhtar@intel.com>

Re: [dpdk-dev] [PATCH v2] usertools: update to usertool for baseband device

[Chautru, Nicolas]

Hi Thomas, 
Reminder on this one, I don't believe this was applied yet. https://patches.dpdk.org/patch/54632/
Thanks, 
Nic

-----Original Message-----
From: Chautru, Nicolas 
Sent: Monday, June 10, 2019 5:33 PM
To: thomas@monjalon.net; akhil.goyal@nxp.com; dev@dpdk.org
Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Mokhtar, Amr <amr.mokhtar@intel.com>; Chautru, Nicolas <nicolas.chautru@intel.com>
Subject: [PATCH v2] usertools: update to usertool for baseband device

Allows binding of baseband devices

Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
---
 usertools/dpdk-devbind.py | 10 +++++++++-
 usertools/dpdk-setup.sh   |  6 +++---
 2 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py index 9e79f0d..a6ee8f9 100755
--- a/usertools/dpdk-devbind.py
+++ b/usertools/dpdk-devbind.py
@@ -18,6 +18,8 @@
                    'SVendor': None, 'SDevice': None}  intel_processor_class = {'Class': '0b', 'Vendor': '8086', 'Device': None,
                    'SVendor': None, 'SDevice': None}
+acceleration_class = {'Class': '12', 'Vendor': None, 'Device': None,
+               'SVendor': None, 'SDevice': None}
 cavium_sso = {'Class': '08', 'Vendor': '177d', 'Device': 'a04b,a04d',
               'SVendor': None, 'SDevice': None}  cavium_fpa = {'Class': '08', 'Vendor': '177d', 'Device': 'a053', @@ -40,6 +42,7 @@  crypto_devices = [encryption_class, intel_processor_class]  eventdev_devices = [cavium_sso, cavium_tim, octeontx2_sso]  mempool_devices = [cavium_fpa, octeontx2_npa]
+baseband_devices = [acceleration_class]
 compress_devices = [cavium_zip]
 
 # global dict ethernet devices present. Dictionary indexed by PCI address.
@@ -89,7 +92,7 @@ def usage():
 
     --status-dev:
         Print the status of given device group. Supported device groups are:
-        "net", "crypto", "event", "mempool" and "compress"
+        "net", "crypto", "baseband", "event", "mempool" and "compress"
 
     -b driver, --bind=driver:
         Select the driver to use or \"none\" to unbind the device @@ -586,6 +589,9 @@ def show_status():
     if status_dev == "crypto" or status_dev == "all":
         show_device_status(crypto_devices, "Crypto")
 
+    if status_dev == "baseband" or status_dev == "all":
+        show_device_status(baseband_devices, "Baseband")
+
     if status_dev == "event" or status_dev == "all":
         show_device_status(eventdev_devices, "Eventdev")
 
@@ -667,6 +673,7 @@ def do_arg_actions():
             # refresh if we have changed anything
             get_device_details(network_devices)
             get_device_details(crypto_devices)
+            get_device_details(baseband_devices)
             get_device_details(eventdev_devices)
             get_device_details(mempool_devices)
             get_device_details(compress_devices)
@@ -688,6 +695,7 @@ def main():
     get_device_details(network_devices)
     get_device_details(crypto_devices)
     get_device_details(eventdev_devices)
+    get_device_details(baseband_devices)
     get_device_details(mempool_devices)
     get_device_details(compress_devices)
     do_arg_actions()
diff --git a/usertools/dpdk-setup.sh b/usertools/dpdk-setup.sh index d008074..15f91b8 100755
--- a/usertools/dpdk-setup.sh
+++ b/usertools/dpdk-setup.sh
@@ -496,13 +496,13 @@ step2_func()
 	TEXT[5]="Setup hugepage mappings for NUMA systems"
 	FUNC[5]="set_numa_pages"
 
-	TEXT[6]="Display current Ethernet/Crypto device settings"
+	TEXT[6]="Display current Ethernet/Crypto/Baseband device settings"
 	FUNC[6]="show_devices"
 
-	TEXT[7]="Bind Ethernet/Crypto device to IGB UIO module"
+	TEXT[7]="Bind Ethernet/Crypto/Baseband device to IGB UIO module"
 	FUNC[7]="bind_devices_to_igb_uio"
 
-	TEXT[8]="Bind Ethernet/Crypto device to VFIO module"
+	TEXT[8]="Bind Ethernet/Crypto/Baseband device to VFIO module"
 	FUNC[8]="bind_devices_to_vfio"
 
 	TEXT[9]="Setup VFIO permissions"
--
1.8.3.1

Re: [dpdk-dev] [PATCH v2] usertools: update to usertool for baseband device

[Thomas Monjalon]

24/06/2019 10:50, Mokhtar, Amr:
> From: Chautru, Nicolas
> > 
> > Allows binding of baseband devices
> > 
> > Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> 
> Acked-by: Amr Mokhtar <amr.mokhtar@intel.com>

Applied, thanks

Note: while rebasing the patch, I sorted baseband
between network and crypto.
I suggest to use this order in other lists, like release notes.