DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Chautru, Nicolas" <nicolas.chautru@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Mcnamara, John" <john.mcnamara@intel.com>,
	 "Kovacevic, Marko" <marko.kovacevic@intel.com>
Subject: Re: [dpdk-dev] [PATCH] doc: fix PDF build of bbdev prog guide
Date: Thu, 18 Jul 2019 15:09:05 +0000	[thread overview]
Message-ID: <1183128033837D43A851F70F33ED5C575C1FD5F1@FMSMSX109.amr.corp.intel.com> (raw)
In-Reply-To: <2224673.gYMo2qQLZG@xps>

From: Thomas Monjalon [mailto:thomas@monjalon.net] 
>18/07/2019 16:43, Chautru, Nicolas:
>> From: Thomas Monjalon [mailto:thomas@monjalon.net]
>> >3 comments above the change of references:
>> >
>> >- there are a lot more, please search for the word "section"
>> 
>> All the ones I could see are similar to "as per 3GPP TS 38.212 section 5.2.2" which is does not refer to a section within DPDK documentation but to external 3GPP specs documents.
>
>You're right! I completely overlooked it.
>
>> >- it deserves a separate commit
>> 
>> OK. And you want such a commit now for 19.09 or later on?
>
>Given there are only 2 figure refs, it can stay with PDF fix.
>
>> >- the line length should be below 100 chars, better below 80.
>> >The ideal is to break lines logically after a punctuation sign, or between "subject" and "verb", etc.
>> >Example:
>> >	Figure :numref:`figure_turbo_tb_encode` above
>> >	showing the Turbo encoding of CBs using BBDEV interface in TB-mode
>> >	is also valid for LDPC encode.
>> 
>> All lines are less than 100 chars, but a few places are >80 chars. Let me know if you want this changed for 19.09 or later.
>
>The rule is to not do cosmetic change :) I was explaining the line breaking for the lines you were changing while fixing figure ref.
>
>I think I will apply this patch and adjust the line breaking if needed.
>Is it OK?
>

Ok with me. Thanks Thomas.


  reply	other threads:[~2019-07-18 15:09 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-18  6:24 Nicolas Chautru
2019-07-18 13:53 ` Thomas Monjalon
2019-07-18 14:43   ` Chautru, Nicolas
2019-07-18 15:01     ` Thomas Monjalon
2019-07-18 15:09       ` Chautru, Nicolas [this message]
2019-07-18 13:57 ` Thomas Monjalon
2019-07-18 14:51   ` Chautru, Nicolas
2019-07-18 15:05     ` Thomas Monjalon
2019-07-18 21:49 ` Thomas Monjalon
2019-07-18 22:01 ` [dpdk-dev] [PATCH v3] " Thomas Monjalon
2019-07-18 22:04   ` Thomas Monjalon
  -- strict thread matches above, loose matches on Subject: below --
2019-07-17 22:01 [dpdk-dev] [PATCH] " Thomas Monjalon
2019-07-18 13:33 ` Chautru, Nicolas
2019-07-18 13:47   ` Thomas Monjalon
2019-07-18 14:59     ` Chautru, Nicolas
2019-07-18 15:09       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1183128033837D43A851F70F33ED5C575C1FD5F1@FMSMSX109.amr.corp.intel.com \
    --to=nicolas.chautru@intel.com \
    --cc=dev@dpdk.org \
    --cc=john.mcnamara@intel.com \
    --cc=marko.kovacevic@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).