From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 51B8EA0471 for ; Thu, 18 Jul 2019 17:09:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 461751DBE; Thu, 18 Jul 2019 17:09:10 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 33043A3 for ; Thu, 18 Jul 2019 17:09:07 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jul 2019 08:09:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,278,1559545200"; d="scan'208";a="367382583" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga006.fm.intel.com with ESMTP; 18 Jul 2019 08:09:06 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 18 Jul 2019 08:09:06 -0700 Received: from FMSMSX109.amr.corp.intel.com ([169.254.15.78]) by fmsmsx116.amr.corp.intel.com ([169.254.2.161]) with mapi id 14.03.0439.000; Thu, 18 Jul 2019 08:09:06 -0700 From: "Chautru, Nicolas" To: Thomas Monjalon CC: "dev@dpdk.org" , "Mcnamara, John" , "Kovacevic, Marko" Thread-Topic: [PATCH] doc: fix PDF build of bbdev prog guide Thread-Index: AQHVPWyj7yh/yF9u10+PR156zKwLI6bQ2vsA//+Wo6CAAHw2AP//jGig Date: Thu, 18 Jul 2019 15:09:05 +0000 Message-ID: <1183128033837D43A851F70F33ED5C575C1FD5F1@FMSMSX109.amr.corp.intel.com> References: <1563431079-14170-1-git-send-email-nicolas.chautru@intel.com> <2765522.ij6KrxUR9P@xps> <1183128033837D43A851F70F33ED5C575C1FD4AB@FMSMSX109.amr.corp.intel.com> <2224673.gYMo2qQLZG@xps> In-Reply-To: <2224673.gYMo2qQLZG@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTA1NzI2N2ItZjhkOS00ZjVmLThmZTktM2ZmYjZjZWU3M2JiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUE1LMGE5OFluMzJVZXZ4eXlyZjJ1RWswOElrREV4S0VkOFBxVFViRnN5NFl0K25JUDNnQXpKMmg4b0plRFFYRCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.1.200.106] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc: fix PDF build of bbdev prog guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Thomas Monjalon [mailto:thomas@monjalon.net]=20 >18/07/2019 16:43, Chautru, Nicolas: >> From: Thomas Monjalon [mailto:thomas@monjalon.net] >> >3 comments above the change of references: >> > >> >- there are a lot more, please search for the word "section" >>=20 >> All the ones I could see are similar to "as per 3GPP TS 38.212 section 5= .2.2" which is does not refer to a section within DPDK documentation but to= external 3GPP specs documents. > >You're right! I completely overlooked it. > >> >- it deserves a separate commit >>=20 >> OK. And you want such a commit now for 19.09 or later on? > >Given there are only 2 figure refs, it can stay with PDF fix. > >> >- the line length should be below 100 chars, better below 80. >> >The ideal is to break lines logically after a punctuation sign, or betw= een "subject" and "verb", etc. >> >Example: >> > Figure :numref:`figure_turbo_tb_encode` above >> > showing the Turbo encoding of CBs using BBDEV interface in TB-mode >> > is also valid for LDPC encode. >>=20 >> All lines are less than 100 chars, but a few places are >80 chars. Let m= e know if you want this changed for 19.09 or later. > >The rule is to not do cosmetic change :) I was explaining the line breakin= g for the lines you were changing while fixing figure ref. > >I think I will apply this patch and adjust the line breaking if needed. >Is it OK? > Ok with me. Thanks Thomas.