Re: [dpdk-dev] [PATCH v3 07/14] test-bbdev: support for performance tests

["Chautru, Nicolas" <nicolas.chautru@intel.com>]

From: Akhil Goyal <akhil.goyal@nxp.com> 
>> 
>> From: Nic Chautru <nicolas.chautru@intel.com>
>> 
>> Includes support for BLER wireless performance test with new arguments 
>> for SNR and number of iterations for 5G.
>> 
>It would be better to add more info in the commit log.
>You can add reference to some standard link which is being Followed so that patch can be reviewed.
>There should be some documentation about the test cases in this Patch.

I have added a bit more details in code and documentation but these are not really standard specific.
Purely adding gaussian and deriving LLR for the sake of quantifying decoding performance and comparing
across different PMD implementations.


>
>> +
>> +static inline double
>> +maxstar(double A, double B)
>> +{
>> +	if (fabs(A - B) > 5)
>> +		return fmax(A, B);
>> +	else
>> +		return fmax(A, B) + log1p(exp(-fabs(A - B))); }
>> +
>I think you can use RTE_MAX here.
>

I doesn't hurt.

Thanks
Nic