Re: [dpdk-dev] [PATCH v4 00/11] drivers/baseband: PMD for FPGA 5GNR FEC

["Chautru, Nicolas" <nicolas.chautru@intel.com>]

Hi Akhil, 

> I am seeing some compilation issues again on individual patches. Please be
> careful. This is causing a lot of duplicate effort.

Yes I missed that one unfortunately, something seems to be wrong in our CI for patch by patch build. I am checking manually for each commit this time. 

> 1. Rebase your release note just below the other baseband PMD change.

ok

> 2. remove DALLOW_EXPERIMENTAL_API from Makefile 
> 3. remove
> allow_experimental_apis = true from meson.build 

OK I see the related change. I am missing something about it but still will change for the sake of the rebase. 

> 4. header installation in
> meson.build is not correct -headers = files(
> -       'rte_pmd_fpga_5gnr_fec.h',
> -)
> +install_headers('rte_pmd_fpga_5gnr_fec.h')

ok

> Please do the above changes and make sure you check meson build/clang/gcc
> shared/static builds on all patches separately. I don't want to spend more time
> on this.

Got it. 

> 
> Regards,
> Akhil
> >
> > v4: Fix incremental patch build and expose PMD header file to meson.
> > v3: Incremental changes from reviews : file name change, moving few
> > inline function to .h, adding missing inline, doxygen markup fix.
> >
> > Adding new baseband PMD for FPGA 5GNR FEC implementation.
> >
> >
> > Nicolas Chautru (11):
> >   drivers/baseband: add PMD for FPGA 5GNR FEC
> >   baseband/fpga_5gnr_fec: add register definition file
> >   baseband/fpga_5gnr_fec: add info_get function
> >   baseband/fpga_5gnr_fec: add queue configuration
> >   baseband/fpga_5gnr_fec: add LDPC processing functions
> >   baseband/fpga_5gnr_fec: add HW error capture
> >   baseband/fpga_5gnr_fec: add debug functionality
> >   baseband/fpga_5gnr_fec: add configure function
> >   baseband/fpga_5gnr_fec: add harq loopback capability
> >   baseband/fpga_5gnr_fec: add interrupt support
> >   doc: add feature matrix table for bbdev devices
> >
> >  .gitignore                                         |    1 +
> >  app/test-bbdev/Makefile                            |    3 +
> >  app/test-bbdev/meson.build                         |    3 +
> >  app/test-bbdev/test_bbdev_perf.c                   |   57 +
> >  config/common_base                                 |    5 +
> >  doc/guides/bbdevs/features/default.ini             |   16 +
> >  doc/guides/bbdevs/features/fpga_5gnr_fec.ini       |   11 +
> >  doc/guides/bbdevs/features/fpga_lte_fec.ini        |   10 +
> >  doc/guides/bbdevs/features/mbc.ini                 |   14 +
> >  doc/guides/bbdevs/features/null.ini                |    7 +
> >  doc/guides/bbdevs/features/turbo_sw.ini            |   11 +
> >  doc/guides/bbdevs/fpga_5gnr_fec.rst                |  297 +++
> >  doc/guides/bbdevs/index.rst                        |    2 +
> >  doc/guides/bbdevs/overview.rst                     |   15 +
> >  doc/guides/conf.py                                 |    5 +
> >  doc/guides/rel_notes/release_20_05.rst             |    5 +
> >  drivers/baseband/Makefile                          |    2 +
> >  drivers/baseband/fpga_5gnr_fec/Makefile            |   29 +
> >  drivers/baseband/fpga_5gnr_fec/fpga_5gnr_fec.h     |  388 ++++
> >  drivers/baseband/fpga_5gnr_fec/meson.build         |   10 +
> >  drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 2186
> > ++++++++++++++++++++
> >  .../rte_pmd_bbdev_fpga_5gnr_fec_version.map        |   10 +
> >  .../baseband/fpga_5gnr_fec/rte_pmd_fpga_5gnr_fec.h |   74 +
> >  drivers/baseband/meson.build                       |    2 +-
> >  mk/rte.app.mk                                      |    1 +
> >  25 files changed, 3163 insertions(+), 1 deletion(-)  create mode
> > 100644 doc/guides/bbdevs/features/default.ini
> >  create mode 100644 doc/guides/bbdevs/features/fpga_5gnr_fec.ini
> >  create mode 100644 doc/guides/bbdevs/features/fpga_lte_fec.ini
> >  create mode 100644 doc/guides/bbdevs/features/mbc.ini
> >  create mode 100644 doc/guides/bbdevs/features/null.ini
> >  create mode 100644 doc/guides/bbdevs/features/turbo_sw.ini
> >  create mode 100644 doc/guides/bbdevs/fpga_5gnr_fec.rst
> >  create mode 100644 doc/guides/bbdevs/overview.rst  create mode 100644
> > drivers/baseband/fpga_5gnr_fec/Makefile
> >  create mode 100644 drivers/baseband/fpga_5gnr_fec/fpga_5gnr_fec.h
> >  create mode 100644 drivers/baseband/fpga_5gnr_fec/meson.build
> >  create mode 100644 drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
> >  create mode 100644
> >
> drivers/baseband/fpga_5gnr_fec/rte_pmd_bbdev_fpga_5gnr_fec_version.map
> >  create mode 100644
> > drivers/baseband/fpga_5gnr_fec/rte_pmd_fpga_5gnr_fec.h
> >
> > --
> > 1.8.3.1