From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com
 [209.85.212.173]) by dpdk.org (Postfix) with ESMTP id BEEA4ADC9
 for <dev@dpdk.org>; Tue, 24 Feb 2015 03:38:27 +0100 (CET)
Received: by mail-wi0-f173.google.com with SMTP id bs8so22288084wib.0
 for <dev@dpdk.org>; Mon, 23 Feb 2015 18:38:27 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=Yo6hxrejqTTElhBplq4jvXtesCKUBcSj6ZlN5oRdBKQ=;
 b=Ei+KlN0SE6KIzODFD3qDNubnH6xcxyg07hnMzauo3b8p6GFHpX+cN44Aroqshabkux
 6JqWrKtfLvcxl+6QXnpQNvgv3JlU4qlLGdeCaH1ry43Yy2saOU0H2AQKfyAZXrPv73+j
 mXUaGIpGK9TJq6CLv6/UvgNpGJkd0bxw6CdEkgOO3Q5o0zeKPznXUfRhKwHfYReHEUY1
 TKFkv1TRqqsNWGBxEzIbm1gtYqQxps5nhkclvRaWGuJ9fr7zF8x6kuwZE0Cv4wQyWSoD
 o7id5adGO0VhTn34VLePkz3jEq8btwCfmgCDGo77cMrJXi3MkTFAXIGIjFj/WTxLb5n5
 ekUg==
X-Gm-Message-State: ALoCoQmw4r5Cg7K7ZQ7YtG+Zc/s7BI1G4Q7bzKa/edK+gaswNmCf+peS5uDKnOnkLNj72LDA+Cm3
X-Received: by 10.180.21.162 with SMTP id w2mr26339049wie.42.1424745507580;
 Mon, 23 Feb 2015 18:38:27 -0800 (PST)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id hd5sm18394288wib.21.2015.02.23.18.38.26
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 23 Feb 2015 18:38:26 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <shemming@brocade.com>
Date: Tue, 24 Feb 2015 03:37:56 +0100
Message-ID: <11873508.VEDXbTx7T3@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; )
In-Reply-To: <CALwxeUti=ykMWDLA0X4jKRv9MTwv9tfbsBefhRRuj=QyYu-=NQ@mail.gmail.com>
References: <1423927979-13607-1-git-send-email-shemming@brocade.com>
 <20150214162822.GA14643@neilslaptop.think-freely.org>
 <CALwxeUti=ykMWDLA0X4jKRv9MTwv9tfbsBefhRRuj=QyYu-=NQ@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] enic: replace use of printf with log
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Feb 2015 02:38:28 -0000

> > > Device driver should log via DPDK log, not to printf which is
> > > sends to /dev/null in a daemon application.
> > >
> > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > 
> > Series
> > Acked-by: Neil Horman <nhorman@tuxdriver.com>
> 
> Use of rte_log would be better for init messages, but since the driver
> makes no difference, this looks good enough to me.
> Thanks Stephen.
> 
> Acked-by: David Marchand <david.marchand@6wind.com>

Applied, thanks