From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-we0-f171.google.com (mail-we0-f171.google.com [74.125.82.171]) by dpdk.org (Postfix) with ESMTP id A280F5921 for <dev@dpdk.org>; Thu, 5 Mar 2015 21:32:14 +0100 (CET) Received: by wevl61 with SMTP id l61so55413525wev.2 for <dev@dpdk.org>; Thu, 05 Mar 2015 12:32:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=gyLR1Eh0uXVjbVlZbTXdOdeyDWsp8HEMxheIk9PZRBA=; b=YaxS6zEhHoukcdgYXEKFwvC5Dr0hZlebToe1RbAuujJZRETZv8BssZ2zlqGm1dcEhe KhDUnmeRXeP97Y91vslAR7ZNq1t3PuHFmwgAaafqQ9qr0c1f4FLRKrvMYMhpcWx9BDmA LfeyvUtn353rDnfCxUoLsgzqnnkFCLTAvjODYImOqQ80jdpiTxaqpGFk96VoWm/NuEYG lgz+BKqRyCIZWuzYGmqjCm1ixwtncdt6v51waGqVJQeyORv5dLfJbjwzpZUdLMbxoeQ8 d/rZcNANujFX6WZ2THB9814vxDHDUgkbjeOn8DSlJ+2jcOcfcJ/JYjATZLy34AIzLS+H 3E4A== X-Gm-Message-State: ALoCoQleH3P0TmL9dV3IKrfjMXj4IkkqxQiNgyrPkJ/MI408vx11tEQ8lUG00tOPkhio7Jl4onUN X-Received: by 10.194.142.205 with SMTP id ry13mr22588147wjb.73.1425587534321; Thu, 05 Mar 2015 12:32:14 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id yr10sm9205177wjc.0.2015.03.05.12.32.12 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Mar 2015 12:32:13 -0800 (PST) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: "Ouyang, Changchun" <changchun.ouyang@intel.com> Date: Thu, 05 Mar 2015 21:31:37 +0100 Message-ID: <118801828.6UbpCNZDcL@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <533710CFB86FA344BFBF2D6802E60286CEE857@SHSMSX101.ccr.corp.intel.com> References: <1424926669-14202-1-git-send-email-changchun.ouyang@intel.com> <1425437735-20673-1-git-send-email-changchun.ouyang@intel.com> <533710CFB86FA344BFBF2D6802E60286CEE857@SHSMSX101.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] tools/dpdk_nic_bind: Fix can't bind virtio-pci issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 05 Mar 2015 20:32:14 -0000 > > The dpdk_nic_bind script will not allow ports to be bound or unbound if none of the > > kernel modules supported by DPDK is loaded. This patch relaxes this restriction by > > checking if a DPDK module is actually requested. The example below illustrates this > > problem: > > > > In virtio test, on the guest > > 1. Bind virtio port to igb_uio driver; > > 2. Remove igb_uio module; > > 3. Bind virtio port to virtio-pci driver, it fails and reports: > > "Error - no supported modules are loaded" > > > > The script should check the to-be-bound driver flag, if it is dpdk driver(igb_uio, vfio etc), > > and the corresponding module is not loaded, then exit, otherwise, just report a warning, > > and continue to bind the non-dpdk driver(like virtio-pci) to dev. > > > > Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com> > Acked-by: Michael Qiu <michael.qiu@intel.com> Applied, thanks