From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 7FF718E83 for ; Tue, 24 Nov 2015 11:29:40 +0100 (CET) Received: by wmww144 with SMTP id w144so19804693wmw.0 for ; Tue, 24 Nov 2015 02:29:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=iAGKkHcwb4pcNz6q4G5JYcNAZAVK41EnoV1uwvreKy0=; b=dhoBVO/tbrZ+NlKg2lGqOfFqVmEkYiUuhoghbSXvFuN0dqOIho8oogmvbRA/mIVfeY YPEB4z5uHCDgjeEAZ4AmRDhRiS69BcFEU9HIGYhB6WbyzFGIX79zUnlnKJSiWoctvefz TdxFsohyG8UgYDpbcwgPF8igyMWrqBWjY7pQv0y/pk8QjSR7Dvbe9BdoAYqKYEdnhir/ 298hfV8LJvjUKLlFmDHuWuow94BwX/csQK++8Mu0iiQIQF9m9Dp8vTLVB35g+TR7fZ3b YjdbNdxTPeoRgTkVvE1ZfaUSdQW3+aOo4IOc4vPRTNCGsHkkVewa3XykZQpDw2M4pBB2 fzxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=iAGKkHcwb4pcNz6q4G5JYcNAZAVK41EnoV1uwvreKy0=; b=YpkqVXEx04kfxNqJxOM+IMNs7s6UaTGN6bMzlCxWBj1s0QMC/WAGYgpEIm6AAD8nhl lNXVHhESMvSF4z4e9QlAkXRGnhrTk4C9dfA8dhg5PWIgy+P62uUUv55czFLekkz4W0cE 6p0dXPelt6BmuNLOfwDXgE59h8ALQ/+4F8OSS7dcJuCVk+m6nLRx/YGNIpjY2US7R7I6 BrlvjY2U1jGDYu4sBaJEl7QfpoGebCzosKN3A+XsWEjIufPaNvC3M64bim7g6F00k5D+ 9IUvJ9YkvndDnzVNkoFYYVUY1Qle1whWhl9X9a1+sbWUfwQGJfl2Zx7xGyrbY8mFmgop wZ/Q== X-Gm-Message-State: ALoCoQnS45TaFrNN7pP1XB29FxbRltZ6taPDaDX0JwUaCCQKmeNB9OpVnrY2ACrfmkYMONMRWdQ5 X-Received: by 10.194.7.230 with SMTP id m6mr19388920wja.124.1448360979670; Tue, 24 Nov 2015 02:29:39 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id w203sm17369751wmg.15.2015.11.24.02.29.38 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 24 Nov 2015 02:29:39 -0800 (PST) From: Thomas Monjalon To: Shaopeng He Date: Tue, 24 Nov 2015 11:28:22 +0100 Message-ID: <11881693.ZHnXqqknjk@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20151120083527.64ffd576@xeon-e3> References: <1448000935-29391-1-git-send-email-shaopeng.he@intel.com> <1448028587-7718-1-git-send-email-shaopeng.he@intel.com> <20151120083527.64ffd576@xeon-e3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3] fm10k: fix wrong VLAN value in RX mbuf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Nov 2015 10:29:40 -0000 > > vlan_tci should be copied from RX descriptor to mbuf, > > and flag PKT_RX_VLAN_PKT should be set for every RX packet, > > this patch fixes this issue. > > Packets in fm10k device always carry at least one VLAN tag. > > For those packets coming in without VLAN tag, > > the port default VLAN tag will be used. > > So in fm10k, always PKT_RX_VLAN_PKT flag is set and vlan_tci > > is valid for each RX packet's mbuf. > > > > Signed-off-by: Shaopeng He > > Looks good thanks. > > Acked-by: Stephen Hemminger Applied, thanks