From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by dpdk.org (Postfix) with ESMTP id C7A2A9A8A for ; Thu, 16 Apr 2015 10:53:16 +0200 (CEST) Received: by widdi4 with SMTP id di4so89051535wid.0 for ; Thu, 16 Apr 2015 01:53:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=yS/ElNKZ1l2VwM+bchOpi4YJv9lsM9nso20wF5o4h/c=; b=g1kM3CrQjyQnZ6WXuyoRseJDyOA7Nz+1ODm/kiZwrZ4y32CaL/TjnmqapbORtDnE/Y UHQlNUe4ympx3eGzx+xG7rWh7Tnmx/cwHUS6nkhbY2NItraguuzzbg+kaQVJJLcKN0gq nmHWps+nGJRZp9GL80ClzZQRkuqwwIjHJ4xxelEDjIPCIRteaa0Mk33o0SdpZ4KNJuuF GCXDa/hhCVdKcQWce09xnZmQauIfqyYMSn8MfCQ0prC7f2O7E+5wQiXWw5YJJZlV/Y5S yXlsYSOjdyh+SZC5kMuHw+9SY3Shdri3R5dls0FkdKw8pKizcAhqPeGm0p59f4rPPFTN yl5w== X-Gm-Message-State: ALoCoQl/LaWkIkvv+C47S1+VIZOikExi+u+CYmRUYgPVJn/6rOY1TjDYwAfgxFeAtYfLIIdWzADF X-Received: by 10.180.103.231 with SMTP id fz7mr5678165wib.35.1429174396681; Thu, 16 Apr 2015 01:53:16 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id 16sm9399847wjs.41.2015.04.16.01.53.15 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Apr 2015 01:53:15 -0700 (PDT) From: Thomas Monjalon To: Ravi Kerur Date: Thu, 16 Apr 2015 10:52:32 +0200 Message-ID: <119098819.UXtPphdbAd@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <1428608412-31191-6-git-send-email-rkerur@gmail.com> References: <1428608301-31033-1-git-send-email-rkerur@gmail.com> <1428608412-31191-1-git-send-email-rkerur@gmail.com> <1428608412-31191-6-git-send-email-rkerur@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v5 5/8] Move common functions in eal_memory.c X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Apr 2015 08:53:17 -0000 2015-04-09 12:40, Ravi Kerur: > Changes in v5 > Rebase to latest code. > > Changes in v4 > Make rte_eal_hugepage_init and rte_eal_hugepage_attach as > wrapper functions for BSD. > > Changes in v3 > Changed subject to be more explicit on file name inclusion. > > Changes in v2 > Use common function names rte_eal_hugepage_init and > rte_eal_hugepage_attach for BSD and Linux. Update comments about its > actuality in function declaration. > > Changes in v1 > Move common functions in eal_memory.c to librte_eal/common/ > eal_common_memory.c file. > > Following functions are moved to eal_common_memory.c file > > static int rte_eal_memdevice_init(void); int rte_eal_memory_init(void); > > Fix checkpatch warnings and errors. > > Signed-off-by: Ravi Kerur [...] > +/** > + * This function prepares physical memory mapping > + * i.e. hugepages on Linux and > + * contigmem on BSD. OK > + * It is a wrapper function for BSD which will > + * internally call contigmem_init. Please avoid such comment which is difficult to maintain and not really useful. > + * It is a wrapper function for BSD which will > + * internally call contigmem_attach. Same comment. Except the above comments, it seems goods. Acked-by: Thomas Monjalon Thanks