From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A8834A00BE; Tue, 19 Apr 2022 10:58:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 50BF24068E; Tue, 19 Apr 2022 10:58:48 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id A3A7540687 for ; Tue, 19 Apr 2022 10:58:46 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id F27C25C0108; Tue, 19 Apr 2022 04:58:45 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 19 Apr 2022 04:58:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1650358725; x= 1650445125; bh=sWuBYFOFmb/AgeX5SJdZRuyCXf/+dHbbnq+uvO9YHH8=; b=o xHa89u03HidjmwTKkOV4m5g0OL7qqkJVMpMqs0D2sxZXHyuYX1TyC5wpQSX1D8Un PUALny3qq91I7dp8PqJSN2NejgnChL5kR1JAds+ZVZVjl7OqUD1J2rwcfmL3UrBj e/2V/0KqVRHc1QNekqXyokSplXqwaYMG1Rr+6hAHsXbaY1FzreTRCaB8ZvP47LUh /+8qWqxMa/htNf8uztjtdqSgB299E5TTjejXbto9Lgxbs82VYHriUjXGos6HEJln scM9CBkPB6+VMxH6TGIT3Zh10nu3mp5+Jq6CmQPpSvW6/vX6Bsna+8B5YeF5Uxok 4OOcdSJRQzIFMOZSA4h5w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1650358725; x=1650445125; bh=sWuBYFOFmb/Ag eX5SJdZRuyCXf/+dHbbnq+uvO9YHH8=; b=IkHJ5+SNgnpK1S04kVenbrEfBdRjW GgsSc71MU8Q+fu+5v6pyTOiukenuOZaLVh4/TrqOpkkeC3cH7Bmcw6pQ/wiy/ZRw FREUX++IbI3jY3FZILWQeZHIspyBgcKQmC5yHqGxPiU9uA/j62XLIMAXR6Bo1vLr J40OGAqcdypZ9ZBAatcTxvlbpcPb2EZw2e6MeLXC1Tp3BM6XXrnWQViIPobL8f/A lerauyRhCXJDCZ3XqDYQQy3D69M2kp1GLQr2UyrMDNKJydtP49iXGAcWsTxA+L4v M5uz3fH6CQz/SpBaQKUK+eSLyNiRRTE40erdBvfprwo5xVgV4m3IWArYw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrvddtfedgtdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 19 Apr 2022 04:58:43 -0400 (EDT) From: Thomas Monjalon To: Akhil Goyal Cc: dev@dpdk.org, david.marchand@redhat.com, hemant.agrawal@nxp.com, anoobj@marvell.com, konstantin.ananyev@intel.com, ciara.power@intel.com, ferruh.yigit@intel.com, andrew.rybchenko@oktetlabs.ru, ndabilpuram@marvell.com, vattunuru@marvell.com Subject: Re: [PATCH v4 07/10] ethdev: add IPsec SA expiry event subtypes Date: Tue, 19 Apr 2022 10:58:41 +0200 Message-ID: <11961195.O9o76ZdvQC@thomas> In-Reply-To: <20220416192530.173895-8-gakhil@marvell.com> References: <20220217172341.607360-1-gakhil@marvell.com> <20220416192530.173895-1-gakhil@marvell.com> <20220416192530.173895-8-gakhil@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 16/04/2022 21:25, Akhil Goyal: > --- a/lib/ethdev/rte_ethdev.h > +++ b/lib/ethdev/rte_ethdev.h > @@ -3828,6 +3828,12 @@ enum rte_eth_event_ipsec_subtype { > RTE_ETH_EVENT_IPSEC_SA_TIME_EXPIRY, > /** Soft byte expiry of SA */ > RTE_ETH_EVENT_IPSEC_SA_BYTE_EXPIRY, > + /** Soft packet expiry of SA */ Is there a reference explaining what exactly is a "soft packet expiry"? I think you should also mention what should be done in the event handler. > + RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY, > + /** Hard byte expiry of SA */ > + RTE_ETH_EVENT_IPSEC_SA_BYTE_HARD_EXPIRY, > + /** Hard packet expiry of SA */ > + RTE_ETH_EVENT_IPSEC_SA_PKT_HARD_EXPIRY, Same comment for the 3 events. > /** Max value of this enum */ > RTE_ETH_EVENT_IPSEC_MAX > }; What is the impact of this "MAX" value on ABI compatibility?