Re: [dpdk-dev] [PATCH v2 2/3] eal: add new rte color definition

[Thomas Monjalon <thomas@monjalon.net>]

18/12/2018 14:19, Dumitrescu, Cristian:
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > 18/12/2018 12:18, Dumitrescu, Cristian:
> > > > > I replied in v3 that it should stay in rte_meter.h.
> > > > > You can include rte_meter.h in ethdev.
> > > >
> > > > OK, thanks Thomas, makes sense to me as well.
> > > >
> > >
> > > Thomas,
> > >
> > > I agree with your input, but just want to make sure we are on the same
> > page:
> > >
> > > Besides including rte_meter.h in ethdev (which you are fine with), we
> > would also need to include rte_meter.h in mbuf.
> > >
> > > Are you OK with this as well?
> > 
> > Why do we need rte_meter.h in mbuf?
> > 
> 
> You probably looked at V2 only, but in V3 we have functions to set/get the color within the mbuf->hash.sched field.
> 
> For space compression reasons, the mbuf->hash.sched stores the color on 8-bit variable, while for the outside world the set/get functions work with the 32-bit enum type. We do same thing in other places in DPDK, such as rte_crypto_op, etc.

So it's a different discussion.
We need to review this v3 and check how relevant this mbuf API is.

If the API is accepted, yes the include should not be an issue.