From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 750AAA034C; Wed, 22 Jun 2022 18:29:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 246E940A84; Wed, 22 Jun 2022 18:29:59 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2079.outbound.protection.outlook.com [40.107.244.79]) by mails.dpdk.org (Postfix) with ESMTP id 5B78B4069F for ; Wed, 22 Jun 2022 18:29:57 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hp5l2nsvfyK5H8VWh8oy24RodSqpYAaEe5PRCgv6pquv2wZ/GQRsDGWEJr5f53qPQco0nYVl+mD1seIGHfSRRNoCaOfKRAEtjvW5u3h+cteCXMhPR5Bujgw3jShfeL7PGlmqO9n/uXP50PChBH/dT/spu+CZcCuNaeQ5H+sF+9O9kCFeaQkjBcUNWzMQAPhUt7Tc2skvgx4A5XkbvRX86MUR5qGrhQkuQUpI/ajKuAocXwUJPmJhE8QvTXmJZmF++DMnRVX3Z3MslI9jyOx+ispoIi2A2QPmI68nYujD5czQN49MGJVyyIB/HfJApbH9BSQjn9agnYAjrttVBeHM5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FE6EsXPi9GoKNU6+8znmx03nZNdX8yCrsX+sCB/S+tc=; b=RfqNsu9QUHo4f6CT18uH7oCrPaw02nHvpobRQVxuUhLV5VSCKKWdE4TdjmFszPONuuH2N1U/Y9qOeS5XzdVqg4MbeezjWdMH/C8i62jMFpi2Y6JauzBGHtl/hmABBdO2+ZCBdxFb1SstDehvaaAkQBmxqQ1/913oWIbd6QuzBbqzbFwHvitt1ZJHAuRHnFP0JlAdud9kmjpXM9INEhtfoA9xS8VDdNOCjq5micXlS4h7pJtetTFkFmOGJcZJjHCJT3U1qxOUjDp1tGE28J4umq6oSFCpZvhJb7kEw57e4CQgcYXJJzXeaLTHx9DIR33zEERBDT2sEuEEvDdTJXLxaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=monjalon.net smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FE6EsXPi9GoKNU6+8znmx03nZNdX8yCrsX+sCB/S+tc=; b=JenSUMwvAdHnA/t4ZxTpHHvtK0JP10ApWHAtZo7EC8IdBpgv8DvN/RVuVWEOZHmabYQ5VLCqX5yl/3k3bFOns4A1Iwbo0AhSngZTL+pKZ2+XXdkjokQcGLNhmdWFj5Z4lc0l1d7sh9KlQsRx+2B07HWrdegB0wq9VD4OV33smZE= Received: from DM6PR06CA0082.namprd06.prod.outlook.com (2603:10b6:5:336::15) by DM6PR02MB5259.namprd02.prod.outlook.com (2603:10b6:5:43::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.18; Wed, 22 Jun 2022 16:29:55 +0000 Received: from DM3NAM02FT059.eop-nam02.prod.protection.outlook.com (2603:10b6:5:336:cafe::f5) by DM6PR06CA0082.outlook.office365.com (2603:10b6:5:336::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15 via Frontend Transport; Wed, 22 Jun 2022 16:29:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com; pr=C Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by DM3NAM02FT059.mail.protection.outlook.com (10.13.4.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5373.15 via Frontend Transport; Wed, 22 Jun 2022 16:29:54 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Wed, 22 Jun 2022 17:29:52 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Wed, 22 Jun 2022 17:29:52 +0100 Envelope-to: thomas@monjalon.net, jin.liu@corigine.com, dev@dpdk.org, niklas.soderlund@corigine.com, na.wang@corigine.com, peng.zhang@corigine.com, chaoyong.he@corigine.com, ferruh.yigit@amd.com, david.marchand@redhat.com, andrew.rybchenko@oktetlabs.ru Received: from [10.71.119.54] (port=15193) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1o43Em-0000tu-HO; Wed, 22 Jun 2022 17:29:52 +0100 Message-ID: <119cb518-a8b9-1de4-66f6-0d95deb68be6@xilinx.com> Date: Wed, 22 Jun 2022 17:29:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v3 12/13] net/nfp: nfdk packet xmit function Content-Language: en-US To: Thomas Monjalon , Jin Liu CC: , , Diana Wang , Peng Zhang , Chaoyong He , , , References: <20220616023939.1798769-1-jin.liu@corigine.com> <20220617093444.2004000-1-jin.liu@corigine.com> <20220617093444.2004000-13-jin.liu@corigine.com> <3767635.TLnPLrj5Ze@thomas> From: Ferruh Yigit In-Reply-To: <3767635.TLnPLrj5Ze@thomas> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1c8a1f0c-4081-40d7-373e-08da546c703f X-MS-TrafficTypeDiagnostic: DM6PR02MB5259:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aEbhke6NuTXpfuk7OYEHBD3FXTQ9kZ3UajgZ11AEa2fSzyG8z25YaHbBQTrehmL4RJADsQE79wPcWn+hyr7CidI1SI0ZhzejDvxv4Dx7cydwhk2jfokXaH6gcFkmKIlH1ybZbDXS5Gi5CU9hS2JN069FH+mvmQGzS08wfNA3ckaEGUDkW/k4lqVaikzG6jXK0v8LTpPxS5YA48qcHwOxxJ9MMZpUFEp7EMC/BgpzwPZRWRgEyEZXFrTbgK0wpFzVT7MkrTeP9ovF7hDSEIvSBUxn+yboKVKApN379Hr5JqPI4ap9GUS60dPCKJrM2zlMywlhKLAVmNCXTEAGyyyLd7tagj05ZNZ3mvx9OiPh3IO2OkJvECNBrCThjlsuSAPsOnXoNR2ksUQnTQjfzwdKG6ncU+grlD7m+Z7km7P6ynuJkBVTSASinav0nWPC82YZSY6qdVX/316Npb5G+Nu5v5o6SWPBSy0VNkZezSWkC6I/ZIO3lG0U6gQlBlnfjGMKKyA7xcjMVHUMHpkeBhDLCXvKKWLHSS+kF7hn1tRb81al3nwzxJpO/1MjwHnJwtx6qE5pNX5xhYSDRYyqWK2AUggE7/N6HDw0H6mLTMd+Ti+Cny3sI6/F++FOLxRRf8+AS0U1+jeGOVheLNhTzjtFHbSLqb4bMz7DxSOQ9HSpk9T0VSfiwGMI1f04wx2KzfwR8EMccwqz/QLlwf5+mvs5S/11BL3shqo4khPr1s2Hq82Bfs8vQ1QeCvZLdkanpa4WQGewkYKaOPd3eKNgN/wbtNVei4Gdtsx3N6rFTGdk3rEfV2yT3jeeHC2ddQeBEOL3adtVFXi9vs+bHx7NAjVnVG0QK7MDnOhhqIBSSoC/VPs= X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch02.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230016)(4636009)(396003)(376002)(39860400002)(346002)(136003)(40470700004)(46966006)(36840700001)(82310400005)(8676002)(110136005)(54906003)(40480700001)(478600001)(41300700001)(82740400003)(316002)(31696002)(2906002)(356005)(53546011)(7636003)(966005)(31686004)(4326008)(40460700003)(47076005)(2616005)(186003)(426003)(9786002)(5660300002)(336012)(83380400001)(7416002)(70206006)(36860700001)(26005)(70586007)(36756003)(8936002)(44832011)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2022 16:29:54.0707 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1c8a1f0c-4081-40d7-373e-08da546c703f X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT059.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB5259 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/22/2022 5:03 PM, Thomas Monjalon wrote: > 17/06/2022 11:34, Jin Liu: >> + if (unlikely(pkt->nb_segs > 1 && >> + !(hw->cap & NFP_NET_CFG_CTRL_GATHER))) { >> + PMD_INIT_LOG(INFO, "NFP_NET_CFG_CTRL_GATHER not set"); >> + rte_panic("Multisegment packet unsupported\n"); >> + } > [...] >> + if (round_down(txq->wr_p, NFDK_TX_DESC_BLOCK_CNT) != >> + round_down(txq->wr_p + used_descs - 1, NFDK_TX_DESC_BLOCK_CNT)) { >> + rte_panic("Used descs cross block boundary\n"); >> + } > > You cannot use rte_panic in a driver or library. > It will make the user experience terrible. > If there is a failure, please log an error and return appropriately. > > There is a check in the CI to avoid such use: > https://patches.dpdk.org/project/dpdk/patch/20220617093444.2004000-13-jin.liu@corigine.com/ > https://mails.dpdk.org/archives/test-report/2022-June/290206.html > > It seems you've ignored this critical warning. > > I don't want to let new occurences of rte_panic enter in drivers, > so I'll drop this patch from the main branch. > Please re-submit without rte_panic. > > I also missed it, dropping patch from next-net.