From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id 51FDA2B94 for ; Thu, 30 Mar 2017 10:54:00 +0200 (CEST) Received: from 6wind.com (unknown [10.16.0.184]) by proxy.6wind.com (Postfix) with SMTP id F39B12685C; Thu, 30 Mar 2017 10:53:53 +0200 (CEST) Received: by 6wind.com (sSMTP sendmail emulation); Thu, 30 Mar 2017 10:52:55 +0200 From: Pascal Mazon To: keith.wiles@intel.com Cc: dev@dpdk.org, Pascal Mazon Date: Thu, 30 Mar 2017 10:52:47 +0200 Message-Id: <11b7aa6796bd3e4147fbd4ec14b0125b6419aa80.1490863952.git.pascal.mazon@6wind.com> X-Mailer: git-send-email 2.12.0.306.g4a9b9b3 Subject: [dpdk-dev] [PATCH 1/2] net/tap: UDP/TCP port mask not supported in flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Mar 2017 08:54:00 -0000 Only full mask (0xffff) is accepted, there is no way to specify a mask for layer 4 ports to the kernel using TC rules. Fixes: 1c71189ab9b7 ("net/tap: add basic flow API patterns and actions") Signed-off-by: Pascal Mazon --- drivers/net/tap/tap_flow.c | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c index 514e3fae5c38..cf1c8a26c8ff 100644 --- a/drivers/net/tap/tap_flow.c +++ b/drivers/net/tap/tap_flow.c @@ -614,18 +614,20 @@ tap_flow_create_udp(const struct rte_flow_item *item, void *data) /* check that previous ip_proto is compatible with udp */ if (info->ip_proto && info->ip_proto != IPPROTO_UDP) return -1; + /* TC does not support UDP port masking. Only accept if exact match. */ + if ((mask->hdr.src_port && mask->hdr.src_port != 0xffff) || + (mask->hdr.dst_port && mask->hdr.dst_port != 0xffff)) + return -1; if (!flow) return 0; msg = &flow->msg; nlattr_add8(&msg->nh, TCA_FLOWER_KEY_IP_PROTO, IPPROTO_UDP); if (!spec) return 0; - if (spec->hdr.dst_port && - (spec->hdr.dst_port & mask->hdr.dst_port) == spec->hdr.dst_port) + if (spec->hdr.dst_port & mask->hdr.dst_port) nlattr_add16(&msg->nh, TCA_FLOWER_KEY_UDP_DST, spec->hdr.dst_port); - if (spec->hdr.src_port && - (spec->hdr.src_port & mask->hdr.src_port) == spec->hdr.src_port) + if (spec->hdr.src_port & mask->hdr.src_port) nlattr_add16(&msg->nh, TCA_FLOWER_KEY_UDP_SRC, spec->hdr.src_port); return 0; @@ -658,18 +660,20 @@ tap_flow_create_tcp(const struct rte_flow_item *item, void *data) /* check that previous ip_proto is compatible with tcp */ if (info->ip_proto && info->ip_proto != IPPROTO_TCP) return -1; + /* TC does not support TCP port masking. Only accept if exact match. */ + if ((mask->hdr.src_port && mask->hdr.src_port != 0xffff) || + (mask->hdr.dst_port && mask->hdr.dst_port != 0xffff)) + return -1; if (!flow) return 0; msg = &flow->msg; nlattr_add8(&msg->nh, TCA_FLOWER_KEY_IP_PROTO, IPPROTO_TCP); if (!spec) return 0; - if (spec->hdr.dst_port && - (spec->hdr.dst_port & mask->hdr.dst_port) == spec->hdr.dst_port) + if (spec->hdr.dst_port & mask->hdr.dst_port) nlattr_add16(&msg->nh, TCA_FLOWER_KEY_TCP_DST, spec->hdr.dst_port); - if (spec->hdr.src_port && - (spec->hdr.src_port & mask->hdr.src_port) == spec->hdr.src_port) + if (spec->hdr.src_port & mask->hdr.src_port) nlattr_add16(&msg->nh, TCA_FLOWER_KEY_TCP_SRC, spec->hdr.src_port); return 0; -- 2.12.0.306.g4a9b9b3