From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 7288298 for ; Thu, 23 Aug 2018 13:51:17 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Aug 2018 04:51:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,278,1531810800"; d="scan'208";a="84279757" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.56]) ([10.237.221.56]) by orsmga001.jf.intel.com with ESMTP; 23 Aug 2018 04:51:14 -0700 To: Thomas Monjalon , keith.wiles@intel.com Cc: rasland@mellanox.com, ophirmu@mellanox.com, dev@dpdk.org References: <1528374591-26126-1-git-send-email-rasland@mellanox.com> <20180720111552.14132-1-thomas@monjalon.net> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: <11c5a98a-7c21-c60a-1f77-651e40438810@intel.com> Date: Thu, 23 Aug 2018 12:51:14 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180720111552.14132-1-thomas@monjalon.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3] net/tap: add queues when attaching from secondary process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Aug 2018 11:51:17 -0000 On 7/20/2018 12:15 PM, Thomas Monjalon wrote: > From: Raslan Darawsheh > > In the case the device is created by the primary process, > the secondary must request some file descriptors to attach the queues. > The file descriptors are shared via IPC Unix socket. > > Thanks to the IPC synchronization, the secondary process > is now able to do Rx/Tx on a TAP created by the primary process. > > Signed-off-by: Raslan Darawsheh > Signed-off-by: Thomas Monjalon > --- > Note: there is a bug in EAL IPC regarding fd translation. > A fix will be sent later for EAL. > > v3: > - split some long lines > v2: > - translate file descriptors via IPC API > - add documentation > --- > doc/guides/nics/tap.rst | 16 +++ > doc/guides/rel_notes/release_18_08.rst | 5 + Needs to be 18.11 release notes now. <...> > @@ -1946,8 +2056,18 @@ rte_pmd_tap_probe(struct rte_vdev_device *dev) > TAP_LOG(ERR, "Failed to probe %s", name); > return -1; > } > - /* TODO: request info from primary to set up Rx and Tx */ > eth_dev->dev_ops = &ops; > + eth_dev->rx_pkt_burst = pmd_rx_burst; > + eth_dev->tx_pkt_burst = pmd_tx_burst; > + > + if (!rte_eal_primary_proc_alive(NULL)) { > + TAP_LOG(ERR, "Primary process is missing"); > + return -1; > + } > + ret = tap_mp_attach_queues(name, eth_dev); > + if (ret != 0) > + return -1; > + Should update rte_pmd_tun_probe() too? > rte_eth_dev_probing_finish(eth_dev); > return 0; > } > @@ -1998,10 +2118,19 @@ rte_pmd_tap_probe(struct rte_vdev_device *dev) > ret = eth_dev_tap_create(dev, tap_name, remote_iface, &user_mac, > ETH_TUNTAP_TYPE_TAP); > > + /* Register IPC feed callback */ > + ret = rte_mp_action_register(TAP_MP_KEY, tap_mp_sync_queues); > + if (ret < 0 && rte_errno != EEXIST) { > + TAP_LOG(ERR, "%s: Failed to register IPC callback: %s", > + tuntap_name, strerror(rte_errno)); > + goto leave; > + } This is causing an error if there are multiple tap devices, since it tries to register multiple times.